Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <583d3642-a79e-fee0-5c90-84eac82c3812@amd.com>
Date:   Tue, 3 Jan 2023 18:35:13 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v9 13/13] Documentation: amd-pstate: introduce new global
 sysfs attributes
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, wyes.karny@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221225163442.2205660-1-perry.yuan@amd.com>
 <20221225163442.2205660-14-perry.yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221225163442.2205660-14-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGo2K2oxNDloZm5JUFM3OTNQeHhSK2VzQUZOcHZici9wRUxqMEswcE5jcVFs?=
 =?utf-8?B?Y3lLYmRBbkdicU9kL1BKWVU2UktWOEJtTlMyUVpHdklDUkVJNG5FM2paOVRt?=
 =?utf-8?B?OElQVWtJTWtBdmdMRDBoUkRnaUpaWEN2NTY0bkpHUFg1Z1M3M1ZRdndGVERn?=
 =?utf-8?B?YWRZMkRRelMxaEl6UXRZMW9CUU1GMjdCdmdCaEcrMktZaXBGTzFpMHRrdGFu?=
 =?utf-8?B?RHRLQVJDYzR1RmRpOUlza1kvdUI1UENqN1ZmYVdhWWdwVUN5K0hwVVdTYTVH?=
 =?utf-8?B?VnhURFJYcXJVVWZwN0l0dEUvNlVmVUZKY3h5bzc3OGN5Vjh3SjVQT0lrN2FO?=
 =?utf-8?B?TUFjbHlKN3BYUXY3Zk96YTJ6S3ZsY2xjeXJDM29uOVlsaTMyK3lwWDhsRmhm?=
 =?utf-8?B?SHhiR3pRYXgreVptZWtRMEZuNnFpbjBXTWxvMzBWTkZsZTZVVmN2enpzR0hV?=
 =?utf-8?B?Zm5QVHZNVk5URWoxdnFES3kyRkh2U1F4VVhYa0s2UHNRZ0NOUjQ4eVV5U2tG?=
 =?utf-8?B?eENsdjY5QmlRYkt0ZXN2Sktsb1VycFBaMFc0Z21NeGdHK1B3NkovZWJwQytO?=
 =?utf-8?B?K3UyNjlTckY0QnZ0a2NkY0RveFNKWWRoWi83TlcxbWx2cFIvOC9mYmlFcTBN?=
 =?utf-8?B?cnBzdlpTK2w0Vkl0R0s2R3BneitOZGVCOVkvaC94eEVEM1dMWFBpUkZLeTNL?=
 =?utf-8?B?ZnNIWTl1WHFDMjV6TStvV1lMTVNYRUJrMVZHSXg2T0dmT3JKR0dqbXV6RDdV?=
 =?utf-8?B?ai84ckx1UUdwa0VNOUthc0NyRTBYZUlaSTlJUlhaK2lZQStSRVlHOVpYVXZx?=
 =?utf-8?B?c2QrU3lkRTAyU01IbWNhSDJYS3hEM0svU3B5dGhVRU1RekJEaXRDS1BxU3ho?=
 =?utf-8?B?UXVJalorRkdXcGloaGlxZ3kzcXpySHQ2U2FxWmFDU29jYWJudGw2dDVSNktE?=
 =?utf-8?B?TVdLVS9BdlloWTJ3K2Qra0ZFZXJWbGlXSGIxdSt5SG9tTGVBLzRQd1hxVmhR?=
 =?utf-8?B?SkoycUUrYTN1dWdFa1pXekpZVklWNlpLZ0JpUlYzdE9vVUVNK09JeSs5UXRZ?=
 =?utf-8?B?WWlGczRVTkRsTEV0TzBvSzd3Q1RhRi8yVldPcjg3TDRja1krdCtLZ2x2NWpY?=
 =?utf-8?B?YTVDQmxva1pySUp2cWhIKzBjbzVyVTVBNjFPUXo4c0Q0Z25MSTlZOWVmdFdj?=
 =?utf-8?B?T3BZdUZlV2Z5bzkwcWNHeVdHT0FFQldKemc5UmtXLzFxSXpEU0hYS2N0eGtV?=
 =?utf-8?B?akZIc090VkpLLzJmSG5JTWc2RjllY0RsYnpORG8yRGtsN0FiUTB0TUxYeDZ2?=
 =?utf-8?B?b2swSXh0WGxldXdIS2VHT2FBNTNIR0d2VDlERFlTL09WcGphOFdlZ1lrUUVT?=
 =?utf-8?B?d1QwbnlpUEtQR05Td3paTGRLRm1IL3BxV2VDdW10dEFyZmh5MXBzSkhsUkVE?=
 =?utf-8?B?b0VnUHpyM0FWZkFjQ2VTcXh6NnIvU0NDWnBxaXh4MjFsRHBpb3dMamZjd2lm?=
 =?utf-8?B?dTJKMGZndTAyUXZHWXd2andxNnlvemJsWGh0bzRIZWRhNmcxbHB0MkdpazFU?=
 =?utf-8?B?eGthOEI4U2FTcEl0cFc5RmdZcUpBa1FBTUJuYytSby9kYUxoSXNoWXdZdEc4?=
 =?utf-8?B?UnRDd2NuNUFsWmtqdWNGS3BlQkpoVnJUME9xSzZpZTZ1QjlsWCtSWGhScFpM?=
 =?utf-8?B?SkJvdkFXd0xkMDVXblc1MUlxWmRLZlREaWQ4ZFU2TU5aemFITTc3T29IRUZT?=
 =?utf-8?B?eWdnYlM0UnMzSkJvUW5ueGNzM0hNRDI4cDVTbkQ0WU1qNlc2cDA1MlZmY3U3?=
 =?utf-8?B?N2JBV0N1RDRGbW8vdnlxTE5NVlJkenp0c3Q3WFdPbEhKWnZiS1hpRERhbkxr?=
 =?utf-8?B?SG5JR3J3aWxQSEVMNnRpK1pDbTV6WVBpczl1em9GZHFHdVRQZmVHNXRVWDJG?=
 =?utf-8?B?dDdRbmhiTGFsNjJjTlczTitUdU9obUhGb1VVNXFTYkVuZEM2cXIvQy82UGw1?=
 =?utf-8?B?ZVcreFl2VkZlOVk0YUhzTHRkbUJiSmdvVGtjbWxLbi8wdmZzRS9zRngralJY?=
 =?utf-8?B?MS9mbFF6VlFGak94R1pwTUJveFIrMXdjV2g1eGYzTWY1bFU2RVl1L1h3d0Q2?=
 =?utf-8?Q?ZMFtHA2eDLTnRrSm5a4bAey/1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9afb9b73-8859-4d98-1498-08daedeb8cb8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 00:35:16.1411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wOES3A905DUsvsiM76BOG4Euom12iOC2awIf4lpoyF/r+p68rkhnzxOlOsDy7WVNfhtjOFfV31W7+kYtdIN49A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6951
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/25/2022 10:34, Perry Yuan wrote:
> The amd-pstate driver supports switching working modes at runtime.
> Users can view and change modes by interacting with the "status" sysfs
> attribute.
> 
> 1) check driver mode:
> $ cat /sys/devices/system/cpu/amd-pstate/status
> 
> 2) switch mode:
> `# echo "passive" | sudo tee /sys/devices/system/cpu/amd-pstate/status`
> or
> `# echo "active" | sudo tee /sys/devices/system/cpu/amd-pstate/status`
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 29 +++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 62744dae3c5f..5f6379475b32 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -339,6 +339,35 @@ processor must provide at least nominal performance requested and go higher if c
>   operating conditions allow.
>   
>   
> +User Space Interface in ``sysfs``
> +=================================
> +
> +Global Attributes
> +-----------------
> +
> +``amd-pstate`` exposes several global attributes (files) in ``sysfs`` to
> +control its functionality at the system level.  They are located in the
> +``/sys/devices/system/cpu/amd-pstate/`` directory and affect all CPUs.
> +
> +``status``
> +	Operation mode of the driver: "active", "passive" or "disable".
> +
> +	"active"
> +		The driver is functional and in the ``active mode``
> +
> +	"passive"
> +		The driver is functional and in the ``passive mode``
> +
> +	"disable"
> +		The driver is unregistered and not functional now.
> +
> +        This attribute can be written to in order to change the driver's
> +        operation mode or to unregister it.  The string written to it must be
> +        one of the possible values of it and, if successful, writing one of
> +        these values to the sysfs file will cause the driver to cause the driver

"will cause the driver to cause the driver to"?

Presumably you mean just "will cause the driver to"

With that fixed:

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> +        to switch over to the operation mode represented by that string - or to be
> +        unregistered in the "disable" case.
> +
>   ``cpupower`` tool support for ``amd-pstate``
>   ===============================================
>