Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7f2de22-811c-1df3-eafa-a6a1f4b85a99@amd.com>
Date:   Tue, 3 Jan 2023 18:32:45 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v9 05/13] cpufreq: amd-pstate: optimize driver working
 mode selection in amd_pstate_param()
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, wyes.karny@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221225163442.2205660-1-perry.yuan@amd.com>
 <20221225163442.2205660-6-perry.yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221225163442.2205660-6-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVF6K0I3WHhWdXVRbHBieDhOU1pVa0I4ZGdOWDMrSmtPVnNaa2N0eDdseTFH?=
 =?utf-8?B?UDJRODJzbVZaN0M5Sm5DcXN6OE9RNkJlZDU3cWltdzZaNmpLR2h1QWNsVXdw?=
 =?utf-8?B?SkF5eFF2SHcrK1FqNHhZZyt5aVpPNjhtZjFjbi9tYTlwTWp3ZFZETEtSOXNT?=
 =?utf-8?B?Y2FVNWpkcjd1VDRqeUh2NXJlRnp1b0FWakVLWWhrNTdHNXRsc29pU2liYkM3?=
 =?utf-8?B?K1l3ajFEM203cjlIZWV3M29nQllheVhMdGFJNlozUmlTNWhNMVNxaDFuMnFL?=
 =?utf-8?B?QTVZTmhuQmhGREJqakVmNXdTVmYyWHlIMmJ0L0Mzam5EUTY3YWk0SkZhWEpT?=
 =?utf-8?B?MHQrOE9pQkpUdVBzYkIzUjVrSkQ4V3NMSFZucDNzS2toamVlYXVXNVY3bEhj?=
 =?utf-8?B?b3VRVVRDeG5WS0dJbjFLcU95YnJxR1laaWRuVFA1bVJ0ZmFHY2Q4Vm9tMXFp?=
 =?utf-8?B?RCtqT0dDYy96NE9EOWpFK1dHeERpY0V5R3BGTjdTcG9zRHlCTVlHQ2ZERUVZ?=
 =?utf-8?B?UGlRVndGcTE2RHN2NGJHWk4vNHVxZ1Nkby92UXIzS0lJbklVK0pQRjdYQjJz?=
 =?utf-8?B?WE4vZDhoNlJiMDJtZVdiSHRqbHhjemdQbHJiaHlUK1J3MVAwQWdRVTdma3FY?=
 =?utf-8?B?SUFza2pwQlBFck5rWGx2alQ2cjdLQWQvYjRjc1c1eDlyTkZOeC9iUWFaN2Na?=
 =?utf-8?B?cG51ZVlyczY2TStGSEFYR2dNOWlnL2t4dWZkb1o1SmhFRHg2SGgxMG9zWlZw?=
 =?utf-8?B?cHJQVGpnbUFHdXUremJZZGluL2I5TTV2S1VrWStIanR1TTZLM1FsclNRVGNH?=
 =?utf-8?B?T1VBblR4elY0QlJyMVZTQ04xUU1KK1FJUHVGQ1R5UGU2V3hpdzR5ZDhuQ0NZ?=
 =?utf-8?B?VzVaTjRyM3o2eklvMnU5YTBMb291S3FDYmoxLy8wcktMclh5NkJ1bUVqaUlI?=
 =?utf-8?B?bVltUyt3TFdyUElvMEduenFERDBjc005M3ZhY2pZWlR2Q05yZlhqeUxIRzFF?=
 =?utf-8?B?U1Jzb0U3ODhjZnpTWWpNSmpvOE9qRXJoZThBM1hTbkQ5RStsa2UwclQzWTdX?=
 =?utf-8?B?M21HSUFxVmJUL0JjTjJKU0xJMjk5ZU1vRGwvckdxRVh4TzNmYW5PNlhkMmox?=
 =?utf-8?B?NDVBcnUyTFhBMjI4OU1mK1ViVUI0VWJOZEIzZER0V09DekVwNHRYazRQN01w?=
 =?utf-8?B?UnA2eUpPY2M3dnY5YUY4UmdnN1FPd3Q1T3JYZHh5TzNPTkFSazh0VlVId2Zp?=
 =?utf-8?B?akJJTk9EdDUzQ0doQ0Z4ZTViZnA3dTVHNnVjQU9LeVZxZTBaQTZaQUdwUzRr?=
 =?utf-8?B?cFdXNHE5Y051Vm5tOFQ0ZlcrVkJrbDhubjE4ZFhkYmo2TzZVbUhLM3BNSFVT?=
 =?utf-8?B?ajlqOFFabzNRVEkvTnZNbDE1UWtsdU81REFBTUZzdGdLb0lrZktiTGhBanN4?=
 =?utf-8?B?MW8yQVQxcUJic1puMkNKRDNrb3pYK2tkMzJPWTdnaDZqSHpNeCt2WjBkVk4w?=
 =?utf-8?B?dGhXb1l2elY3djlSem0xWWhUelhPb3JnSWxyNWh5N1RmbksrbFY1TXZXTGth?=
 =?utf-8?B?bWdZYytDSFRISnNpZzR5aEhOQjNHdFljQzBybnRBN0ljSlpNaGtxS01tREFn?=
 =?utf-8?B?MUNwSlhrTmZ3Y1phYUdWWWhaOWtiYksyc3EzZUQzU3RZenZBdE1nbGplRHpt?=
 =?utf-8?B?TWZRa1ZtRzBQT3hBMDNxT3MvVmt5aXlyQVJ0YmQzTi9HODkreTg1akxodFhV?=
 =?utf-8?B?VlhwZnFFdTN6Rk1CVzV6ai9QSTN3amk3YlJUWHlhbjZQcEVEN1pNR0xsdTZj?=
 =?utf-8?B?R3NmY2UzdGZMalZKNlpQbHJJY1JmSHl0VXd4ajRZajZJYThnbzZmUTV0R3FM?=
 =?utf-8?B?OWZ2V3l6eFFYMzJnaEpuTzRPRE9FSThxOUNWOWwxN0IvYVJqL1kyb3FXd2pF?=
 =?utf-8?B?cGQ5b1o5NXZCaFQyQzZFKzI1OGliSTFHK3VNbXQyVE9YSDVCTWZVTGdYM1k1?=
 =?utf-8?B?YW5HYzJUeVdlNDJMaUlnV2RCZzRTaVU5cFdhcUY4VVovbERuUitpZlNIbGht?=
 =?utf-8?B?S2pGZisyeEFqRm84TDZURlFDdURtRjRYM3hIMFRNeUZsMHJsZjRzN0x4UWFx?=
 =?utf-8?Q?idFza72fByXi7fteQUc/BeHD0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73567933-8c95-441e-1d45-08daedeb342b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 00:32:47.5622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wdHlE/UxvJo2SVaWZ5oKYaE+IDs8ABIKJCifTYuKBFWq+aBFSmgLRwRrspR3KjaMijYEg0V+IIinekg4whCKIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4358
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/25/2022 10:34, Perry Yuan wrote:
> From: Wyes Karny <wyes.karny@amd.com>
> 
> The amd-pstate driver may support multiple working modes.
> Introduce a variable to keep track of which mode is currently enabled.
> Here we use cppc_state var to indicate which mode is enabled.
> This change will help to simplify the the amd_pstate_param() to choose
> which mode used for the following driver registration.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 39 +++++++++++++++++++++++++++---------
>   include/linux/amd-pstate.h   | 17 ++++++++++++++++
>   2 files changed, 46 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index c17bd845f5fc..65c16edbbb20 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -60,7 +60,18 @@
>    * module parameter to be able to enable it manually for debugging.
>    */
>   static struct cpufreq_driver amd_pstate_driver;
> -static int cppc_load __initdata;
> +static int cppc_state = AMD_PSTATE_DISABLE;
> +
> +static inline int get_mode_idx_from_str(const char *str, size_t size)
> +{
> +	int i;
> +
> +	for (i=0; i < AMD_PSTATE_MAX; i++) {
> +		if (!strncmp(str, amd_pstate_mode_string[i], size))
> +			return i;
> +	}
> +	return -EINVAL;
> +}
>   
>   static inline int pstate_enable(bool enable)
>   {
> @@ -626,10 +637,10 @@ static int __init amd_pstate_init(void)
>   	/*
>   	 * by default the pstate driver is disabled to load
>   	 * enable the amd_pstate passive mode driver explicitly
> -	 * with amd_pstate=passive in kernel command line
> +	 * with amd_pstate=passive or other modes in kernel command line
>   	 */
> -	if (!cppc_load) {
> -		pr_debug("driver load is disabled, boot with amd_pstate=passive to enable this\n");
> +	if (cppc_state == AMD_PSTATE_DISABLE) {
> +		pr_debug("driver load is disabled, boot with specific mode to enable this\n");
>   		return -ENODEV;
>   	}
>   
> @@ -671,16 +682,24 @@ device_initcall(amd_pstate_init);
>   
>   static int __init amd_pstate_param(char *str)
>   {
> +	size_t size;
> +	int mode_idx;
> +
>   	if (!str)
>   		return -EINVAL;
>   
> -	if (!strcmp(str, "disable")) {
> -		cppc_load = 0;
> -		pr_info("driver is explicitly disabled\n");
> -	} else if (!strcmp(str, "passive"))
> -		cppc_load = 1;
> +	size = strlen(str);
> +	mode_idx = get_mode_idx_from_str(str, size);
>   
> -	return 0;
> +	if (mode_idx >= AMD_PSTATE_DISABLE && mode_idx < AMD_PSTATE_MAX) {
> +		cppc_state = mode_idx;
> +		if (cppc_state == AMD_PSTATE_DISABLE)
> +			pr_info("driver is explicitly disabled\n");
> +
> +		return 0;
> +	}
> +
> +	return -EINVAL;
>   }
>   early_param("amd_pstate", amd_pstate_param);
>   
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index 1c4b8659f171..dae2ce0f6735 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -74,4 +74,21 @@ struct amd_cpudata {
>   	bool	boost_supported;
>   };
>   
> +/*
> + * enum amd_pstate_mode - driver working mode of amd pstate
> + */
> +enum amd_pstate_mode {
> +	AMD_PSTATE_DISABLE = 0,
> +	AMD_PSTATE_PASSIVE,
> +	AMD_PSTATE_ACTIVE,
> +	AMD_PSTATE_MAX,
> +};
> +
> +static const char * const amd_pstate_mode_string[] = {
> +	[AMD_PSTATE_DISABLE]     = "disable",
> +	[AMD_PSTATE_PASSIVE]     = "passive",
> +	[AMD_PSTATE_ACTIVE]      = "active",
> +	NULL,
> +};
> +
>   #endif /* _LINUX_AMD_PSTATE_H */