Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Wed, 04 Jan 2023 06:57:14 +0100
From:   clement.leger@bootlin.com
To:     Lizhi Hou <lizhi.hou@amd.com>
Cc:     linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh@kernel.org,
        frowand.list@gmail.com, helgaas@kernel.org, max.zhen@amd.com,
        sonal.santan@amd.com, larry.liu@amd.com, brian.xu@amd.com,
        stefano.stabellini@xilinx.com, trix@redhat.com,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Allan.Nielsen@microchip.com, Horatiu.Vultur@microchip.com,
        Steen.Hegelund@microchip.com
Subject: Re: [PATCH V5 2/3] PCI: Create device tree node for selected devices
In-Reply-To: <bee02801-c3a4-4717-61a0-290494a097bc@amd.com>
References: <1671125446-57584-1-git-send-email-lizhi.hou@amd.com>
 <1671125446-57584-3-git-send-email-lizhi.hou@amd.com>
 <20230103154811.63e71494@fixe.home>
 <bee02801-c3a4-4717-61a0-290494a097bc@amd.com>
Message-ID: <7eb33924fc380669893571747b999660@bootlin.com>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 2023-01-04 01:31, Lizhi Hou a écrit :
> On 1/3/23 06:48, Clément Léger wrote:
>> Le Thu, 15 Dec 2022 09:30:45 -0800,
>> Lizhi Hou <lizhi.hou@amd.com> a écrit :
>> 
>>> +
>>> +static int of_pci_prop_address_cells(struct pci_dev *pdev,
>>> +				     struct of_changeset *ocs,
>>> +				     struct device_node *np)
>>> +{
>>> +	return of_changeset_add_prop_u32(ocs, np, "#address_cells",
>>> +					 OF_PCI_ADDRESS_CELLS);
>>> +}
>> Hi Lizhi,
>> 
>> This should be #address-cells and not #address_cells.
>> 
>>> +
>>> +static int of_pci_prop_size_cells(struct pci_dev *pdev,
>>> +				  struct of_changeset *ocs,
>>> +				  struct device_node *np)
>>> +{
>>> +	return of_changeset_add_prop_u32(ocs, np, "#size_cells",
>>> +					 OF_PCI_SIZE_CELLS);
>>> +}
>> Ditto here, this should be #size-cells and not #size_cells. Was this
>> really tested ?
> 
> I will fix this.  I verified the properties are generated and did not
> notice the '_' error.

Hi Lizhi,

The most important thing to test is if a driver can correctly retrieve 
resource
of the device using a node added below the created PCI device node. This 
is
resolved using the whole hierarchy ranges, address-cells and size-cells 
properties.

If not correctly set, this will fail (and it fails).

Clément

> 
> 
> Thanks,
> 
> Lizhi
> 
>> 
>> Thanks,
>>