Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <daaf8c33-a981-25c5-2b23-38c59fd20ae2@siemens.com>
Date:   Wed, 4 Jan 2023 08:41:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC PATCH 20/25] kvx: gdb: add kvx related gdb helpers
Content-Language: en-US
To:     Yann Sionneau <ysionneau@kalray.eu>
Cc:     Kieran Bingham <kbingham@kernel.org>, linux-kernel@vger.kernel.org,
        Clement Leger <clement.leger@bootlin.com>,
        Guillaume Thouvenin <gthouvenin@kalray.eu>,
        Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
References: <20230103164359.24347-1-ysionneau@kalray.eu>
 <20230103164359.24347-21-ysionneau@kalray.eu>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <20230103164359.24347-21-ysionneau@kalray.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1dvYXlXdElUdFRlMzEyRm5OcGdQc0ExNjkvUTRJWGFsd0VWcThZRFA5Q3FJ?=
 =?utf-8?B?dHBIVFpENXNDUnF5OGNLNkFoNGdXOW8vOWJoMTVRY09wZ0RZbWl2dHhNaTlE?=
 =?utf-8?B?cEo2cXBIcWtoNGliRFdkK1VtOWlOZG9tcitKRzEvNDBlMXBwYVRUNW9DREtq?=
 =?utf-8?B?ZVRqVnEwZHIyYUhoRmliTW1JdkdnSktCcGw3Q2ZIOHhRdlc3VVZrbDR1MS9R?=
 =?utf-8?B?UUQ2VFJBS05kek0wMDFwWnAvaS9OREFSVVNGL29VUjhITlhKV3NJMGdodmVF?=
 =?utf-8?B?aEluKzdnL1YwMG9zeUlLc3BDSXRBRTJIWWJzSktwbllpVnRiRysyeFJwR0x2?=
 =?utf-8?B?eEhKT2dEUnY1QjlRYUNtYXFLMEdob1hwV2hia0FtQWVJOEIwTFVjUzV2aTJJ?=
 =?utf-8?B?Ny9YendqTmhpVkFhaUJOVDBpckozbU1lMFVBTlNNQVRQaGl3TWtldkpxdXZz?=
 =?utf-8?B?dHRyNlJhOWxpN3AyaWFibkxPY0U0SjNzdkQ3TjlqSXlwT1NTdkNwbXJ3S2Yr?=
 =?utf-8?B?Z1ovZUEzUWZHa2NNSmQ1Y0REazUycDl5dExmTWdFa3UvaHl5OUovSHlMcXA1?=
 =?utf-8?B?TVZaSWo1S0M1b1RaOTJEWDMyMDdvTkdndXMxdEVONWovR2dWMDUrYmV3aXJp?=
 =?utf-8?B?S0lzYmc4cmpVeS9UWENhTzFGcjZNZm9lWDRrQVl4d0hoY1lEVENWYkRocDJp?=
 =?utf-8?B?THkybDhtTzIvLys4RW50N0RvTVArbTBQaEhUWDNFRHBsbzFNa201SkJ6bFNG?=
 =?utf-8?B?Y0tLb2Nma2RWQ1pzUkNXbVA0a2JGUjArc2ZMTkV5Qis1SkNEQ3hncUowNDNr?=
 =?utf-8?B?ZSsveDl0TU93STlZb1NlRE43ZFlGcWo0Q08rTmwraHFMSlFpK0g0VTErak4y?=
 =?utf-8?B?OTV2SnQrV01FTDhYakVwQnBySmRma3ZZbFVJWm05RVY5ZjliQzU1Z1FtbUZE?=
 =?utf-8?B?YU1OVFQ0djEzKy82c1RZNU1aSFVuSk5yRDZDMWM3RmpPUmtKRTFaQUYxeG9X?=
 =?utf-8?B?em1iWGVBMXRTdERMaW03aWRQOVM2UVkvcUtYS2FmSHhBNktlYnR0N080UEp6?=
 =?utf-8?B?SkR5ZGFab1ExbXpPaFQ2RmhrbXFIUTFJWEVLcGdIdHdnTDFJTDBMTWNXWE1H?=
 =?utf-8?B?cjRLcndiY20wRDIvSWF4end1elpLbkt3bkV3ditUZ0N5ai84ZHpOWHcwejdD?=
 =?utf-8?B?RVhUSjZON0hjRDNYRVR0dlpNeG9wUURvbVAvNHNUcEZkMWk2V0djZVFCUzBC?=
 =?utf-8?B?MHlrZFBHZnRGdWcyK25oMUJ6eDJlaDA1QVZNaiswMkFZNkZ3N3BvU213M2Uv?=
 =?utf-8?B?UWIxc0RnWHJaTHhCWUY3b3VJaGF2SkVjSEZGSEtaR0QyVExRT0dkZHJjL0Nx?=
 =?utf-8?B?UnNTRC9QZUdWcnhTM1BHWDRIelFmS1VTYVpvOFVETlpJbG5iUVFEczZZdi82?=
 =?utf-8?B?STN6N2k1cC9DQ2h1YjViRGJSYXB1UjFDbXpFUWh6U0orOFcySGxHWit4RTVL?=
 =?utf-8?B?aW9JbmtycW1VYjd2ZEJja3pQSHZMOGgrVGMwUVNiQlBTSFU5U3BucUpmOFl2?=
 =?utf-8?B?ak5kRUdvaTB5VTNaN1dtSUhyYVR4WUJKdzMzbDM3K2R3cTZKeHZBZjl3eHAy?=
 =?utf-8?B?UXpEOE15cEVuS3VaUStjNmtENS9qaUVYWmpHdDlMam5saldXSmpsVmR4ekFG?=
 =?utf-8?B?T1pCWU1IeXNIRk5QQU1vekJWbnZIYWpYNkpDODZLR3FvbmcxYzVpSDlWR3pK?=
 =?utf-8?B?Z0MvSXFnVURWeUNHMHNlQmdNK1BxVkpJUXdZSzVzdWVBbnpKKyt5NFhCS0hG?=
 =?utf-8?B?enJLc254TEk2NGlQNHg1Wk11RTVidEYvcHBUalIrM1VFY3R0SkpNQXJSMlNT?=
 =?utf-8?B?OWI0ZC9nVE45c0ttUkFVSjBFZm02TUd5d0xRWGdoNFVlLytuelNPU3VQa0dw?=
 =?utf-8?B?b21IZ2ZpOTdpTTVZcjROQnV4T3U2eWo4ZXExZGUxMHVnN1FFYlhqQjFkeG5w?=
 =?utf-8?B?c0JwU0FuYXFzUkJFeGh5Y1hTSzFLcWVWSDlGUzNzNVRhamNlQkdVZzE4UTc5?=
 =?utf-8?B?SnFlS0xWQUdzdWZPWWt4czMzbWNySjBmbkhTNmgzeXA1OUlWWkhaQ3lhdldO?=
 =?utf-8?B?QTM5S1g3d3lsUGNuL1RGM0Z3NWJhWnNLbUw5WE1sY0FkdnFta2MxS2N3UlNW?=
 =?utf-8?B?Wnc9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d91c9376-595a-44ca-65c4-08daee270e0b
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 07:41:13.4671
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nk5Mi5f1Zdx5SEcMX75ZgDJIJanNIYGnSrgDZ6SoBOKPabmZk+exTym4TwnQR6LEQNvvi+OSoJvSLWS46V+PbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3321
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03.01.23 17:43, Yann Sionneau wrote:
> Add kvx related gdb helpers:
> * lx-kvx-tlb-access
> * lx-kvx-tlb-decode
> * lx-kvx-page-table-walk
> * lx-kvx-virt-to-phys

Dmitrii just proposed translate-vm [1], just x86-only so far. Would be
good to use that scheme, maybe even watch out for chances to factor out
arch-independent logic if there is any.

In general, it would be good to define helpers that can be implemented
by other archs as well and stay away from "lx-<my-special-arch>-*"
unless there is really something valuable to add that only makes sense
for that arch.

Jan

[1]
https://lore.kernel.org/lkml/20230102171014.31408-1-dmitrii.bundin.a@gmail.com/

-- 
Siemens AG, Technology
Competence Center Embedded Linux