Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
To:     "liaochang (A)" <liaochang1@huawei.com>,
        Chen Guokai <chenguokai17@mails.ucas.ac.cn>,
        paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, rostedt@goodmis.org, mingo@redhat.com,
        sfr@canb.auug.org.au
Cc:     linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/9] riscv/kprobe: Prepare the skeleton to prepare
 optimized kprobe
In-Reply-To: <9dacbd7a-6dc5-099c-d427-b20bfa22aabd@huawei.com>
References: <20221224114315.850130-1-chenguokai17@mails.ucas.ac.cn>
 <20221224114315.850130-4-chenguokai17@mails.ucas.ac.cn>
 <87v8lovmoa.fsf@all.your.base.are.belong.to.us>
 <9dacbd7a-6dc5-099c-d427-b20bfa22aabd@huawei.com>
Date:   Wed, 04 Jan 2023 09:54:28 +0100
Message-ID: <875ydmsmrf.fsf@all.your.base.are.belong.to.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

"liaochang (A)" <liaochang1@huawei.com> writes:

>>> +	 */
>>> +	rel =3D (unsigned long)slot - (unsigned long)orig->addr;
>>> +	if (!in_auipc_jalr_range(rel)) {
>>> +		/*
>>> +		 * Different from x86, we free code buf directly instead
>>> of
>>=20
>> Reword for readers that are not familiar with x86.
>
> OK, BTW, i think the code following tag on_error is fairly self-explanato=
ty,
> perhaps this comment is no need anymore.

Fair enough! :-)


Bj=C3=B6rn