Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c6a02499-457d-6616-9ede-4f2d89bfce3f@huawei.com>
Date:   Wed, 4 Jan 2023 16:35:31 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v5 9/9] riscv/kprobe: Search free registers from unused
 caller-saved ones
To:     =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Chen Guokai <chenguokai17@mails.ucas.ac.cn>,
        <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <rostedt@goodmis.org>, <mingo@redhat.com>,
        <sfr@canb.auug.org.au>
CC:     <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20221224114315.850130-1-chenguokai17@mails.ucas.ac.cn>
 <20221224114315.850130-10-chenguokai17@mails.ucas.ac.cn>
 <87pmbwvmmr.fsf@all.your.base.are.belong.to.us>
From:   "liaochang (A)" <liaochang1@huawei.com>
In-Reply-To: <87pmbwvmmr.fsf@all.your.base.are.belong.to.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/1/3 2:04, Björn Töpel 写道:
> Chen Guokai <chenguokai17@mails.ucas.ac.cn> writes:
> 
>> diff --git a/arch/riscv/kernel/probes/opt.c b/arch/riscv/kernel/probes/opt.c
>> index 1c0e9d218f6f..884e77d2df4c 100644
>> --- a/arch/riscv/kernel/probes/opt.c
>> +++ b/arch/riscv/kernel/probes/opt.c
>> @@ -12,6 +12,7 @@
>>  #include <asm/kprobes.h>
>>  #include <asm/patch.h>
>>  #include <asm/asm-offsets.h>
>> +#include <linux/extable.h>
>>  
>>  #include "simulate-insn.h"
>>  #include "decode-insn.h"
>> @@ -130,7 +131,7 @@ static void prepare_detour_buffer(kprobe_opcode_t *code, kprobe_opcode_t *slot,
>>   * as a destination register before any branch or jump instruction.
>>   */
>>  static void find_register(unsigned long start, unsigned long end,
>> -			       unsigned long *write, unsigned long *read)
>> +			  unsigned long *write, unsigned long *read)
> 
> Probably a patch messup; This makes the series no apply fully.

Not sure, i will apply this patch to latest kernel(Linux 6.2-rc2)

> 
> 
> Björn

-- 
BR,
Liao, Chang