Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <f64778a4683b16a73bba72576f73bf4a2b45a82f.1672794398.git.andreyknvl@google.com>
In-Reply-To: <f64778a4683b16a73bba72576f73bf4a2b45a82f.1672794398.git.andreyknvl@google.com>
From:   Marco Elver <elver@google.com>
Date:   Wed, 4 Jan 2023 09:52:42 +0100
Message-ID: <CANpmjNMBHQxYd4R+s3gsyKrp+OpZLiyVCsKK2TBLzMHGv4urBw@mail.gmail.com>
Subject: Re: [PATCH] kasan: mark kasan_kunit_executing as static
To:     andrey.konovalov@linux.dev
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        kasan-dev@googlegroups.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrey Konovalov <andreyknvl@google.com>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 4 Jan 2023 at 02:09, <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> Mark kasan_kunit_executing as static, as it is only used within
> mm/kasan/report.c.
>
> Fixes: c8c7016f50c8 ("kasan: fail non-kasan KUnit tests on KASAN reports")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

Reviewed-by: Marco Elver <elver@google.com>

> ---
>  mm/kasan/report.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index 1d02757e90a3..22598b20c7b7 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(kasan_restore_multi_shot);
>   * Whether the KASAN KUnit test suite is currently being executed.
>   * Updated in kasan_test.c.
>   */
> -bool kasan_kunit_executing;
> +static bool kasan_kunit_executing;
>
>  void kasan_kunit_test_suite_start(void)
>  {
> --
> 2.25.1
>