Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d272122f-8459-075e-f2b5-476b2ddf7405@suse.com>
Date:   Wed, 4 Jan 2023 09:31:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>, jgross@suse.com
References: <20221227082115.59000-1-jiapeng.chong@linux.alibaba.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221227082115.59000-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amwxeTIrYkJvNUdRVU10MXYvLzk4WWhidndVc2g5S0h1bnNRclVaRXpTTTRj?=
 =?utf-8?B?MTl5ZHJ0a3BwWkpxREZqc2dzSWpYaDZYM1NzSThDSFYzQ3p0MUNRZnFFdjl3?=
 =?utf-8?B?ckNISkZ3QVVjRFdWODZ0K2pxSUhPVitGYnllZEFJZFc3eis1RHl5dGJxdEtJ?=
 =?utf-8?B?NS9EUlhuNTF1cWg0WWxyaWRjMTluTmpPVEV1eDk3L2NiTG9pQU40S0VmQllk?=
 =?utf-8?B?aFRrb0NQcjFOR1I1OS9qNHMrMmJ1VTcvWmFJcy9YVGhwV0ZKeTdNUzFrSkJT?=
 =?utf-8?B?WkdlaGZBS0twN0p0M3I5QWs1QXp4dElWMjZ1Rm12Qkgxak5EWjdGQzNDZkln?=
 =?utf-8?B?QmYzTmplVUdFWDdPaERyWDVzNm9XUmI3TEJtUDhNSkpMM0NiYnZBU1RKY2dG?=
 =?utf-8?B?Unc3OE5TZ0gyazJzZXJpZVR3UjFHWjNUQUtuL1czbnNPcUhtbkRxd3FoQWc4?=
 =?utf-8?B?N3pyMGQrditOZzAxcU5CbnV6aXU2b01DaUVzQTkwVzJwektNU1ZZUldTS1Yz?=
 =?utf-8?B?UXJwNDZRamkycEhNaXBVQml6Q2xLZ0M0bWtyTStIdUZuc1Q1NUEvS0tZWE8x?=
 =?utf-8?B?TTRQYUQ2RFRwNmhXWlJabkk1Vmw2N2FTWExLSlpPRUJUbjdmczlsV05uSHph?=
 =?utf-8?B?Qk9zVk5NU0N0VTh5RnFqWUdFa2F0M3owMzRtcEJVWTlkU2Ruc2RBNzVOZklU?=
 =?utf-8?B?dVBkYW4veitZN0ZtRU1vaUlrcVdXWUI3ckJWeVF4eEZaWUFxbmtiQkNiRzZw?=
 =?utf-8?B?Mi9jdTVtV2VabFdLRGY5OVZQd0ZrVXN1bW5ZRUpXWTVVRWI4aWVUMENFZ2Ir?=
 =?utf-8?B?bFJ1d21oU01BOWR0NC9lMTNSMXlRYkJKRlRQUzdEZnpseHBBWC9NMVRibjFJ?=
 =?utf-8?B?UWZoSVQ0aC84RzcxNVhzR2JjMnJnN0ZJak9ZVzlPVUxnbnUzRmdMajhZdGRq?=
 =?utf-8?B?SUJuRy83YzdVendYZG91bU96RjdUZEFGM2VOUXpPc0cwNSs5bm56cHVjaC92?=
 =?utf-8?B?clh4b25BcEozeGdDOVBsN3JEUkN2azNRazluak5mNDRkNXcrcHp0UitWLzk3?=
 =?utf-8?B?SU1PQXRPL0dVeE5KYjAwUWpORDBBd1lJYmRtajNqMkxLZkJjSzkxaEJVQWl4?=
 =?utf-8?B?Y1QwaGxHblB3dHB0aXNBbzhLOTJjZzRsbThYY2NFUG5KUmY5RTFQaUI0dlJ4?=
 =?utf-8?B?NHZvT0N0c28xSkxFQTJVbFlXYnhDSXhud3prOFJua3dmdU5Rdkx1TnhRemYy?=
 =?utf-8?B?U0ZkZExaL0ZwbXEvQkZZUXpQdVhGYXNqSldSejZDN3JXMXpsVlJDMXl4NXUy?=
 =?utf-8?B?WFJjRWFlVC9WRHYzYTZBQUw3dTkvNjIxQ2x0SnRwNjd0TElidzlCSlFPbDhB?=
 =?utf-8?B?WFoyQ2x5WEREeHhIcFY3bjJ4cm1Ta0xGc3RBeVgyWWgrdXhGVEh4OTdzUmZT?=
 =?utf-8?B?ZXppYlFQcXZZQ0orNklaYXUyTEE1Y0hKRFpIV0M3WjNGOXp5WDlsdGJNdFUy?=
 =?utf-8?B?cU5BRjByd3Q0VE5NTnFmNUFZc01XMWxianJETDZib0xWdEVPTFUrQkRGSTJH?=
 =?utf-8?B?QXVCNkhPRElNK3RuVnFlRmkwMHczelNCcy9aMTh2L0lld2JkeU1PMEZZdVFV?=
 =?utf-8?B?TjdVMGx3K0cyL2lDSjJoc1EvMXdFanJBMXFMSXd1aXh4ZWMvc09HZFFFMERu?=
 =?utf-8?B?bUNRNUFuWlJDdGpkUHJLNWpRVys2aXEzYmdvNXR5TWpjeld3VlBLdEJKUVJ0?=
 =?utf-8?B?aUZtRFdsOHV0NEt2bXpKaTNoUGZ1d3B0bHBzUHNnajlhOHhickNSSEZhV1du?=
 =?utf-8?B?TlV3M0p0ZWI1a3lUVVEzaFkrWElLU3RWdERxNnoweHZlOFE5MHFZU0hOUUIv?=
 =?utf-8?B?akc5MVNRUXlOdG1Fc1BZVFJ2Q1VKRVhORVl3cVIzRkZoOHpYelN0TWVsOEpE?=
 =?utf-8?B?SnlHSkVQU00xUkd6YTEwTWNGWStIcHEzUTJhaWlQQkwxOVFUQ1BRT1d3VEZa?=
 =?utf-8?B?UnM3WFBSTE85SXczWlBnU3Zsb2FSNjNxb0pvRVV2UUgxMzJFcnRZTGRGU0gx?=
 =?utf-8?B?d3hTbTZGSkNlRlU0blpPQU4ydlU0SklxMkVFNTVNUUp1dEg5dHFEU3ByMCtL?=
 =?utf-8?Q?8cvKfQwAD9WGYm62juxevJCia?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd1917cb-0d3f-40d4-4fa3-08daee2e135c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 08:31:28.9100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IBkh0DLcUpcMeaJVX9kUPlG4J1KxVRuuIppJcLnNmBFHVQ4N3k0bx2RaDHbfHEY5b5zPj38orMojAfstZ+Kn5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9184
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27.12.2022 09:21, Jiapeng Chong wrote:
> The function p2m_top_mfn_init is defined in the p2m.c file,
> but not called elsewhere, so remove this unused function.

This and the title are wrong - p2m_top_mfn_init() is used by
xen_build_mfn_list_list().

> arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'.

Whereas this and the actual code change look correct to me.

Jan