Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759919AbXHTNo2 (ORCPT ); Mon, 20 Aug 2007 09:44:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755183AbXHTNoV (ORCPT ); Mon, 20 Aug 2007 09:44:21 -0400 Received: from Mycroft.westnet.com ([216.187.52.7]:35015 "EHLO Mycroft.westnet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbXHTNoU (ORCPT ); Mon, 20 Aug 2007 09:44:20 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18121.39541.790665.686081@stoffel.org> Date: Mon, 20 Aug 2007 09:43:17 -0400 From: "John Stoffel" To: Laurent Vivier Cc: Ingo Molnar , kvm-devel , linux-kernel , virtualization Subject: Re: [PATCH 0/4] Virtual Machine Time Accounting In-Reply-To: <46C99371.7070705@bull.net> References: <46C99371.7070705@bull.net> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 28 Laurent> The aim of these four patches is to introduce Virtual Machine Laurent> time accounting. So what does this buy us? What increased functionality? Laurent> [PATCH 1/4] as recent CPUs introduce a third running state, Laurent> after "user" and "system", we need a new field, "guest", in Laurent> cpustat to store the time used by the CPU to run virtual Laurent> CPU. Modify /proc/stat to display this new field. What happens when you have multiple guests, is this state cummulative? I've glanced over these patches and the #ifdefs are ugly..., esp since the overhead seems to exist even if you don't run any Guest CPUs. Or whatever you're doing here. Please justify this patch more in terms of what it provides and why it's a good thing to have. Thanks, John - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/