Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52ed3964aacb4ae8fc7ff8416cbddb4110902196.camel@gmail.com>
Subject: Re: [PATCH 0/2] of: Fix handling CONFIG_CMDLINE* even without
 /chosen node
From:   Alexander Sverdlin <alexander.sverdlin@gmail.com>
To:     Rob Herring <robh@kernel.org>, Geoff Levand <geoff@infradead.org>,
        Frank Rowand <frowand.list@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 04 Jan 2023 10:48:58 +0100
In-Reply-To: <20230103-dt-cmdline-fix-v1-0-7038e88b18b6@kernel.org>
References: <20230103-dt-cmdline-fix-v1-0-7038e88b18b6@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 
MIME-Version: 1.0
Precedence: bulk

Hi Rob,

thanks for looking into it!

On Tue, 2023-01-03 at 12:00 -0600, Rob Herring wrote:
> Commit a7d550f82b445cf218b47a2c1a9c56e97ecb8c7a (of: fdt: Honor CONFIG_CM=
DLINE*
> even without /chosen node) moved the processing of the kernel built-in co=
mmand
> line (CONFIG_CMDLINE) from the early_init_dt_scan_chosen routine to the
> early_init_dt_scan_nodes routine.
>=20
> The current powerpc startup code does not call into early_init_dt_scan_no=
des, so
> processing of CONFIG_CMDLINE never happens, even if CONFIG_CMDLINE_FORCE=
=3Dy.
> The result is an empty kernel command line, and mounting of the root file=
 system
> then fails with a kernel panic (not syncing: VFS: Unable to mount root fs=
).
>=20
> Let's revert the above commit and redo the missing /chosen node handling=
=20
> within early_init_dt_scan_chosen().
>=20
> Signed-off-by: Rob Herring <robh@kernel.org>

The series looks good to me,
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

--=20
Alexander Sverdlin.