Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 Jan 2023 12:20:08 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sylvain Petinot <sylvain.petinot@foss.st.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: st-vgxy61: Use asm intead of
 asm-generic
Message-ID: <Y7VS2LuKGVQkcyrU@smile.fi.intel.com>
References: <20230103145219.40226-1-andriy.shevchenko@linux.intel.com>
 <b2ad42cb-fe09-73f5-8d7d-ac4f22817bac@foss.st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b2ad42cb-fe09-73f5-8d7d-ac4f22817bac@foss.st.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote:
> On 1/3/23 15:52, Andy Shevchenko wrote:

...

> > -#include <asm-generic/unaligned.h>
> >  #include <linux/clk.h>
> >  #include <linux/delay.h>
> >  #include <linux/gpio/consumer.h>
> > @@ -15,6 +14,9 @@
> >  #include <linux/pm_runtime.h>
> >  #include <linux/regulator/consumer.h>
> >  #include <linux/units.h>
> > +
> > +#include <asm/unaligned.h>

> Any particular reason not to keep the alphabetical sort ?

It's kept in an order in each of the groups of headers.

The main rule here is to go from most generic headers to the particular ones.
asm/* are definitely more particular than linux/* ones.

> >  #include <media/mipi-csi2.h>
> >  #include <media/v4l2-async.h>
> >  #include <media/v4l2-ctrls.h>

-- 
With Best Regards,
Andy Shevchenko