Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13045330rwl; Wed, 4 Jan 2023 02:46:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/q0O5yzLyi81gAU+jQmvEpAAbKAITAqFGbpD1xUxBJPFD6bm6gvTVacGoiRpRwSkLqC3R X-Received: by 2002:a62:18d1:0:b0:580:ea08:527a with SMTP id 200-20020a6218d1000000b00580ea08527amr39609846pfy.30.1672829187295; Wed, 04 Jan 2023 02:46:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672829187; cv=none; d=google.com; s=arc-20160816; b=gxQuC3ecgkyv6VG9JfRv6zHJGQbB4cC1qe36EsabZ6LM2reZDcRrMqOcM8ZprpO4gi KJxDHyExuHafDiufRs9FrVXIft6+FXpJvFCmbAzF7ijRQC1Uy69hRxnOwdl5cCIkS9gI 7W3HelQpZos3QNm2SadzEDCq7VS0trMUUFH0FK2jYvLF6lVJceN2wGSQ0CCd8viBDci4 8Rt1cAA5oSoWc3bAfFxiJsb9FtHU4b9zPCY24DlEPLX557G1m8TF1MJFiyLsrCHYc2es QZwQmBRYhQNWVJVBKoZZY3dR2Qiku8IEfwk9ciKosxOD+jpOwhDuHXLzGHlHSeTstltS d3Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=5gtoEfhVejTP2PSgVm0jnlqHjpeRUn34WQgEHxOBFKo=; b=rtyqYPd7SCAk7zUaExzxT6bbJudys+3lUoFDUGCegGoGKJbRFCSx0moMBQB+JHr47S L2sGpNjEDUHirChx1uod7CMzUYmudBjoD98gYKm/FI5NoUxmjQ1fqsss4RyqrSckyW2y XBnOg9UNw6eKNhmKbeVh34aSw/M2wT1na/4d1i9+7B6GSzWRzBYp2vaj1lpG8L7lVfgH tLjHjJ/vgQb6WB2iIlRMN8VkY1p0mqeWTyduWgpHYpQoNFTsB8KcgNKtW6pkGuBLL4r2 t7rmxJT933ZArIXPUDD26rWqyvZqG5tdIbCHxKjUdFJRA/myX7UWwfws6/KcZnvo2C8W MhVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=ZgQc1aUh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020aa78e4a000000b00575757288e4si32995532pfr.90.2023.01.04.02.46.19; Wed, 04 Jan 2023 02:46:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=ZgQc1aUh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234559AbjADKeV (ORCPT + 59 others); Wed, 4 Jan 2023 05:34:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233932AbjADKeS (ORCPT ); Wed, 4 Jan 2023 05:34:18 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D572295BE for ; Wed, 4 Jan 2023 02:34:15 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Nn5Yr2J42z4xwl; Wed, 4 Jan 2023 21:34:08 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1672828450; bh=5gtoEfhVejTP2PSgVm0jnlqHjpeRUn34WQgEHxOBFKo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZgQc1aUhkiFUlsN1j3jU9HhNE9Mc/f5fex+rJfbq/ViJ/I45I7m1Nawieeq0kUPuy OjSsaoBVGoAxMd+6G6OvQiTizzajnZ77O8cWzKrOkwI3VOy10QtrnSWF9UwqNutxnB mFY+2SYBZVMLvDSw9cUnEP1yVBVEVxpZP0/A2VR5knYFZde6FYruZHJb4N7UqYhGM1 vioLbAL/Zxo8qgC0GL0iQUcy0rPPul6NBBtUQoIPDohhIRMzAquHn/9TOvQ9bRmWaC eAEbZL+nB/MY9veAzSVOI+uppvtT1pJsa2jp3V2S1Q2iBMiTMj4Z6om5vLO9SxRhdg ZI6UueG8lj68w== From: Michael Ellerman To: Ard Biesheuvel , Linus Torvalds Cc: Guenter Roeck , "Jason A. Donenfeld" , Yoshinori Sato , Rich Felker , Arnd Bergmann , Linux Kernel Mailing List , Masahiro Yamada , Palmer Dabbelt , linuxppc-dev Subject: Re: Linux 6.2-rc2 In-Reply-To: References: <20230102225656.GA3532398@roeck-us.net> <20230103014535.GA313835@roeck-us.net> Date: Wed, 04 Jan 2023 21:34:07 +1100 Message-ID: <874jt64mhs.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ard Biesheuvel writes: > On Tue, 3 Jan 2023 at 03:13, Linus Torvalds > wrote: >> >> On Mon, Jan 2, 2023 at 5:45 PM Guenter Roeck wrote: >> > >> > ... and reverting commit 99cb0d917ff indeed fixes the problem. >> >> Hmm. My gut feel is that this just exposes some bug in binutils. ... >> It really shouldn't matter, but here we are, with a build problem with >> some random old binutils on an odd platform.. >> > > AIUI, the way ld.bfd used to combine output sections may also affect > the /DISCARD/ pseudo-section, and so introducing it much earlier > results in these discards to be interpreted in a different order. > > The purpose of this change is to prevent .note.GNU-stack from deciding > the section type of the .notes output section, and so keeping it in > its own section should be sufficient. E.g., > > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -896,7 +896,7 @@ > * Otherwise, the type of .notes section would become PROGBITS > instead of NOTES. > */ > #define NOTES \ > - /DISCARD/ : { *(.note.GNU-stack) } \ > + .note.GNU-stack : { *(.note.GNU-stack) } \ > .notes : AT(ADDR(.notes) - LOAD_OFFSET) { \ > BOUNDED_SECTION_BY(.note.*, _notes) \ > } NOTES_HEADERS \ This also fixes errors seen in the powerpc build with binutils <= 2.35. Tested-by: Michael Ellerman (powerpc) cheers