Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13094396rwl; Wed, 4 Jan 2023 03:32:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXvOmUNbaU8eyTnedO+nNz2C1ubqmKd98Xl7NhLL4SfuCAjUl5ij2XduzJLqFLYnE54oGjyi X-Received: by 2002:a05:6a00:3491:b0:581:5017:f960 with SMTP id cp17-20020a056a00349100b005815017f960mr30355073pfb.29.1672831960141; Wed, 04 Jan 2023 03:32:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672831960; cv=none; d=google.com; s=arc-20160816; b=b8CV5jBilyuyPem9Xmd/aCXBPpTAMGSl7xcW++vzwB1+Ja/YkVe3Qf9t2VakZHYY+z j3BRJw7KV4mV8APTFZ6P81KVlKedFSNOh/kDIxcaXtZAIeU8SozSTjaQxA0/6atJu+4q j+COF9Jpu+Mwf/y/2E8LmzmssD1owJ6KnXNwukLoUmAFyhHYUg3NmECdPgIQE5VyvlcG 9e6D/lPMppGJlYAt4W3M4jRBn84Yvg2eJ6kfaHuCB9rwv4BUq7KmS2TU46VTw5SPYBG5 veZOtRvHwOfJRiZrEnL+5I8cIFFN51Wfspliv6vs3xexPxkcxOfL0nbyC2xehWZM694T V3Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gt2UGH8jLkUt5zHyvSNwzE2WACDDWMicymbRVNiN1mo=; b=biMbzHptXL6r5mVifbUHmWxKiuzJG4q6TnCXPEYHW3z3fIVG/HaSPKJZQYPUJkL7Mb 56E96u8+NVshaY8B/5SrUEBVztKWIrmDBOzi2QGfag4cTe7qXwP1YzpKMzP/9/MQqw1a PPOKDrzOrjIuZO/R+Ib5tB1IvuAha0yVmQ/TfPwEUxSh1aPX2cdWZl3WhuespSOwUc95 GLtPh4xASCVZ7QKevryGNxrwy7cP+PCa2R4iDQmbiPIWkaGhe1kPIMcTBFObqgG+DiUi YcSoNdloOQWz/JHiCLkl2rRTTsgtT08Pq0FWaStK4skH5hMDqpsCoRvJomGlOlyRvkxP hSAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h7-20020a636c07000000b004701c938a86si34151290pgc.517.2023.01.04.03.32.32; Wed, 04 Jan 2023 03:32:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234876AbjADLQE (ORCPT + 57 others); Wed, 4 Jan 2023 06:16:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230423AbjADLQB (ORCPT ); Wed, 4 Jan 2023 06:16:01 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 190DE1A3A0; Wed, 4 Jan 2023 03:16:00 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="302283998" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="302283998" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 03:15:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="779184672" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="779184672" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 04 Jan 2023 03:15:56 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pD1kQ-004HN0-1U; Wed, 04 Jan 2023 13:15:54 +0200 Date: Wed, 4 Jan 2023 13:15:54 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: Hans de Goede , Mauro Carvalho Chehab , Arnd Bergmann , Sakari Ailus , Greg Kroah-Hartman , Andrzej Pietrasiewicz , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency Message-ID: References: <20230104082212.3770415-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104082212.3770415-1-arnd@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2023 at 09:21:36AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The recent conversion missed the Kconfig bit, so it can now > end up in a link error on randconfig builds: > > ld.lld: error: undefined symbol: vb2_vmalloc_memops > >>> referenced by atomisp_fops.c > >>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a Tested-by: Andy Shevchenko > Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2") > Signed-off-by: Arnd Bergmann > --- > drivers/staging/media/atomisp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig > index 2c8d7fdcc5f7..c9bff98e5309 100644 > --- a/drivers/staging/media/atomisp/Kconfig > +++ b/drivers/staging/media/atomisp/Kconfig > @@ -14,7 +14,7 @@ config VIDEO_ATOMISP > depends on VIDEO_DEV && INTEL_ATOMISP > depends on PMIC_OPREGION > select IOSF_MBI > - select VIDEOBUF_VMALLOC > + select VIDEOBUF2_VMALLOC > select VIDEO_V4L2_SUBDEV_API > help > Say Y here if your platform supports Intel Atom SoC > -- > 2.39.0 > -- With Best Regards, Andy Shevchenko