Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13118423rwl; Wed, 4 Jan 2023 03:57:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXvymgtlyLun5iiKMb56FX7avRtKfaBqVhAPPX7teHNF4Dnkj/aub9Om5zCsR6yQuAIpi5CL X-Received: by 2002:a17:906:6d97:b0:7c1:4b17:3323 with SMTP id h23-20020a1709066d9700b007c14b173323mr38833734ejt.7.1672833423092; Wed, 04 Jan 2023 03:57:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672833423; cv=none; d=google.com; s=arc-20160816; b=etxFTMioUZeKJK0xlITD5znGH3fj9Tbxh4rc1xB7+5qXXusn1p5XGh/iHvON/IvtoK 0b+bdVGVKMbgaHIc7gUlSGSmVtXX0LIiRepY7ONb9yt3M/0F91hXVq0yCpf5b2bh9aIQ AVvq9/jaV4Go3mPyStwGwlZo55uuN4XlZek3s74EPmI7rDrRUwqEIy8IthQ4e+jfGPgk Bty/A1OwJ0oCV1BmKGbO4MQrYXjuLbkwQce+h2FrloYI4GAdp9DyoqeXsC3P1j6BuWjy 1W0nhGC7P9MgZZtbNVp2sLyrY8aHjBk0sc8g6dYxOGogCPdp/E8/dVUu2Om7lQ+GRa+S 4+ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aE7pvlKCWpDTZrrurImv+6jDCyoTDELSZk1s0iOQknM=; b=cqaJAufkCxDNTDr5xaFWs9Z2kgTpxXn71o+kr7bC0Lw/G390IaIqDk6ZFenAIy64W6 FaXH8gTfdwHxemdY7/+s3Sz+zgKWwnxSrmyBdb7X1zz8HF7eIxPjGAf0C+bqBtfhws8r loYTLPhp67hWhXFzoxK8C+Cub0LfzSnbU89dSPSSQbldD4KGYhJZA/AZeBhXvN5QKf0G ymET4GI4DVNPd5C+dWJNP4CHlMM74TrvNDPo92r45DDPpaa1gxmyTaA8wim4bmWWiZ2l ESSOCfTotjA1w/Rb7yHJhyRSTtBw9OzndjU/gmiRe68Sg7fuoQxwSn4L1SAuhMccm/M7 sAjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZtdG5nNt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wg1-20020a17090705c100b008327270a7e0si29786071ejb.65.2023.01.04.03.56.49; Wed, 04 Jan 2023 03:57:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZtdG5nNt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234922AbjADLsE (ORCPT + 57 others); Wed, 4 Jan 2023 06:48:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234726AbjADLsB (ORCPT ); Wed, 4 Jan 2023 06:48:01 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D7BB1EAFD; Wed, 4 Jan 2023 03:48:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 94024613EA; Wed, 4 Jan 2023 11:48:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B7DAC433D2; Wed, 4 Jan 2023 11:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672832880; bh=tVKRtnWaZZzqrPq8yrMjFtLHPJFEtdjwVzN5HPz6PNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZtdG5nNtzC4Qg4uKG4pKE1cjLnujfr11dKH4dcnGqbvdi4a63JcgSsCpcIolbLqvp nuE/yaN6zxt8gd27w1S0kdPYXv5sPHMMPawNOCuuIac4nGCNYSOfExWstXfTSfON2y z69JsG2uLaKs2Pz/gbf0p0dzPeFbrO90QW/7BwXgomngxCkpqb8sr77kriK0NYuhrz Bmcpe0tIa5KphOKZV3S/EC/TpQ7joEw0wte8zpgcRZ31HJGk3Tyfk++daz3FuPNHdI DlXszGvUQ/aoOxmjdxUe5qAcqVZqYLdze4wmMs8+P9bn7HcGT+c78ubPaOj+qAistf ksln38PZ5v5nQ== Date: Wed, 4 Jan 2023 13:47:55 +0200 From: Leon Romanovsky To: Jiasheng Jiang Cc: gregory.greenman@intel.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, luciano.coelho@intel.com, johannes.berg@intel.com, shaul.triebitz@intel.com, linux-wireless@vger.kernel.or, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iwlwifi: Add missing check for alloc_ordered_workqueue Message-ID: References: <20230104100059.24987-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104100059.24987-1-jiasheng@iscas.ac.cn> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2023 at 06:00:59PM +0800, Jiasheng Jiang wrote: > Add check for the return value of alloc_ordered_workqueue since it may > return NULL pointer. > > Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers") > Signed-off-by: Jiasheng Jiang > --- > drivers/net/wireless/intel/iwlwifi/dvm/main.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky