Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13176387rwl; Wed, 4 Jan 2023 04:45:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtJCIoz0yV8yI/mJrVOF/mL6kg7qu/eXflfK40bw9LyvR8YtgRm8Ys9c2giKpiPBMX/PTwO X-Received: by 2002:a17:902:9897:b0:192:f500:e831 with SMTP id s23-20020a170902989700b00192f500e831mr679923plp.8.1672836329830; Wed, 04 Jan 2023 04:45:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672836329; cv=none; d=google.com; s=arc-20160816; b=BqDWzFUNKn/s7yKMzUtZs7LqErYWuSm7dqzQPHcaIQg3RvdfSBmREKsRb5ndOOHeuI pYKirFZwTgFNUIeWmDCq/R7fdibbzha6haQRmN1meoSI0ltXXm+ZYQ94+VR5Ev9Oo4IW BmIYpGeFu6RkSo8G/br1tm10JIiidETF8dG9ikhCyPEHJdqNP3G4sdRM48/WxufTaqw3 R4TzVzUwsbUP8OLSbNRQam2dU3A9upsxrskPXY8qAF9V2MJKmFAnqAnveZKWCCINQ3H3 cFztVUCRT9TTuoTmJj4GHYCJ5TnT9Go6GYIqF3l7foDpm7OZOWkEV3pY+XbAvyM45NY7 5CXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:organization:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=ObctR8wmjJsoft8fkB3+PUPDivPuBXv7SEKQSD8I3u4=; b=dpCcYSJ5f5HI/1H1OU1uJPTh9Ib/Y/lpA/E2Ss2qqV95msgVBNUSlnfLBf45fUKP8v weUHsN91fD9MN2StGktlX4Fphy3nHukAgiSGhzOjGNSZF4ik4E/Imhrh4onVVLdACWwI eJCo13LCEmJtH5oYp8VkJKL5CdQD5+/QGbTGbaDuS4e300N/lCz8QrBE/4ndBedg/bug pJt0KDkM9/tEPK6W5uJXF8FmoU9X2Z5X3pVvTzU0FmwYFTEhMgnmGMU8SfbpEGlYkDqP sSQjc68RtqT5XD8gUu4MiP1KM+DjJAlG//uWE3eRItBIpw3pGgIrx3v79dp2FhymAK1h l8Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jkh+gXfO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a170902c64900b00191ffe197bbsi32319367pls.212.2023.01.04.04.45.20; Wed, 04 Jan 2023 04:45:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jkh+gXfO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239146AbjADMfu (ORCPT + 59 others); Wed, 4 Jan 2023 07:35:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239191AbjADMfo (ORCPT ); Wed, 4 Jan 2023 07:35:44 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98ED21AD90; Wed, 4 Jan 2023 04:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672835741; x=1704371741; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=rkt4l1r96Awe0yuVnI/8AUblpAdT+5P6KOwt66+7u6c=; b=jkh+gXfOAF3MwivD5vCCy8STVKUuJpI+1GiEneh487zqJLxwMMZ9XL0I Jku4Hu0mpTtKBaRhTLuIhyJGVUGZdkBkuGgof4s5g4PK1ghSqrhmAoc9+ 5h8BUKJcPMTCrc0eZ3XzSpBGXkTZC1JRZQE21B90yk6R0xxcvOTp+irtA Gsazsu/gciplF3Y1VyoJ6yaPL+Wpvu7yleF2YyPH+jVwXY7ewmyNdle1b LTh/tGUYBFAL3nYzOALqq5eh+gEtoQh6j5j5hx3tKoxvEf8UNTH9P3nio 6MOGIJls+VId6T4QYvvAbtzLggqao8p8r3nw8aSaz651RAy/q0lVkroW2 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="384214959" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="384214959" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 04:35:41 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="779195620" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="779195620" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 04:35:37 -0800 Date: Wed, 4 Jan 2023 14:34:55 +0200 (EET) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Sasha Levin cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Kai Vehmanen , Ricardo Ribalda , Pierre-Louis Bossart , =?ISO-8859-15?Q?P=E9ter_Ujfalusi?= , Ranjani Sridharan , Mark Brown , lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, daniel.baluta@nxp.com, Jaroslav Kysela , tiwai@suse.com, sound-open-firmware@alsa-project.org, Alsa-devel Subject: Re: [PATCH AUTOSEL 6.1 1/7] ASoC: SOF: Revert: "core: unregister clients and machine drivers in .shutdown" In-Reply-To: <20221231200439.1748686-1-sashal@kernel.org> Message-ID: References: <20221231200439.1748686-1-sashal@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, 31 Dec 2022, Sasha Levin wrote: > From: Kai Vehmanen > > [ Upstream commit 44fda61d2bcfb74a942df93959e083a4e8eff75f ] > > The unregister machine drivers call is not safe to do when > kexec is used. Kexec-lite gets blocked with following backtrace: this should be picked together with commit 2aa2a5ead0e ("ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed"), to not bring back old bugs (system failures to enter S5 on shutdown). The revert patch unfortunately fails to mention this dependency. If I'm too late with my reply, I can send the second patch separately to stable. Br, Kai