Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13386471rwl; Wed, 4 Jan 2023 07:31:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXtOvvQjYirDP0nWeJ5X/Lt6UBeLvY+zpRBhYxn17W9tddkgNHW0BnKJPSnUDKKPJQQ/wVLM X-Received: by 2002:a62:6442:0:b0:581:eca5:12a3 with SMTP id y63-20020a626442000000b00581eca512a3mr20807677pfb.10.1672846262016; Wed, 04 Jan 2023 07:31:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672846262; cv=none; d=google.com; s=arc-20160816; b=uHguuvE6HjCVJNxbh83vA7iw/HfYwlDfA0Rn587MVDiqOgG+5xDtZk8FrR3HNL8g7Z 0PAZtvGmqa3wNAOG9R1j6sWSOzzcX+jYgU6jHbWp0w2a1R1Oq85e8Ys8FLb7FvseRaDf p0lokUjLguEIfJG0XKIzyHfqfluCKMcUO+SKR82TvlktFG6Eu5aH0puG/Gx17GXGK+d0 UjaoKMTuIrd2mMLAZAMI/q0h7G9KMJa1ybD95XpPEynnKE+YuTTUsy249hVsVG+nsvLz HT3xFj3kObqZ4MqSWUJ4Jxg5QctFLAFgUYRrzGV27G087BduE+E+rDJlvaUxB8lRABYN 7n6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-id:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=mvmV6y7ip8tXPSrZFnuEWA2aMPLKMsaip/uSNGUfkCs=; b=FdPQ8AMG3YbBc1/hHUspoc+ab+Jtrjha/dR32ubokJV7QJCoW5B904ubWRF+QKxE2n WzgvyC1u8CGnNX5Giq0nZ4ocbfhMnc17aao3v3ssNewaZtqrXqJQbn0xzDyUtsp0mrYP sroosKukLeuI0FYpwOjTkvxi2GW4EFyL1qS81qyIhqYWV2MH+9iqpifEpGeF3No3DCKy Rb54cycchKZZQgPXgO4dreE0bIc6it6MVdOSkIOQQ2o0/bVG+IjnF+QxaACf9qYbhdP6 0lJbjj3YS3PRT4/PLR+SMgLGYR3ajBeg/kURb1aNl7EJrfl4xEc0aIoTdBtPxL9PUbK4 HmBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SEWb8UTY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv4-20020a056a00414400b0056ea2b142b6si12355966pfb.373.2023.01.04.07.30.53; Wed, 04 Jan 2023 07:31:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SEWb8UTY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233514AbjADPOp (ORCPT + 57 others); Wed, 4 Jan 2023 10:14:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231197AbjADPOl (ORCPT ); Wed, 4 Jan 2023 10:14:41 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C6841AD80; Wed, 4 Jan 2023 07:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672845280; x=1704381280; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=QZCwprZw1+mKr5+bFcTpFv2qhvbs1l7/XdAVfCoIPFs=; b=SEWb8UTYJVdEng0I/h37yeXnyehRTINh3OVUjh+Qxi5vCmxykG9KwM0R CYAWGq6L056TrF4xFwYxSLfjsrNPrcOtVqq44HAaXy4KAZWfYW+GMH3YA klR5isnF83F4v16iu9T84tAi/TeqnplFU+OJFifh4M3+E9dDln1WcTsm1 IDFrTHHxWhSNfrCUY31SW3hfVq27lgHbPwGIHFy1hkHujMi4hN/NG6wfN FRNwcfTEwHBPeV2FvXOdCdIablmtkc+BimR4v7xDauyjgw2tyPQEXXj9z LSjgo8UvKJ/qOY3p9iZcyF2CglyRW5sehPohJoTSgFuWiIOj4I5XHuTR9 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="320663935" X-IronPort-AV: E=Sophos;i="5.96,300,1665471600"; d="scan'208";a="320663935" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 07:08:22 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="900578039" X-IronPort-AV: E=Sophos;i="5.96,300,1665471600"; d="scan'208";a="900578039" Received: from msvoboda-mobl.ger.corp.intel.com ([10.252.48.119]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 07:08:19 -0800 Date: Wed, 4 Jan 2023 17:08:10 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: lizhe cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial , LKML Subject: Re: [PATCH v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART In-Reply-To: <20230104150023.3115-1-sensor1010@163.com> Message-ID: <2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com> References: <20230104150023.3115-1-sensor1010@163.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-339339727-1672844700=:1783" Content-ID: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-339339727-1672844700=:1783 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 4 Jan 2023, lizhe wrote: > in linflex_config_port() the member variable type will be > assigned again. see linflex_connfig_port() > > Signed-off-by: lizhe > Acked-by: Jiri Slaby > Acked-by: Ilpo J?rvinen Eh, you're not supposed to invent these Acked-by tags yourself. Don't add any tags besides your own unless somebody explicitly gives them to you in a reply! And the subject was supposed to be (as per Jiri's recommendation): serial: linflexuart: remove redundant uart type assignment You also didn't include the history of what was changed in v3. -- i. --8323329-339339727-1672844700=:1783--