Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730
Mime-Version: 1.0
Message-Id: <7c531595-e987-422b-bcf7-48ad0ba49ce6@app.fastmail.com>
In-Reply-To: <20230103164359.24347-1-ysionneau@kalray.eu>
References: <20230103164359.24347-1-ysionneau@kalray.eu>
Date:   Wed, 04 Jan 2023 16:58:25 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Yann Sionneau" <ysionneau@kalray.eu>
Cc:     "Albert Ou" <aou@eecs.berkeley.edu>,
        "Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Aneesh Kumar" <aneesh.kumar@linux.ibm.com>,
        "Ard Biesheuvel" <ardb@kernel.org>,
        "Arnaldo Carvalho de Melo" <acme@kernel.org>,
        "Boqun Feng" <boqun.feng@gmail.com>, bpf@vger.kernel.org,
        "Christian Brauner" <brauner@kernel.org>,
        devicetree@vger.kernel.org,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Eric Paris" <eparis@redhat.com>, "Ingo Molnar" <mingo@redhat.com>,
        "Jan Kiszka" <jan.kiszka@siemens.com>,
        "Jason Baron" <jbaron@akamai.com>, "Jiri Olsa" <jolsa@kernel.org>,
        "Jonathan Corbet" <corbet@lwn.net>,
        "Josh Poimboeuf" <jpoimboe@kernel.org>,
        "Kees Cook" <keescook@chromium.org>,
        "Kieran Bingham" <kbingham@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Linux-Arch <linux-arch@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-audit@redhat.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-perf-users@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org,
        "Marc Zyngier" <maz@kernel.org>,
        "Mark Rutland" <mark.rutland@arm.com>,
        "Masami Hiramatsu" <mhiramat@kernel.org>,
        "Namhyung Kim" <namhyung@kernel.org>,
        "Nicholas Piggin" <npiggin@gmail.com>,
        "Oleg Nesterov" <oleg@redhat.com>,
        "Palmer Dabbelt" <palmer@dabbelt.com>,
        "Paul Moore" <paul@paul-moore.com>,
        "Paul Walmsley" <paul.walmsley@sifive.com>,
        "Peter Zijlstra" <peterz@infradead.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Sebastian Reichel" <sre@kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Waiman Long" <longman@redhat.com>,
        "Will Deacon" <will@kernel.org>, "Alex Michon" <amichon@kalray.eu>,
        "Ashley Lesdalons" <alesdalons@kalray.eu>,
        "Benjamin Mugnier" <mugnier.benjamin@gmail.com>,
        "Clement Leger" <clement.leger@bootlin.com>,
        "Guillaume Missonnier" <gmissonnier@kalray.eu>,
        "Guillaume Thouvenin" <gthouvenin@kalray.eu>,
        "Jean-Christophe Pince" <jcpince@gmail.com>,
        "Jonathan Borne" <jborne@kalray.eu>,
        "Jules Maselbas" <jmaselbas@kalray.eu>,
        "Julian Vetter" <jvetter@kalray.eu>,
        "Julien Hascoet" <jhascoet@kalray.eu>,
        "Julien Villette" <jvillette@kalray.eu>,
        "Louis Morhet" <lmorhet@kalray.eu>,
        "Luc Michel" <lmichel@kalray.eu>,
        =?UTF-8?Q?Marc_Poulhi=C3=A8s?= <dkm@kataplop.net>,
        "Marius Gligor" <mgligor@kalray.eu>,
        "Samuel Jones" <sjones@kalray.eu>,
        "Thomas Costis" <tcostis@kalray.eu>,
        "Vincent Chardon" <vincent.chardon@elsys-design.com>
Subject: Re: [RFC PATCH 00/25] Upstream kvx Linux port
Content-Type: text/plain
Precedence: bulk

On Tue, Jan 3, 2023, at 17:43, Yann Sionneau wrote:
> This patch series adds support for the kv3-1 CPU architecture of the kvx family
> found in the Coolidge (aka MPPA3-80) SoC of Kalray.
>
> This is an RFC, since kvx support is not yet upstreamed into gcc/binutils,
> therefore this patch series cannot be merged into Linux for now.
>
> The goal is to have preliminary reviews and to fix problems early.
>
> The Kalray VLIW processor family (kvx) has the following features:
> * 32/64 bits execution mode
> * 6-issue VLIW architecture
> * 64 x 64bits general purpose registers
> * SIMD instructions
> * little-endian
> * deep learning co-processor

Thanks for posting these, I had been wondering about the
state of the port. Overall this looks really nice, I can
see that you and the team have looked at other ports
and generally made the right decisions.

I commented on the syscall patch directly, I think it's
important to stop using the deprecated syscalls as soon
as possible to avoid having dependencies in too many
libc binaries. Almost everything else can be changed
easily as you get closer to upstream inclusion.

I did not receive most of the other patches as I'm
not subscribed to all the mainline lists. For future 
submissions, can you add the linux-arch list to Cc for
all patches?

Reading the rest of the series through lore.kernel.org,
most of the comments I have are for improvements that
you may find valuable rather than serious mistakes:

- the {copy_to,copy_from,clear}_user functions are
  well worth optimizing better than the byte-at-a-time
  version you have, even just a C version built around
  your __get_user/__put_user inline asm should help, and
  could be added to lib/usercopy.c.

- The __raw_{read,write}{b,w,l,q} helpers should
  normally be defined as inline asm instead of
  volatile pointer dereferences, I've seen cases where
  the compiler ends up splitting the access or does
  other things you may not want on MMIO areas.

- I would recomment implementing HAVE_ARCH_VMAP_STACK
  as well as IRQ stacks, both of these help to
  avoid data corruption from stack overflow that you
  will eventually run into.

- You use qspinlock as the only available spinlock
  implementation, but only support running on a
  single cluster of 16 cores. It may help to use
  the generic ticket spinlock instead, or leave it
  as a Kconfig option, in particular since you only
  have the emulated xchg16() atomic for qspinlock.

- Your defconfig file enables CONFIG_EMBEDDED, which
  in turn enables CONFIG_EXPERT. This is probably
  not what you want, so better turn off both of these.

- The GENERIC_CALIBRATE_DELAY should not be necessary
  since you have a get_cycles() based delay loop.
  Just set loops_per_jiffy to the correct value based
  on the frequency of the cycle counter, to save
  a little time during boot and get a more accurate
  delay loop.

    Arnd