Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13453855rwl; Wed, 4 Jan 2023 08:21:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXvZVH8a8HsMP7aCY3ccWqJfQLoZ6y5V14ysnCX2udSkwK0URTjwtXAwNxpSJKED5uAQTrv6 X-Received: by 2002:aa7:d953:0:b0:48e:9130:98c9 with SMTP id l19-20020aa7d953000000b0048e913098c9mr7853455eds.3.1672849295936; Wed, 04 Jan 2023 08:21:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672849295; cv=none; d=google.com; s=arc-20160816; b=w4HXBBp0CrYbKHDVKG4V7mlOGrvWt8+C+YgzfYdt9rHhouroFbmnD8EjXqh1m4ozBM mUMgpYaegS768LcgORETh9B3zaE8IkGoS+UDarRmLd83IywP8hfZbD5aeZKjJVJ4D3xl u2mxmzlqTLmTyJVJAWkAr1h0/GQ9df1egIsfT8QmFAHIwktr4KkdmOS+UAd9xPAIiebv JweV/Idf7gNdgutWPW9KiO70geCqqOT0KxG1er2LUhYpT6W6jJbU3uUmiHvFWs4sVfJS 2Re6qTNEIfkCeSCdcpUNgTA3xPr0sXnnSIm9cHqJS9+gL3W/5NmZa4w6PcTevgVHgv50 E1ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=n5TKZ/dgFn3y+QHvzP9toU4+7ai7ta5wHtr+trED+RA=; b=gMEaP03r5/H6uTPPG1/aBB+rVhHrUSO7b260flWLb+fzSqXhAwHPI10nZ/srZvxyyO QoxctQjpedsWhhqN4HmzG+x3Up/ykLQetaq1WUkxhHS9QNumwI+h5voaXIejXS4v9ML3 efPSXbG5ZymVEGQlzyUgB10FepgqZSxp9S95KwCf7zV0YFknax3bfkZYwlN0WwwwWqVE gbSRe87IGP/6Ke6Uvh3LT/0niAqLL17p/PEdchkL0RtcXFc/vh+oe0Pp0rt/G8Hmc00k lmgfHfj/M2URU8u7qnYFZ9qBEXbtRlNsenEBLHwwGQ1jJsrDhOAoRWkiReaJ/kbENPme wb+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RixBqygu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c11-20020a50d64b000000b00459b51c2b25si32897804edj.438.2023.01.04.08.21.21; Wed, 04 Jan 2023 08:21:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RixBqygu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239706AbjADQN0 (ORCPT + 59 others); Wed, 4 Jan 2023 11:13:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239866AbjADQMw (ORCPT ); Wed, 4 Jan 2023 11:12:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3ADDDE4 for ; Wed, 4 Jan 2023 08:12:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A5ACB81732 for ; Wed, 4 Jan 2023 16:12:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8956CC433F1; Wed, 4 Jan 2023 16:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672848769; bh=jsCTJlqLyIy20TAjZal62lzOYgk+2R8QE9cZ0NxVE1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RixBqyguCXakwUI67erIffSiXrZOU+hcW8NF7C1S+11h47KL3HFNFu1/Mmyiwcs1o 74nL4ODYv+ogwfFFEPCcJcjV7gnYLl5u/eayHRSvjTFGEJly/kS5J0ycmr4vX7oy2B VGcmtTeuHZrGyOhVnwyFzZeJduyjpupVgbkq8bON3nhe3X/0UuhdbhZuMMHZcyOnic /J0Yq+YRCvNg6rmAVj2iHgSwsJ+E/xQQaB1e/dip74U6wGCjDG7W1NQHEWjSiiwlEr 3C6wXenjJ9wr6TalMO9Fmxgh82encxzqz0LkyiJKsUnJF1JbnuCglRS0FI3NWoXQPJ KTtAC9V4HjRww== Date: Wed, 4 Jan 2023 16:12:43 +0000 From: Lee Jones To: Qiheng Lin Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: pcf50633-adc: Fix potential memleak in pcf50633_adc_async_read() Message-ID: References: <20221208061555.8776-1-linqiheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221208061555.8776-1-linqiheng@huawei.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Dec 2022, Qiheng Lin wrote: > `req` is allocated in pcf50633_adc_async_read(), but > adc_enqueue_request() could fail to insert the `req` into queue. > We need to check the return value and free it in the case of failure. > > Fixes: 08c3e06a5eb2 ("mfd: PCF50633 adc driver") > Signed-off-by: Qiheng Lin > --- > drivers/mfd/pcf50633-adc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]