Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <21a4f7d7-eec6-f04e-9707-59236c0f937f@intel.com>
Date:   Wed, 4 Jan 2023 08:43:03 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.0
Subject: Re: [RFC PATCH 2/3] x86/resctrl: Move the task's threads to the group
 automatically
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <fenghua.yu@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <corbet@lwn.net>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <eranian@google.com>,
        <peternewman@google.com>
References: <167278351577.34228.12803395505584557101.stgit@bmoger-ubuntu>
 <167278360189.34228.2442698916556329960.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <167278360189.34228.2442698916556329960.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2lFUUJqb2RuNDQ0dXNKRUhWUWFZM2czNXpIY3JZaHBtRnpaUFpTYlJscitG?=
 =?utf-8?B?VlFRbTRMTCt2ckkxQkFxR3RaSnNTamF1WVcwWU5kS3pxT0F1WXhQSGhJaUY1?=
 =?utf-8?B?Q1RwRDVGUlVRUTVTQTJCNVY0SG1ndnB1ZDNyL1BKS0l6T0NvSmF6L2VDOGdD?=
 =?utf-8?B?Zm5xcUlieGZUOWNKanNkaVBGZzZXYkdTUmZIL2lMNGlINEdEZ3BWWStWY3NN?=
 =?utf-8?B?RGN3aU1MSjFwQjBGem1EbE92TnhlVy9aMGo5NU9FakI1alA5RlZPNWJnendO?=
 =?utf-8?B?Z1IrV0d5U3NaOHN2a0U5Q0RCSDFLZUUrTmFRQk9LSXM0c2xUV0txVTM0UUtE?=
 =?utf-8?B?WXorT2Y2K0dqYUFuNWhrbFlMSnFmWFVtUUNBdDI5dmFoQ3NESjZqajMyRGtt?=
 =?utf-8?B?MDlOVS9iSDc2eWQ2T3VHYTQ3M29aeTJZSmFLSmhDQm9kVUZFUXFIeWtlVlVF?=
 =?utf-8?B?WGRMZ3dQaGhqb3M3TE9qL1p2NHpjYXo4L3NBd040d2c4OUl1NWpIVEd6eEZ4?=
 =?utf-8?B?T0x2dTl2QklKeW5EV1BlY2o2VzlUL3lkL0xhWVlFbEppMFJXS0EvWHVGR3A5?=
 =?utf-8?B?dHc4WDVmM0ZMZ0hLNUJHa2ZkK3pjaUFEb2FFSjV0K25PTitPeHg4VnJrczVW?=
 =?utf-8?B?a3F1Nk5LaXV2SjR3Z0UyamgyZ3VuemtPT3JJUjNpUElKQks3WnpWT0htTFNO?=
 =?utf-8?B?eUdxT1VlcDZFclhwNHErU3Z5UWFxMDd6bTBKKzZpc3lrN01Kck9QZXhMVGwr?=
 =?utf-8?B?UlFiNzZpeVl0a3A0MWMrMitNaEcreDU0ZG14bnRnWnZwc0duby9TQXJDS0cv?=
 =?utf-8?B?bTNnNUZlR3l3blQ4UHQ0OExDNFFKcnpDcUZIVkV6L2xkNG5yaHJCVTdkTmRS?=
 =?utf-8?B?QVVwNkg4RTdnamEvUjlMVjVMWk1rZzJ0V3d5djNQbVJFa24wOFlPTlBndjFp?=
 =?utf-8?B?R1lMOVRvQzIrZ01EbkxuY2ZXZzU5OHJQY0d0M0cvUDBmOUdsSU5XQms2RFpo?=
 =?utf-8?B?QlBTODlscFFLV2NCUi9sT2lRREdwbCttL0IySDliMXFXRHd0WW5ZbjByYk5K?=
 =?utf-8?B?Nzd4d0VNS0wxYUxwTGoybXBmY1RwN0tmbEtPL09oUzNZeG1hZE1xY0h1RjBH?=
 =?utf-8?B?WWgwaW5IbnlVRHozOERLYVJJSGJ5cEMyNWZRc0RSNG5FWFRPT1lkbVZ2Slho?=
 =?utf-8?B?a0dkejBrcERkRGFHMTk0VzE5WkdZclc5eGRjaExybE1MTXVVU3NRazdiaDJh?=
 =?utf-8?B?L2pvczFoTEhXVXZxQUU4eEk2R3NEM1YvZVFRdzBROXU1OGN1LzNVVUo1eVRz?=
 =?utf-8?B?RHc0UXNnZFZLb2lZaW9SNDIwZE40Z1NIZCsyTUR2TTBLKzcwNTFHRkNhYzNS?=
 =?utf-8?B?WkZuQWc3ZzhKYy9mTnNZM3dVSXJuajFNaFAvSXJseWt4RFh6ekVuelk2SjhB?=
 =?utf-8?B?MTV4cGlLcW1GYllZSkpkMEo0M2pRNzhPZzF2eXNjSkc3dzVXRVlUTjZvMkxi?=
 =?utf-8?B?azFLNGVXdlp5NXJuanduZlBLZHJaakszWC9xU1VZaDhMZUxwUXhpY2FIMW1V?=
 =?utf-8?B?cVBNVlZBcmZXdjMwblJDSzY4dllwNWlpN0hwN1U5Y29OZllIRVZwOGx3QUxB?=
 =?utf-8?B?RGg2K0RwSmRPQTZ3L3cvQ2FLbFBhVXJoQThlSzNuTEtLeWhxa3pKNlR2cS9j?=
 =?utf-8?B?MTBjODZINFY0cko5U0ZiOXhGdEZGSGR1Y1E4U2RmWjU4U0FxUExxVFdxSWZy?=
 =?utf-8?B?NlpTSzFUUWlKSlRGT3VwRVEvUVZpZTh6S2E5eURSdm5TT2N0QnVBVlplcjFi?=
 =?utf-8?B?UEd1ejV3K0prNWkvc25LRzlNMnJOZFg2eVVxdXhvS3g2UUhKWm1Yc29XM3Fj?=
 =?utf-8?B?V2ppdStQUi9jbW1yOHVPQmUvZU9zelhqTTErZkE4dXBaU21uMGJYdUkrWlRN?=
 =?utf-8?B?bEZVQlNlYTZBZWhPSHUzMm9pQmtGR3dWQnNSdy96ZkhDVUoyeWdxV3AyOUFj?=
 =?utf-8?B?em4vWmN2QmhSbGx0R0VDaHFxdDd5Q1ViWkNlRXhZbnRtbXhSaHV2V1NCMk1G?=
 =?utf-8?B?SWZMMTRhL21PenFLUVZZQ0owS01BWXNOV0VmQVVlT2hQVnlCYkZaTlNZY3pX?=
 =?utf-8?B?RDhqVXhFVml0THJwdEx6U056S09iWGlsaFRrK21nOE9FSWwrZ3I0WXRBNlV2?=
 =?utf-8?B?VFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c48a04f-9ef5-4fee-3877-08daee72c129
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 16:43:06.2295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BZley24sDstSQ964pNg08ptrUOekZoPBuiHOWUyA3GCxvenCEhf/eP6Un4mEo/00DxraozqeEckPmENs/W6b2I10OE1B/3SLdaaKTfm6lRI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6520
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 1/3/2023 2:06 PM, Babu Moger wrote:
> Some micro benchmarks run multiple threads when started. Monitoring
> (or controlling) the benchmark using the task id is bit tricky. Users
> need to track all the threads and assign them individually to monitor
> or control. For example:
>   $stream_lowOverhead -codeAlg 13 -nRep 100000 -cores 0 1 2 3 -memMB 32
>   -alignKB 8192 -aPadB 0 -bPadB 0 -cPadB 0 -testMask 1
> 
>   $pidof stream_lowOverhead
>   6793
>
> This benchmark actually runs multiple threads underneath on the cores
> listed above. It can be seen with the command:
>   $ps -T -p 6793
>    PID   SPID TTY          TIME CMD
>   6793   6793 pts/2    00:00:00 stream_lowOverh
>   6793   6802 pts/2    00:01:25 stream_lowOverh
>   6793   6803 pts/2    00:01:25 stream_lowOverh
>   6793   6804 pts/2    00:01:25 stream_lowOverh
>   6793   6805 pts/2    00:01:25 stream_lowOverh
> 
> Users need to assign these threads individually to the resctrl group for
> monitoring or controlling.
> 
>   $echo 6793 > /sys/fs/restrl/clos1/tasks
>   $echo 6802 > /sys/fs/restrl/clos1/tasks
>   $echo 6803 > /sys/fs/restrl/clos1/tasks
>   $echo 6804 > /sys/fs/restrl/clos1/tasks
>   $echo 6805 > /sys/fs/restrl/clos1/tasks
> 
> That is not easy when dealing with numerous threads.

How about:

# echo $$ > /sys/fs/resctrl/clos1/tasks
# stream_lowOverhead -codeAlg 13 -nRep 100000 -cores 0 1 2 3 -memMB 32\
   -alignKB 8192 -aPadB 0 -bPadB 0 -cPadB 0 -testMask 1


Reinette