Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7aa225df-af25-a6be-9bef-c965488ba43a@oracle.com>
Date:   Wed, 4 Jan 2023 17:26:19 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v5 1/6] perf vendor events arm64: Add topdown L1 metrics
 for neoverse-n2
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>,
        Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Andrew Kilroy <andrew.kilroy@arm.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1672745976-2800146-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1672745976-2800146-2-git-send-email-renyu.zj@linux.alibaba.com>
 <5c5716e5-b2ff-67cd-b608-4eeffa7e04bc@oracle.com>
 <1f3d53cb-4160-e29d-3934-d6a488d9fd49@linux.alibaba.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1f3d53cb-4160-e29d-3934-d6a488d9fd49@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU53UmRUQlNoRDNuZUlXcG9zV3czb0dsd0FqVWtoZ0lYSE1nSGhLK21walFY?=
 =?utf-8?B?ZEtidStERDlnRmd0NUpCelBjWnNCOUM5MnFDdVZMMnF1T25yMjVUTTdqUTBo?=
 =?utf-8?B?emdzb1ZmTjRyNVdaNlQrRHpKSVJvcnJJcGlsMlB0ci9BMHppMElJQ3NUOWNE?=
 =?utf-8?B?cWRwY213d1A4WG9yQm5LdzNqVXI5UUtoZE9hSk5RM1JVT2tmRmhyQWkzcnZu?=
 =?utf-8?B?bFFqODY0cDRWOW9tUzQ4eWhVcG4weUo4bHV3STNDemNPUzdIWnBDZldRUURs?=
 =?utf-8?B?eWkwMDhIN0hGbjJncUE5Yy9Ud21LSFNtTnVReEVoOEdyM3dEaXBoOFYzcXlS?=
 =?utf-8?B?bzRadmtaOXMzc1B6N2tSYlRibHFhcGJCSGFmZ0NBZGZoaDZjc2FVd2ljN1JY?=
 =?utf-8?B?M2psTE1ib0Z0cGkzaWgreWlSSGtiSnhJaGhOdkdPcGRFNWMyb2J1SHNObExW?=
 =?utf-8?B?UVV0WlVxcGVNSHQ0L3hQbUl3cVVkeERkLzN5dkZxSGtaOXdseFFyWE9VNlFy?=
 =?utf-8?B?N09EUGpqd1lhaEoycC9hZmxSdHlFZkdZdjdlU0lzYUNZYTRvUnVTaVBFRXRT?=
 =?utf-8?B?amFtTzB3TWVZYjlBUWZ0eFBXaGVKUGxONXV4MFZkTlhGSUVxNWJkNDQrK0t1?=
 =?utf-8?B?MTJJZURPTWdjK0wxbWFSVVFKWUgvdXovQWZPUDc0M1Z3N3NBN1NMb2NaV281?=
 =?utf-8?B?b3hMVTY1TE1YNzdzOU11REpwb21VdzBLZndKeUNOZDUzcXVhRzh5ZVJlckVO?=
 =?utf-8?B?UDl4bFUxTzllVEcwY3JMYXNEOVY1M1RFMkd1RnQwMnY2K0xmTWw4SVpERUZo?=
 =?utf-8?B?SnFjditneVlnWS96am10SXRLZ2dUMXhUdjlsZkJuSUx6NHFDRnloQVo3cHVq?=
 =?utf-8?B?dWRGcmpRQTlpdVBzMjJ0RngveVNveWZsZ3JyZXhMOURBTHR0UHFCU3krd2Zh?=
 =?utf-8?B?WVpZRng0d1Rnb1llMWppbmFUcnl3UURLT1pRMWhTTlVld0RLUzNva0IyMTZE?=
 =?utf-8?B?WFMwTlgyQnNFelE2RzNSdmpFV0JIMG84Tm1mNnFnUXF0OFhtV3RQbjlKWGdh?=
 =?utf-8?B?aGJpaXpSTXZ4elZaRmRWUUF1VjJHTmxvV2w3SnVuNGJ6N3B0OEdFRjI0SFZV?=
 =?utf-8?B?OWlXUEFVVTUwcXdleUQzRDVKNmN5Y29Td0tkYWk5MUVlZVZudXpDMGtiTW9R?=
 =?utf-8?B?V1BuaGFQWDBqQWhJSXJwOUVpeFllR3FYa2pVTmY1bmhlYXJNMlRJakJQQmFh?=
 =?utf-8?B?cXhEZlpncE9GMWZ4RWtLNVJEdVdSREtOT200R0FodFlFeWdibXk4YUI2QTBq?=
 =?utf-8?B?OS9GNkJ5OHE5UGczeTJGdnhueHZ5aFI0OTVETm1kaEJTTkZlVzlCY29BbU1x?=
 =?utf-8?B?VkFNZ00zQXdyMDUxRWtPMFlLN1VKbjRyVDRJazkvcHppSHB1dFByZ1RoL2xQ?=
 =?utf-8?B?aXN3RjZoOXkyZ2VMOUNUQ1A1VFMxcjhYMGl5a2RhcDhjWnJlaE4veUJTU29S?=
 =?utf-8?B?SFJyV1N1V2k3WFlSeW5ocm5RWUpaNU5na2E1enVYSXc5ejEvaVIyaGJzN2ly?=
 =?utf-8?B?ZkU4eGtBUWZqckFySFFwUmpWbU13SmpNMldBYWZFWHZpVEJKekNreUI1bUhh?=
 =?utf-8?B?dUk4d1I3NFlmVytjL3VLL1Bxd0JGWVpWMFZjc0lZcGJVNmw5bFdLNGhpOGJt?=
 =?utf-8?B?cSt4VS9uOUpqNlJmdEJqOFdHQVdUL21iWllDeXMxSUpnWWxZbXZCWlBaVFZ0?=
 =?utf-8?B?dzhCaFozREJ6WEIzcmhsdW90Z0NlOHZpZUUrUnNOU1pFZ1J6UCttZi9WdFZx?=
 =?utf-8?B?Z0RXR3E1eGxmNVliT2RINHFLYnByelU1cTd1Y2NOM29kVkhkNWNlOU42NS9W?=
 =?utf-8?B?YWlmVWhFSUlhUUR2TlVxWVM5TDdrai9DWS9EUmJ4OExhak1ic3RSdjI2dVNP?=
 =?utf-8?B?cXA4bHp3RzZnWmdHOExnM3ZMcTNlS0VSbXo4SnRmSGE0QS9jczFiNlQvK2hF?=
 =?utf-8?B?S2VsRmswTmpaSDZIVFFKeDdYVUVDYjZCZjBhQ3h3OXBBWFI4M0JOOGJLdTJT?=
 =?utf-8?B?NEl1VjhabVk3S2ZMSWlLZEdtR3dIZ082Yk0wd1I2MExGWm1tdS9KR2VXMlNs?=
 =?utf-8?Q?ryuT/Bs4YzrIGyD+/7Ijci7UC?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?U2hpeHVHZndEWkVzQ0MxaEdteWFTeTlKaUVBSUhTaC9KWmJxMXcvT01KWjRC?=
 =?utf-8?B?c3NFRlpQN24yTjFnN2RrWFJmT1Q1emJ6cGNOeVZXWWNiSXlVMjVmUmh6SHFW?=
 =?utf-8?B?UzkxbzkvQ2NFQUVmUWdsd2ZoT1ByaGx0czBDUEJ3bXRhYlQ0dGV6RktwY3Zm?=
 =?utf-8?B?VXlwK2V1WXJscjh4WHRyaFhUYUNWUG1ickkwS09DQmc4UmNkT0hoakRUT0Yy?=
 =?utf-8?B?ZEhhMkpBMXVFUitWNnhZRVQrN2UxaStSYm14YnAxUkpFdnh0c041T2hMbmMy?=
 =?utf-8?B?enl1WVBxMU05ejNWVlZoczdlM29UOW5seW5DeXEwbUFlYzQvL0E1VkJjTEY0?=
 =?utf-8?B?dWtaVWJ2TzU0SHRlYkRlNFdxSTMrTFcxRDZXVndJcGdkOXhtR3V1cnJDaW5W?=
 =?utf-8?B?SXgvNzlZZzlqUytBTmlHTitNL1AxeWhUam5vOEQvcmtEOWRUaE5MbmlleDZ6?=
 =?utf-8?B?R1hjWGdkbFlCUXdmUHR6TitBRGtDOEdKQWQxMjl3R3FlditoQzZRNTJmNk9I?=
 =?utf-8?B?djZCeWMvSlgwM3RWMmFnUjNxOHlZNXFUR2NEbkh6K0w1dS94eW4vMERaWE5n?=
 =?utf-8?B?UE8yVERMek1ZWG9UVzI3cWJGcXdPSEZoNmllQWlHTXAvSEliV0FWRi85MzFY?=
 =?utf-8?B?a1p0V3FXb0g4a01WVC9yY2FENFpJekpCd0pFRGoxSVV1ZGs1N1E2ak9zODdh?=
 =?utf-8?B?ZCs0dkxwY2dmU1AzaG84MWp2UFR2Z29oN0ZldFljbFRyTkI4aGlQbzVLZ1NI?=
 =?utf-8?B?aHViL3N0eElvV0JQMjAvTEdRRWVIbGcrcFViV1hOM0o5YzUxK240ZE5iU3Fq?=
 =?utf-8?B?OWFEbkpoZ2pEQ0hrR3ZYbWgvQ2tTeGJiN0ZHR1BJdE5zZjQ4WjVLc0VzbmZ4?=
 =?utf-8?B?czVjZjM4cnV1cU9Id21SYkRJY0VBeklpWGptOTdmdFZvOUZXUnpuVElELzZQ?=
 =?utf-8?B?OXpOa1IyMzFnL3FWeDI3enl0ZHhmTjY5THVnWjR3eFFKdkFMQ2l0RnpONjhS?=
 =?utf-8?B?aGFRQ2VKSzVQU0VGcU9nWTNKNTlsekV4cFk4VWpFUm0rQXBDZGFQODZkT29p?=
 =?utf-8?B?S3lYUGtqV1pGZWNobkZTdEZnZXQ5RFVVTjFLRFp1cnlWSDVmQk1mWmxGMnJh?=
 =?utf-8?B?OUljd3BvaThTdmVOeTNDazlaQ3B0UVN0YlN6T0ZnTVF2YVcrSXE5ZGpDTzlP?=
 =?utf-8?B?elcveTQwRjdZelNleDBUbW5qUkdTT0hCOWdpQ2Z1SFNsZFYrcmZoS1N3NzI3?=
 =?utf-8?B?cTFTczVCMUpDZ2FiRFVlTmJyaDM5V3hMcHQzOUlEczlNRDRPRWRoVzlkMGFk?=
 =?utf-8?B?QTh5Uk9iQldMVjF1MGVubk5FcUw5S2s3YTZNTHNPaThKU0JoeGI4TFQ3Zzdy?=
 =?utf-8?B?MjRNajdaRjI1RTdsS0NtSERvVDcrL2hiVTFHV2ZKM2crUnpsN0p5Z2hTYjhG?=
 =?utf-8?B?R1Rjc1B5THhGSWFaRWR3Q01OSG5VYkV4U3J4SnlsbEZrUXYwbVRvTm93c1Mx?=
 =?utf-8?B?S3E2RlR0Q2R2S0s3VVdoZTVkZ0pHZU9TMlBZVXB4ZVBFcVdqM3IvT1o2c2Fk?=
 =?utf-8?B?cnVhZEdOZ2NhRnA4U0NVR1g0SWlCTG4yVHhnQ1ZyRzhnMTNJMmdiangwRWhZ?=
 =?utf-8?B?Vi9CUzFEZHlkbFVXVE1ncVZaQWlCdmNsUHlSK1ZSUjVxZnN5MUUyaFZtbyty?=
 =?utf-8?B?VmlyWk5oL2lBY1JDUmdKTXdYM1dqKzRIMmhHZ3ZMOVRrZWJkTFlPRWxyOWdE?=
 =?utf-8?B?dlhCRnh5SGpXYlNpK2twdkN0T0U4bW04UDFYUkp1VVZNMys4cU5Cd2FBYzZn?=
 =?utf-8?B?dHRkbzZUVzNSYUQ0VWhYeDNONHIwVWY5ZjdTbVNuYkJBajAvZlh6d3VGR05Q?=
 =?utf-8?B?cDk0dXdaZ1FoTmtqVSsxbDdhZ3E3YVc1b3RzZkRXMmV0TGlEdWZiZEwyNTZG?=
 =?utf-8?Q?aYeX/tqyndo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 740e1f01-2b9d-4451-ce07-08daee78cf2a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 17:26:26.7708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hKaCoWVXll7xnIC9si/LwIDhGKvmWQZr01pC00BTg6agSmQ5LZyMwInUWzelCv1UTq7LynS49nkn56PtXAmb5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6987
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-04_07,2023-01-04_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301040145
X-Proofpoint-ORIG-GUID: Fg0bcG08nZAwLOivHije0lZMZnBkY_P3
X-Proofpoint-GUID: Fg0bcG08nZAwLOivHije0lZMZnBkY_P3
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/01/2023 05:05, Jing Zhang wrote:
> 
> 
> 在 2023/1/3 下午7:52, John Garry 写道:
>> On 03/01/2023 11:39, Jing Zhang wrote:
>>> The formula of topdown L1 on neoverse-n2 is from ARM sbsa7.0 platform
>>> design document [0], D37-38.
>>
>> I think that I mentioned this before - if the these metrics are coming from an sbsa doc, then they are standard. As such, we can make them "arch std events" and put them in a common json such as sbsa.json, so that other cores may reuse.
>>
>> You don't strictly have to do do this now, but it would be better.
>>
> 
> Hi John,

Hi Jing,

> 
> I would really like to do this, but as discussed earlier, slot is different on each architectures.
> If I do not specify the value of the slot in sbsa.json, then in the json file of n2/v1, I need to
> overwrite each topdown "MetricExpr". In other words, the metrics placed in the sbsa.json file only
> reuse "BriefDescription", "MetricGroup" and "ScaleUnit". So I'm not sure if it's acceptable?

I don't see a lot of value in that really.

However, for this value of slot, isn't this discoverable from a system 
register per core? Quoting the sbsa: "The IMPLEMENTATION DEFINED 
constant SLOTS is discoverable from the system register 
PMMIR_EL1.SLOTS." Did you consider how this could be used?

> 
> In addition, James mentioned that if the units and names and group names of different architectures
> are not unified, it will become complicated.
> 

Thanks,
John