Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 Jan 2023 18:08:06 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Yann Sionneau <ysionneau@kalray.eu>
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Clement Leger <clement.leger@bootlin.com>,
        Julian Vetter <jvetter@kalray.eu>
Subject: Re: [RFC PATCH 19/25] kvx: power: scall poweroff driver
Message-ID: <20230104170806.jrb6qnoyk6buzvg5@mercury.elektranox.org>
References: <20230103164359.24347-1-ysionneau@kalray.eu>
 <20230103164359.24347-20-ysionneau@kalray.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uq66y7ogcsufp33e"
Content-Disposition: inline
In-Reply-To: <20230103164359.24347-20-ysionneau@kalray.eu>
Precedence: bulk


--uq66y7ogcsufp33e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jan 03, 2023 at 05:43:53PM +0100, Yann Sionneau wrote:
> Add a driver to poweroff the Coolidge SoC
> when running under Qemu, ISS or when
> the debugger (jtag-runner) runs on PL0
> to catch the scall.

line length of 41 characters is quite short.

> CC: Sebastian Reichel <sre@kernel.org>
> CC: linux-kernel@vger.kernel.org
> CC: linux-pm@vger.kernel.org
> Co-developed-by: Clement Leger <clement.leger@bootlin.com>
> Signed-off-by: Clement Leger <clement.leger@bootlin.com>
> Co-developed-by: Julian Vetter <jvetter@kalray.eu>
> Signed-off-by: Julian Vetter <jvetter@kalray.eu>
> Signed-off-by: Yann Sionneau <ysionneau@kalray.eu>
> ---
>  drivers/power/reset/kvx-scall-poweroff.c | 53 ++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 drivers/power/reset/kvx-scall-poweroff.c
>=20
> diff --git a/drivers/power/reset/kvx-scall-poweroff.c b/drivers/power/res=
et/kvx-scall-poweroff.c
> new file mode 100644
> index 000000000000..586d93fbcaed
> --- /dev/null
> +++ b/drivers/power/reset/kvx-scall-poweroff.c
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2017 - 2022 Kalray Inc.
> + * Author(s): Clement Leger
> + */
> +
> +#include <linux/pm.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#define SCALL_NUM_EXIT	"0xfff"
> +
> +static void kvx_scall_poweroff(void)
> +{
> +	register int status asm("r0") =3D 0;
> +
> +	asm volatile ("scall " SCALL_NUM_EXIT "\n\t;;"
> +		      : /* out */
> +		      : "r"(status));
> +
> +	unreachable();
> +}
> +
> +static int kvx_scall_poweroff_probe(struct platform_device *pdev)
> +{
> +	pm_power_off =3D kvx_scall_poweroff;
> +
> +	return 0;
> +}

Please use devm_register_power_off_handler().

-- Sebastian

> +static int kvx_scall_poweroff_remove(struct platform_device *pdev)
> +{
> +	if (pm_power_off =3D=3D kvx_scall_poweroff)
> +		pm_power_off =3D NULL;
> +
> +	return 0;
> +}
> +
> +static const struct of_device_id kvx_scall_poweroff_of_match[] =3D {
> +	{ .compatible =3D "kalray,kvx-scall-poweroff" },
> +	{}
> +};
> +
> +static struct platform_driver kvx_scall_poweroff_driver =3D {
> +	.probe =3D kvx_scall_poweroff_probe,
> +	.remove =3D kvx_scall_poweroff_remove,
> +	.driver =3D {
> +		.name =3D "kvx-scall-poweroff",
> +		.of_match_table =3D kvx_scall_poweroff_of_match,
> +	},
> +};
> +module_platform_driver(kvx_scall_poweroff_driver);
> --=20
> 2.37.2
>=20
>=20
>=20
>=20
>=20

--uq66y7ogcsufp33e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmO1smUACgkQ2O7X88g7
+pqgzg//d3Xremg6XYAx7LO05CGbscipl+LZlHCgESkUNjRgsh+B4wkHwa/YFK9v
3CRp+z8Xdl+hpiFyNlWOjhbWW+gKz6LMDkIcnRyXXvp8kH2CXrNQBKiIzNNnnGot
nOHtd8tmvuUhpvKYmQq5ZIfdAPFkRP4MX6/SbGIP89fUtz8d4remh1yeFeOh8jFB
3oN2yi/HnY1xKue0WH0PUGCg+fSHbfXXF9jyb52CUkQ20LwE6FzTYTe6GGgFfPYc
tk2DFMnt8JqoId2aVWzpjkoHab1fQKb0qPR2KLfbH/9DAbo6/P2ZFe20tQMe3YaC
wbiPaM1W18kqb3QhRTwUddo3XPRO57UxelJt37h3h+l0O1BYTFIwnFYg31aODFCW
j9lUKAh/+kepNmcha4FXgnLtFzUiQt7zH1kDdnrKBc0LT+cxfsklEE8fRV+IRgSl
tOFHBtAPQUq20NlnSlavVMUD8zgOSlZXiR/fEt993BtRrk/DtgWeOCMIPR5FlN9I
yjRAjXfEMsw5pZJOLBqgGiNwIi5eZGE24BRv2GTuRnQF0LU4YL3uGNAHJEDpb0zR
EjuMgMzOwSb4k49DZ5uymqD5T2PZ7Xh+A+/olncZAGDkeq4B6k+gDCFaPQtHfvrv
LwGQusmHZciEHpfg4Q9f87iCi/z13VUVelaKWTTXl6hgrOHlzn8=
=GMph
-----END PGP SIGNATURE-----

--uq66y7ogcsufp33e--