Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13620162rwl; Wed, 4 Jan 2023 10:31:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXvqVZo1SEDy16pQwUffHKmIhlK2U5A03aQhAYysSOqVNC3tPcfxnV2CEvSzMXBKqNaEz/Ja X-Received: by 2002:a05:6402:327:b0:483:fea4:295 with SMTP id q7-20020a056402032700b00483fea40295mr2764750edw.16.1672857116697; Wed, 04 Jan 2023 10:31:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672857116; cv=none; d=google.com; s=arc-20160816; b=GTMokQ14NW6IrJpmnP69Db/Zx/SvZEGv77yzmlCqqA15bE9T46JMH93iVIw2Mw9Z2X RM7I2hB0P+TX2EigkHa32CwXPWKS4x/gbio/pcNgQ+ze3Zkde0QzDWHap9B1kICQBUa9 YtDgVMI5VjAzoZ/AYVtHZZdqIaOWdMmtDB8ZVv9eEkVkCbBfsk7T0EANzXIz6pe5dp1v ZZV+mc1Z/wKWfg2u6T12LF3dtZ3uQRxIc4aoo+FtHn/T3TnDvIJU0HzqxRduWA4hs5D6 DdMb8a+xzqJzmRxviCt1LV1wdXWLx08fobbCqelj8ePxnOGFksYyJV7Q6kdxMUwsGgWQ KW+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kgv5xJTMYBes8sfoQjemKe9ruol1NM3cm77eq+o8GtA=; b=NpMng0Eh0NFrxKMOWu/jwFQSTg0h4+lBS7m+O7OybIMC+Ga5crCfCvL/KvN35wGBdk +/uIWkvZNxJZH33hbleSwLFn4tFt/aM6Y+39rqWpP5qp82YAXa20EpTDGX+6/3btOCCN fDFw61pPn9tViZjq5PNotk3a9n4IqzVQbFBGuh32EkHOhqgFhAmRtJ4fTK1rPPi87gaB Lrm8o0eB22SwBXd9K+RrShnsAhyOG+pRgL4rPJZuw43agyKcsYeO1vlf7hPCuF2qIWy3 Uwuw1r/kJFcPBa6RvSoWI0mfdYqjIaeMAO2dXWKEtAN2sW23+b2KTgHJreKeuPoM3EJ+ GJAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3MrjuwYl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w18-20020a056402269200b0045782fcb80asi33307326edd.225.2023.01.04.10.31.43; Wed, 04 Jan 2023 10:31:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3MrjuwYl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239618AbjADRqK (ORCPT + 56 others); Wed, 4 Jan 2023 12:46:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235047AbjADRqH (ORCPT ); Wed, 4 Jan 2023 12:46:07 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E55517070; Wed, 4 Jan 2023 09:46:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kgv5xJTMYBes8sfoQjemKe9ruol1NM3cm77eq+o8GtA=; b=3MrjuwYl4M3hggJ3oeSipYUhcP JcFKuOrUOVWCOV0p2XQvxxySQ1xLU6ZCOWt/jW645tyn+dA/O/dsIHbi1YYt/V0SVbwS101jTcpqB yPXdIWDzzMtDYH/AZ0eU0sSWrVyI8cBDYqGNBp0ks6T+24H7I6BoW3Al0LgmbtSeZw5U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pD7pf-0019XD-5t; Wed, 04 Jan 2023 18:45:43 +0100 Date: Wed, 4 Jan 2023 18:45:43 +0100 From: Andrew Lunn To: Biao Huang Cc: AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Richard Cochran , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, macpaul.lin@mediatek.com, netdev@vger.kernel.org Subject: Re: [PATCH v7 1/2] stmmac: dwmac-mediatek: remove the dwmac_fix_mac_speed Message-ID: References: <20230104085857.2410-1-biao.huang@mediatek.com> <20230104085857.2410-2-biao.huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104085857.2410-2-biao.huang@mediatek.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2023 at 04:58:56PM +0800, Biao Huang wrote: > In current driver, MAC will always enable 2ns delay in RGMII mode, > but that's not the correct usage. > > Remove the dwmac_fix_mac_speed() in driver, and recommend "rgmii-id" > for phy-mode in device tree. > > Fixes: f2d356a6ab71 ("stmmac: dwmac-mediatek: add support for mt8195") > Signed-off-by: Biao Huang Reviewed-by: Andrew Lunn Andrew