Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13648911rwl; Wed, 4 Jan 2023 11:00:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXuSJvYHXWSEUbllcZhkacGdHrjDJiCeNwq45h3wPPfj+JIiku6NvR4PG+kF971HQsN2L4sD X-Received: by 2002:a17:902:e889:b0:18f:6cb:22ca with SMTP id w9-20020a170902e88900b0018f06cb22camr68561246plg.67.1672858813500; Wed, 04 Jan 2023 11:00:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672858813; cv=none; d=google.com; s=arc-20160816; b=hY9nQXXfOZRHePnugw78n+AqHAiwoVElc0OscqonGoZXMuE2xAAakCLc9ZUgaFzTfi bzhzSw/z//NJmHzj+znt+KigjjgzXKw9ITeCrzWyBm8EWaUXvHka1Iywa7ZCTs97mBxC EjDJqKzGS1scmWRMFE/94ehBTkNvPV8LillRMQ9NdDowZi4xv/x3fBx6s/S8GD6qhI44 9c+d2ENPLC7b+YrMwGxxXnVR6CcvSwa7Hyxsx+HJR3FvQLivq0Xl42nVshJfS6sO3D/R KKs/3z7ZQL8YYzSKaKqFJbd5nJx4FnSOviqOHecRFxaWMECHlTKTZjtj6gEP3R8HNw5U m7cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=V1dRPJU4MdXr7AhvEfp9V8UzepfOOnVIYAc2m/AgMOQ=; b=eCzVE0vr5xeVwbvUwyKZfxAo/wfsU9bktOz8l05gLezd+IdWSCSNf/C/6zA4sczxMZ 1pIpcLNkXvU3kwDm0ZeS5mwN6V5fLml8zFqn6HpAgwqK/NFqi51GEyfOgoEfg/Lcuo+d gKqbH14QSlTy6j3T1F8bwyq8eGspNGfbCFKxODKTPCvFTprLW6Zbbt1IcsLZ3pBfO40H Ff1D/cMZxNW4WPiJKJqfV+FLab4K1dslfKy+t8G5hfyOjONXmLwUyP6TlPFK34tYdgsq S7jin1q/JlguxyW1C+Sa+8J3uqAyMYZCjsplsFfEwDc4eL3bgNjldWBTObbCR5Nbm9aP TRRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="CTDNr/RC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e19-20020a170902e0d300b00188fce355c9si32123380pla.42.2023.01.04.11.00.06; Wed, 04 Jan 2023 11:00:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="CTDNr/RC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240006AbjADSlt (ORCPT + 56 others); Wed, 4 Jan 2023 13:41:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235215AbjADSle (ORCPT ); Wed, 4 Jan 2023 13:41:34 -0500 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A6421BEB1 for ; Wed, 4 Jan 2023 10:41:33 -0800 (PST) Received: by mail-yb1-xb35.google.com with SMTP id 188so21190960ybi.9 for ; Wed, 04 Jan 2023 10:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V1dRPJU4MdXr7AhvEfp9V8UzepfOOnVIYAc2m/AgMOQ=; b=CTDNr/RC+q50aWV+hPJVBcM0kwjHrJ+Squjp5dQYeMdRAlMLTYW6AUWGozIV63m6H/ RuJ7O1HVN2+bWAj4GV+Q1ZxJvyVkhvIyGW/UxEcDrTp/wcQAhVQ+UCKP58Ynq8eACwgM blJj6zCXRq9pBQHqWKlQpTbTQBTxz0p2fii2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V1dRPJU4MdXr7AhvEfp9V8UzepfOOnVIYAc2m/AgMOQ=; b=aaBIfuRQpKzpguLC+EcczxhtTCpmmIRr8N0WmZqD6vOWy7lAQzEO+HHNgdki+rkuCu Ut7xFgGflPezliYq4qT4uA+VDaRZGtiQ9SAactj8GXlDQbAaM+EGaEUH7XdwJLLXZPuW Fa8DiSh4ofOomwMa1dA06Zm0SOw7BaQGI7dfvx1uzQ10ANnJiXVPkbwWOJWIujIWN8Dn IuIlpzPzEixHJIwEQ+mpw5r2DjYpYkjU8JXtgOfNrIjLW9D4fQBk00w+ZIpuuMip/YpK TvZ1laZQovlrsSBH2uI4daww/ezjmtSLZv74k/5qo8ToLoIj6h6+ARo7WG4P29xK1USl N6Zw== X-Gm-Message-State: AFqh2kpAjm9/fkvjo6nattZArjblgtH+VACYXS+UkDeG+l6qBtEavWje 30Yb1as/xTA/jdf3m7ybORviyXQQ415ZpqyXKMV4WA== X-Received: by 2002:a25:1083:0:b0:7ae:5e48:383b with SMTP id 125-20020a251083000000b007ae5e48383bmr439846ybq.223.1672857692715; Wed, 04 Jan 2023 10:41:32 -0800 (PST) MIME-Version: 1.0 References: <20230104011524.369764-1-robbarnes@google.com> <20230104011524.369764-3-robbarnes@google.com> In-Reply-To: <20230104011524.369764-3-robbarnes@google.com> From: Prashant Malani Date: Wed, 4 Jan 2023 10:41:22 -0800 Message-ID: Subject: Re: [PATCH v3 2/2] platform/chrome: cros_ec: Shutdown on EC Panic To: Rob Barnes Cc: groeck@chromium.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, dtor@chromium.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 3, 2023 at 5:15 PM Rob Barnes wrote: > > When an EC panic is reported, attempt an orderly shutdown. > Force a shutdown after a brief timeout if the orderly shutdown > fails for any reason. > > Using the common hw_protection_shutdown utility function since > an EC panic has the potential to cause hw damage. > > This is all best effort. EC should also force a hard reset after a > short timeout. > > Signed-off-by: Rob Barnes FWIW: Reviewed-by: Prashant Malani