Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ba3be1f7-53ee-e794-700a-a9d5314b9c11@amd.com>
Date:   Wed, 4 Jan 2023 12:06:44 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH 2/3] x86/resctrl: Move the task's threads to the group
 automatically
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, fenghua.yu@intel.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        corbet@lwn.net, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, eranian@google.com,
        peternewman@google.com
References: <167278351577.34228.12803395505584557101.stgit@bmoger-ubuntu>
 <167278360189.34228.2442698916556329960.stgit@bmoger-ubuntu>
 <21a4f7d7-eec6-f04e-9707-59236c0f937f@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <21a4f7d7-eec6-f04e-9707-59236c0f937f@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzNlT3FYeHd0TGMxVytDaVJ6VnZnYkxjZDVXdGdGVXBlOWRFT0pNZE9NUk9V?=
 =?utf-8?B?b0dGeDRRcWFCRFZ0bnNuTTgrcHY2Q3dSbFE0Y0pid3dVQ2h6VDYxZmd5OHo1?=
 =?utf-8?B?cHBBZ3padWxOTytCbkdaZlRuZGhGa3ZaOUxtV0dJWUxCb1FDNlNCVURYTlBK?=
 =?utf-8?B?WEJOTm80c2o1YWRhME9ZUjR0Mmt4ZnBVelBWQzdhYVprQ2tFOS9wNS9ERE92?=
 =?utf-8?B?VlN2SXAzOGFPb2c1emZVSzFpdG8rT3YvUnp5QlRQNVExdU8zb1dlZW1SajAv?=
 =?utf-8?B?TWYzRSt0SlBzbDRQU2pmd0RFVFkvbzJUQVN2eE5vMXRkUjZjazlPYllvanFP?=
 =?utf-8?B?dW1VS0hGejJ2WGdqd2t3WFB2cktTczUvSlRSZDA4b2tOWWNpaURsOGU0U0ZI?=
 =?utf-8?B?L1Y5ckNpa1BSeWp2MTE2YjZXOWNVUzBzMUprenY0MVQrVDA0dHpJYzNvWElJ?=
 =?utf-8?B?OUNRWDBiNVJGVS9oY05PVDlUQnh5VWhWN0hFVWsrMGJ3d3N6b1pnNUZ2a2pY?=
 =?utf-8?B?U3k5ZVZWc2R0ZTZiZktGSWxCaExwWFNkRHQ4d2NYQXZxV0Y3NEtpS1pLb2Ri?=
 =?utf-8?B?TjNmaGs1TTJhNWFMczBxSkNRL2YrKytOVm0yOEwydENGZnErc0VwQk5GUkFs?=
 =?utf-8?B?WlFKazB5RHovZVp6YldwdEE4TGtNTlUxYVlWTGp2VnNWVVVpT3gzbnliTE43?=
 =?utf-8?B?Y2hVa2V1bHVtTVBOTmpjclVjRUVqbE1rV3M5bEUxQWRlVzQveWVUOHlqVWhr?=
 =?utf-8?B?ZzZLbDY3WUFVbnFMRFBPNzIvNk5ZdldLU3FOYXAzL1k3SnZ3cm9oOVRpb2RG?=
 =?utf-8?B?amNaQWxOaTlwVnJucTkxcHJDOVVQUDdCV08ydG9xS0hOaTJMZ2l0NFI1eVV2?=
 =?utf-8?B?c3YvcEs4MUZCVTduc0lPS2NGa1IwYS9yMVBaR1VxSTN5MUlyZjBZY1lTUGNa?=
 =?utf-8?B?NEMybEJhdTQxZDJxb3ZrZEtuTDdsMWdEMTVEejZhbHplZ2NHdENkQklNWU96?=
 =?utf-8?B?WFM0eDVTeVNBOEFtaVdST256ZzlxYXMxYjMxRFNVWmRia1Y1SXVFL1F6M0Ju?=
 =?utf-8?B?RlFPaFBQbDJmaGhxUWN0WkFXcFBnQWdiektGdEs2aDRPd1ZubGxtYkJoTnZC?=
 =?utf-8?B?QkdiL1l1Wmg3cmRuR3NsQ2V1UWpianlOWkR0TnAyclduWkRrMkt3a0JJY2U4?=
 =?utf-8?B?VC9kRWRIK0k2S0RGRUwwT3J2RERUa1A5a2NpeUNEdVZsbnJjQ1lwaE1oRVY2?=
 =?utf-8?B?YWVGMG9hN3VRTkRBekw2VkZJUjB0cFlnbW45aEd3K1UrQXVqTlBtMEd5NVd3?=
 =?utf-8?B?Q09qK0oxbzMzdDRFT2w0WWhzTUlITStCak9TL3MzMUUrTVFuWldKRGZ4VVZk?=
 =?utf-8?B?dHRPMHVkeVd0Z1BXWkdZbk1qS1lwVEc4SkU3dDNQSTQ3N2pMU3dCOXA0TjQ0?=
 =?utf-8?B?cUhub0FTemxTaUs0dGRKeXBPK1dhajFHQXJ4NWVVdm9ESUlpWllrRGxiSDJX?=
 =?utf-8?B?TWNvb1NXdHByZjhJNnFGRUMxeVRIeHFMcUJFeTBRbHp2ajRLZmdkYkZBNWZX?=
 =?utf-8?B?aVdheUtxWElESXF1T0gzTlZKMGhQbnhydEM0RmtJVHJGTWVnVDhDbGtYU29m?=
 =?utf-8?B?VjgraFVIK0FPSEVXaEdEVWF1SVBrYXFLNHNuV2cwWklEK3dtQXB1UWdpWWMy?=
 =?utf-8?B?VW9ObmdvL3pTWkRTZ1h0Q3ZIZGlVMUJkTWVPRnAram10NmErYmY4clNZWkJT?=
 =?utf-8?B?alRzOXJCcmVpRzhtbXZDZng4aUFZOXlvZHU0WTdTT2NHMVdxNllwVFVWTDMw?=
 =?utf-8?B?U0NJTXZPdTViZXlBekdDNllEeGRJc2xPeDhrRFBjSEppbGpDMlREb053OEU2?=
 =?utf-8?B?RnplV0FRNGV5NHpjSStqaW9ZS1BsdmpsRGpYUGU4eFVkU2JwSlBON0QwWGRP?=
 =?utf-8?B?Ym8xR2FTTmM5em5zVER4b2s3S3VMTUtrd0tBREpEWEp5bC9XOWVOeVF3VDJn?=
 =?utf-8?B?TWsrM0YybFE5N1duN3g1dkRmajUvS0l1eVZMVGRIdk1JUmtsejdTUG5uZHI4?=
 =?utf-8?B?OFc5ZEdhcE5sZDdJOFdPRUlwMWVNYnhwYUJoY3hRWjZ4S21halFSUHlGa2VY?=
 =?utf-8?Q?AW9ySy3f75Ih8orBUFm3N3tNn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f784c91-81ed-47a4-e16a-08daee7e727f
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 18:06:48.2182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nvd/YqqNqsOBjXcqfz9TDa2ULrgFPPLcy0ul7bkdYg+DrZ5Fx7CyjQC9KWno/LC5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5277
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Reinette,

On 1/4/23 10:43, Reinette Chatre wrote:
> Hi Babu,
>
> On 1/3/2023 2:06 PM, Babu Moger wrote:
>> Some micro benchmarks run multiple threads when started. Monitoring
>> (or controlling) the benchmark using the task id is bit tricky. Users
>> need to track all the threads and assign them individually to monitor
>> or control. For example:
>>   $stream_lowOverhead -codeAlg 13 -nRep 100000 -cores 0 1 2 3 -memMB 32
>>   -alignKB 8192 -aPadB 0 -bPadB 0 -cPadB 0 -testMask 1
>>
>>   $pidof stream_lowOverhead
>>   6793
>>
>> This benchmark actually runs multiple threads underneath on the cores
>> listed above. It can be seen with the command:
>>   $ps -T -p 6793
>>    PID   SPID TTY          TIME CMD
>>   6793   6793 pts/2    00:00:00 stream_lowOverh
>>   6793   6802 pts/2    00:01:25 stream_lowOverh
>>   6793   6803 pts/2    00:01:25 stream_lowOverh
>>   6793   6804 pts/2    00:01:25 stream_lowOverh
>>   6793   6805 pts/2    00:01:25 stream_lowOverh
>>
>> Users need to assign these threads individually to the resctrl group for
>> monitoring or controlling.
>>
>>   $echo 6793 > /sys/fs/restrl/clos1/tasks
>>   $echo 6802 > /sys/fs/restrl/clos1/tasks
>>   $echo 6803 > /sys/fs/restrl/clos1/tasks
>>   $echo 6804 > /sys/fs/restrl/clos1/tasks
>>   $echo 6805 > /sys/fs/restrl/clos1/tasks
>>
>> That is not easy when dealing with numerous threads.
> How about:
>
> # echo $$ > /sys/fs/resctrl/clos1/tasks
> # stream_lowOverhead -codeAlg 13 -nRep 100000 -cores 0 1 2 3 -memMB 32\
>    -alignKB 8192 -aPadB 0 -bPadB 0 -cPadB 0 -testMask 1

Yes, That works. We can use that as a work-around for now.

I will drop this patch for now. I will have to figure out how to handle
failures in the middle of task/thread movement.

Will have to revisit this in the future. Will re-submit patch 1 and 3.

Thanks

Babu


>
> Reinette

-- 
Thanks
Babu Moger