Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp13666123rwl; Wed, 4 Jan 2023 11:13:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXseG2TH3vyy01rOXKQJ2UdwnvM9vqax8lHJHWw7Nbwzrcqu/XzbrpyQ4OXJ5nKYk7PkhsvW X-Received: by 2002:a17:902:9a96:b0:192:54f6:fb4c with SMTP id w22-20020a1709029a9600b0019254f6fb4cmr43688751plp.54.1672859612882; Wed, 04 Jan 2023 11:13:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672859612; cv=none; d=google.com; s=arc-20160816; b=fBpqipKLt6loJb246JhRt3Zo4p1/4adNtuIoWthvaMkLP3x8hQanVVJLjRTAsSSwQ+ EtyosTrwbU9bjIgyDuu4+2yjJw5ANHM4vlE1xGc/EqQ2T81xHmZBwDYpYwEz6O0CNn5q EgruOkH8Y8nEYVOk2QauJsUBSZ8ICvEWUx4MSGqb3CUUFJGM7OVjaBZ3Cfa9dTNsGnTh X3iJWPTK6YdZ+YGoIh81HlhvugeD4eh3CctyYqp5yYq1AxfOJjxKPUUX/C925V4l6/cc P9rtS76551gBRtsSOwq9as8EFMxTZS/MyWs/NVNajm9EKM7f9tRcjkpzHujxacbNrz3J Kyvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2gT4TZ3HWHssgtEaJZSgYd2BRTmP0h8bA23SxSdx5D8=; b=XPBRox9jwArlcOPCUzTLeB2EuPwlchpBi17pKWe9SvtQoP6Ea3jDRJe1BMVhA+KYLC K2Bg6MXK599jQGXI/9lbox0R8I9BAUwk8Smpj7psjJyc2zENCDzx3h76P7OAN7Bs6fUK e3LY+drJ/Ur2g9K4RyrhFEYkCMZN77dprhp+uOecjiEkhtanzyJbEDMBlJgIZbrM8oo8 o6PI6rYp/gRewWC/s+rTr6YAGH+RSY0D5iNDNxQ6eUPD47xyq0kxeatNhfF6QzDDyaeC hJ6QxyxSHLTq29Rp3zfuQMD7VvK9p2tVNLue03Twfr2pSYdDs6c3W/MHjKMcLNvhyuZO aMRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nCRON46Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jj13-20020a170903048d00b00189b15ea35bsi33340848plb.208.2023.01.04.11.13.25; Wed, 04 Jan 2023 11:13:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nCRON46Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239618AbjADS6a (ORCPT + 58 others); Wed, 4 Jan 2023 13:58:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjADS62 (ORCPT ); Wed, 4 Jan 2023 13:58:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51F6813DFA; Wed, 4 Jan 2023 10:58:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 95DD1B8189E; Wed, 4 Jan 2023 18:58:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADC6AC433D2; Wed, 4 Jan 2023 18:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672858704; bh=3vVdpC5QMDKOjWmTQ/3/rRhszXXRqwxpzpXtVyl2ErM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nCRON46YeHs7jNdMfdhH+ALgawFnY0kpHgtnHzibpHnwEad3oX4X0nC2+1J7MMTX6 2RXIXGRTQpCNMcfQLXZ8m23hB9NTdaZBuUmupfZmg6rDsO3PozDpW5U/g97y1GuTjn h/Rxnpxcz3whYsdH+pefrXZit7Zk1TJS2rp2mdxnVRhaCqSHTVxELKMvFPh33j8dru zkA+pR1tJ6dR4ev8TktVTJI1kGO34iBW7TGKr+w1orRJQ9cu0Fo2tsECUvFhbJ3Cp7 wt9Vq0qBTLUwH7G7krR8wIbvTTVT+dtuUHdQFaOi057xHDyk4u/Z2IwzIOLoE3UT/z KODpDyecyachw== Date: Wed, 4 Jan 2023 18:58:19 +0000 From: Lee Jones To: Miaoqian Lin Cc: Pavel Machek , Jean-Jacques Hiblot , Tomi Valkeinen , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: led-core: Fix refcount leak in of_led_get Message-ID: References: <20221220121807.1543790-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221220121807.1543790-1-linmq006@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Dec 2022, Miaoqian Lin wrote: > class_find_device_by_of_node() calls class_find_device(), it will take > the reference, use the put_device() to drop the reference when not need > anymore. > > Fixes: 699a8c7c4bd3 ("leds: Add of_led_get() and led_put()") > Signed-off-by: Miaoqian Lin > --- > drivers/leds/led-class.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks -- Lee Jones [李琼斯]