Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f94a3126-41ba-2263-eac3-ac877042c9ea@amd.com>
Date:   Wed, 4 Jan 2023 13:54:58 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v5 0/2] docs: Integrate rustdoc into Rust documentation
Content-Language: en-US
To:     Jonathan Corbet <corbet@lwn.net>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     ojeda@kernel.org, akiyks@gmail.com, jani.nikula@linux.intel.com,
        rdunlap@infradead.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, konstantin@linuxfoundation.org
References: <20221207173053.1463800-1-carlos.bilbao@amd.com>
 <20221228174623.144199-1-carlos.bilbao@amd.com> <87wn64fq7d.fsf@meer.lwn.net>
 <CANiq72mC+WzOxhZVtEvnsFYzuBPkd51=TYXK01ztcTZ-CAcUiw@mail.gmail.com>
 <87h6x7cfiy.fsf@meer.lwn.net>
 <CANiq72n3qnWwDjp0E1xY1m15qhMHz8_AXcL9hstVM8Xwfi=pbw@mail.gmail.com>
 <874jt6cpw0.fsf@meer.lwn.net>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <874jt6cpw0.fsf@meer.lwn.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1BtcUZJRUcvNGdIQjdjV3ZvTDVSUUozVlpOaUJvb3lncjBOc3lRbjRMaFQ3?=
 =?utf-8?B?UjBYMG1pMmxabTVuZ1pUVnNWRUNGSXNYUktvMDZ0R2dheWpVRm03Vk5MOWpK?=
 =?utf-8?B?VTJxb0ZpVHVTcllZMHRYYk81a3U3cGN4anltSGpKeWFLWVlhR3BpL0tyQWp3?=
 =?utf-8?B?OGVmWHEzdnlaeldGQVpnaVBkSXc5eENjeWxkVW05MndHNThiYVBRbEp2d0hO?=
 =?utf-8?B?ckoyUElQdmlDT3JsbHl2TDNPMHNlNHNyaTBIc0F2V21QUTFXQmRyYWdMYlk1?=
 =?utf-8?B?TEJMTGRDVndoV2p5bHViSGgrdE9FSnA1V2RMcGU5c2dwcU5CaFZqSHhqTVQy?=
 =?utf-8?B?bWs0TXFKdU4xcmYyb3NYNmc0cExaQTE1dGV5UFk1Q2tyUGMrc0t0eHd6TWhI?=
 =?utf-8?B?V1R3dEUrUFRTSE1EaFFBVkRGUnJIMldKZ0FBUnR2WjNvUlpER0VRN0paUVVB?=
 =?utf-8?B?Ui9kaUxNRk82eHpJQlpUc3B4YWdCcDhyQjFVeTB0QjlSVE90S05kZHVwY3dq?=
 =?utf-8?B?MzJyL3Z6U0tOYkg0dklYejRVNkV5N2JNQmc5RjMrRmpPbFA1NUM5YjlJNmVo?=
 =?utf-8?B?VXFVQmJjNmkxemIrcjhlRWdjaFZIWnJiQ0d6MUx5b0YvZ3pkM0F0NGt3Q3Jl?=
 =?utf-8?B?OGc4UlFCNVl3S0k0M3JZUm1OeXlwbENBY3RGN0o3VjltZFBDNndRckJJQ0lR?=
 =?utf-8?B?YnB4ZTlDaUhUaG5KWXlpN2tRTTBQRklPMnppemE4KzF1Qy91OW5pYkp0WjZE?=
 =?utf-8?B?MUswa3VjbmFPMVVoY1VEajB1c0Y3TTJuU0ZlUG1GV1lvRDF1QWw5SkRWZWZT?=
 =?utf-8?B?U2JMUEIrVlZzdFUyN283T3B4N0VjWWs5VzNrenVPelVnOFlXTXNWQjFrcmd5?=
 =?utf-8?B?ZG90NDJTRHNwMWdkQ0EwUHF2YTNMZWpjNHVOK2oyd3o1dGFmNmwwMS9nK2VI?=
 =?utf-8?B?ZUVvd3VaenRNNCsvR2VUeTZta1IwWUcyTXFmcDUxeGtCUlVYZStoQ1N6bXlj?=
 =?utf-8?B?cHpUWm92eVNxc0pYMDJsZE42QlVmeDRSWE9QMThFUjlxSWtaSUZ5ZHBvd2RR?=
 =?utf-8?B?eDY2cFo5REQvb1RMM2pzU1daUm9WRWlnN210bzBLRmczbDlsSUh5cEtmWFNL?=
 =?utf-8?B?NnFJb0dPTDd2ZjNRTzJ6VzFra0hZZER0OE1XenZEaHdoU00zZHZBNmxiY0RW?=
 =?utf-8?B?Y1VBeDlFN0lKYzd1UndsRGNqV1lmdllsL3laNDZwT052enJEU1RLVjRUNElq?=
 =?utf-8?B?bEwxbjdLemFZYWc4SDdXZWx6U0xjdmdZMVBrbGMydGFHKzlLcEJYbjJGUFM4?=
 =?utf-8?B?MHpIbm85Zmp6RE1VaTVubE4yalJVVG1tQ0JESWM4SE1KYU1taDNKb3NCalZi?=
 =?utf-8?B?YlJ2TUVkQmNxUmZBTGJjTFVicmpoWk1hTDJDK1hXTXRTdzRnZ0pqV2F3R2xh?=
 =?utf-8?B?aXMxaHloakxMbzFqVXRJczM0WmdFRHYrUkZsMnBYa29SWmhEWGhvS0FGcjc1?=
 =?utf-8?B?RmR1NWhLWG41RmZIdE9iT1BMM1F2bFVVc0c1N096WUpFWlIyYnJlQkpjYjhr?=
 =?utf-8?B?RHFvVUoySzdmRGxYV2ZHc2x0V3RZTjF6R2dWS0I2cnlzNHRiUktXMEZ0S0J5?=
 =?utf-8?B?NGNpVjlVc05rVy95WDE4cGNnYjkvRXpZdndzdjROUWdwSkNYQkQ5ZWJBN1B4?=
 =?utf-8?B?UEVka1lFa2Z1N2Q0bXo1SllncUptYzBRZG1YMjQ1RGhZNWd1TW42TU9zT2V0?=
 =?utf-8?B?QUx4eC93enhvYjZxTVd2ZGFpcXUvbXBDanZzMVI1NTVsdmZXdWM1eEJZUzEy?=
 =?utf-8?B?SjFvOUNzT0EyMTAzS2JzdGZRMStQVll0UHhYT3ZoT1p4QjZOVkVCeUF6Z1BQ?=
 =?utf-8?B?OW9rT2VickMzR0R3a0FPY2luZFpnYzBjeDdscXZpYnl0Nk03WGhIZGpjODBh?=
 =?utf-8?B?b0ZaVldDVUs1T09SMTE0ejdDdHVzbEc1aDBkOWNiVHhGR1NObmd0U2lZN25j?=
 =?utf-8?B?L2ZaWXRNR1JYRGJhRmRyelp1MnlnWlRHQ3MrdmFJYmdzS0VFandmQjJsRUY1?=
 =?utf-8?B?WnZzYTF4Z0dPTm4yQUpVWk51TkFjYWo2cGp0U1A4SDhsTTNRb1dXb3Z6dDBN?=
 =?utf-8?Q?kG4y6dLiTcgE8G7bsKtnIVVUF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcea56b4-f59b-4d7c-711a-08daee8d903b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 19:55:00.5679
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZZVsQFAe6pjuxfVkLFS2exwfBqDD0HwuIqU1mH59ZLrxdrflpcnv0SJCiGIn32SYkGU2HdCH5DML4f6p3fzaBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5778
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/4/23 08:53, Jonathan Corbet wrote:

> Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes:
>
>> I think I understand now what you meant by "fail more gracefully". I
>> thought you meant fail with a better/proper message given versioning
>> information or similar, but you primarily meant avoid breaking the
>> entire docs build if the Rust part fails, right?
> Both would be nice, but not breaking the docs build would be at the top
> of my list.


There's a bunch of simple workarounds we can use to keep going even if
rustdoc fails, if that is agreeable. I'd test but maybe something like:

ifeq ($(CONFIG_RUST),y)
     $(Q)$(MAKE) rustdoc || true
endif

or:

ifeq ($(CONFIG_RUST),y)
     $(Q)$(MAKE) -k rustdoc
endif

or:

ifeq ($(CONFIG_RUST),y)
     -$(Q)$(MAKE) -k rustdoc
endif

> Thanks,
>
> jon


Thanks,

Carlos