Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 Jan 2023 20:20:55 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     David Woodhouse <dwmw2@infradead.org>
Cc:     Paul Durrant <pdurrant@amazon.com>, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v6 2/2] KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info)
 sub-leaves, if present
Message-ID: <Y7Xfp3Izlc6VPEzC@google.com>
References: <20221220134053.15591-1-pdurrant@amazon.com>
 <20221220134053.15591-3-pdurrant@amazon.com>
 <Y7XWHr1kb4AHd4Lv@google.com>
 <0e58d9a6bc8bf15c23feff25ec24e9b3c26945cc.camel@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0e58d9a6bc8bf15c23feff25ec24e9b3c26945cc.camel@infradead.org>
Precedence: bulk

On Wed, Jan 04, 2023, David Woodhouse wrote:
> On Wed, 2023-01-04 at 19:40 +0000, Sean Christopherson wrote:
> > 
> > arch/x86/include/asm/xen/hypervisor.h also open codes the signature.? Rather than
> > add a KVM-specific define, what about putting in xen/cpuid.h?? (I've had a version
> > of this series sitting in my todo pile for far too long, sorry).
> 
> xen/cpuid.h is an external header imported from Xen itself so in
> general I'd prefer to avoid modifying it unless we also send the
> changes upstream.

*sigh*  Fool me once...

Can we shove it into arch/x86/include/asm/xen/hypervisor.h?  Or is including
that in KVM too confusing/ugly?