Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 04 Jan 2023 21:03:04 +0000
From:   David Woodhouse <dwmw2@infradead.org>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paul Durrant <pdurrant@amazon.com>, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v6_2/2=5D_KVM=3A_x86/xen=3A_update_Xen_C?= =?US-ASCII?Q?PUID_Leaf_4_=28tsc_info=29_sub-leaves=2C_if_present?=
User-Agent: K-9 Mail for Android
In-Reply-To: <Y7Xfp3Izlc6VPEzC@google.com>
References: <20221220134053.15591-1-pdurrant@amazon.com> <20221220134053.15591-3-pdurrant@amazon.com> <Y7XWHr1kb4AHd4Lv@google.com> <0e58d9a6bc8bf15c23feff25ec24e9b3c26945cc.camel@infradead.org> <Y7Xfp3Izlc6VPEzC@google.com>
Message-ID: <C0955015-2E2F-4D56-9611-4696553E2A2A@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 4 January 2023 20:20:55 GMT, Sean Christopherson <seanjc@google=2Ecom> =
wrote:
>On Wed, Jan 04, 2023, David Woodhouse wrote:
>> On Wed, 2023-01-04 at 19:40 +0000, Sean Christopherson wrote:
>> >=20
>> > arch/x86/include/asm/xen/hypervisor=2Eh also open codes the signature=
=2E=C2=A0 Rather than
>> > add a KVM-specific define, what about putting in xen/cpuid=2Eh?=C2=A0=
 (I've had a version
>> > of this series sitting in my todo pile for far too long, sorry)=2E
>>=20
>> xen/cpuid=2Eh is an external header imported from Xen itself so in
>> general I'd prefer to avoid modifying it unless we also send the
>> changes upstream=2E
>
>*sigh*  Fool me once=2E=2E=2E
>
>Can we shove it into arch/x86/include/asm/xen/hypervisor=2Eh?  Or is incl=
uding
>that in KVM too confusing/ugly?

Maybe, if that's our own header=2E We do include a bunch of stuff intended=
 for use by Xen guests, in arch/x86/kvm/xen=2Ec to provide Xen support=2E I=
t's only the 32-bit compat bits we define for ourselves within arch/x86/kvm=
/xen=2Eh=2E