Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp14276rwl; Wed, 4 Jan 2023 14:23:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXvqU0uei7NPLC4SD1ePFSILqmujFYVbNlQOKI7WcHokuyGxPpN5eTN0ZrjZByPPfqjDlenS X-Received: by 2002:a17:906:398f:b0:7fd:ec83:b8b9 with SMTP id h15-20020a170906398f00b007fdec83b8b9mr40877870eje.44.1672871004722; Wed, 04 Jan 2023 14:23:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672871004; cv=none; d=google.com; s=arc-20160816; b=qvyLhwH3KC6E53Cgwo2ejKLnT6aA6gxLSyaqX1MLPhqJJR+c8i7P++W5Y7GJaCaMb1 ugSKGUO9GAjULNbFgZLL8PPJETcwX5wfigjrs6xW+81LqgyfBvBVM9qxc3HNzvvAUGon N3TpNTDv7O6PavpNWX+y5ifBnGTso4Nes9fXJn6mUT551zFUW6UeFNuZJUM8QkuFkV8t 9kbSd6V4nG1psY9AP1lbWVBUiKfRYuJKqRGmHhXAENMEfrCa/LB7ecaakXnQLBE5FPew 36amrPRPulOeLPei2EcAdwNO9Kg0zDLFxI17ApsKfmjTvZ5fdjMxMkXpo3ilHwui95fP NNMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=yrCi/Pft2qxPLFB1xPtkzEGdXf77jJ8rZEUSTd/viPw=; b=E5DyE+l41SRUKd0jbfNrq31H3cK3HU64tAIoVnJU1OZ6nGY3NDwqpn+Q1Ot/TgY/zn IX5DkYnEh7nZhT72KbsJAzz/OS4n4auN0r7z6Kyj3ybfWlb4gXQnadmPd4lU4UbsMhbn U88YmC20IfCZR8ymo4IHUyiFfz2Eup1ymhe5hgYzCgs2Mxgl3/M/UCtecUXhhcGfX4so NBWH+4Bek9cKT3PrFoTJkslvEPs08Aqg9dntIDfgZD10Yk2s9jp6EegmBZFEltEuu4Dw eNGNOuJff1s/9iMtO6URJRn+hP8/3r9Gg2sk/Hsw6FNCSlTkn7O7GK7WynrwDrc3ese+ KfSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DmTDoakf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr11-20020a170906d54b00b00787ad97302asi29547970ejc.863.2023.01.04.14.23.11; Wed, 04 Jan 2023 14:23:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DmTDoakf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbjADVs7 (ORCPT + 56 others); Wed, 4 Jan 2023 16:48:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240309AbjADVsU (ORCPT ); Wed, 4 Jan 2023 16:48:20 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 953C41144F; Wed, 4 Jan 2023 13:48:19 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id d3so37303146plr.10; Wed, 04 Jan 2023 13:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=yrCi/Pft2qxPLFB1xPtkzEGdXf77jJ8rZEUSTd/viPw=; b=DmTDoakfnRqv676B+kjCUKyufhaCbCkmNiys62I7CNdzzMY12YgPxOgMSxKsZrUb1A qxmcP8kEWRZdvKxNFoz8BoN5oUdu2Ig90TdQjOzgwapkQa+rMk3Jte/oYHZX4UdDZYft rfD9/heLa+bmWdwiadsCSV5JtE2WuHKIkZqelGQuQ0dbVOltGdg/CEEnaj3BJ6GuDIKK V7mkaqGzPse11DjNHB1+ReyY6d+dCgriktFfRkxfc7L77V1L1YhC0jEfTMjsJe6frz8N m3jD7+/1umkw8ZeaaitWMt0JuA+ODfgSqbj826YcKjId/ByyFSa1Dv3XnZOJIOSG+6DV 8S1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yrCi/Pft2qxPLFB1xPtkzEGdXf77jJ8rZEUSTd/viPw=; b=K0Dp5hDvLk/imbUvGTnahtE5LTAHwOIQx4mNWKICECnHDwc6FWz2Pk8MqXFyOOmLeh /t9at7rIrWdzHIHFy2592XUUjjmU11/y1nCbwDSMYw+M7urYZyBfEJfVCNJbz283QHhk 53+OJ2c4KYuSx1RnikyuLLrf7Vl2H00c3qLN88uLU0WCmcr5t+p23DiTPJguJrYsMf4U nD4PsCC3nBW0jAT6ePk7Jhd19Zz0UT+Q9wmCh8EeTU9CHSvnjan8uSnzjnhPQ1gBeivd 2io1b2Tq84TrW3lZ3iMHumG+auTEWd5wb2W0J8Q9yUhfHCfbqJ85vitDSf3hldt98quR Wdog== X-Gm-Message-State: AFqh2krV8RGIm37Z973QNp5BHMkC+mdNlFu/AGcI2rH5LbUMG7ixuT0x 256RvRNTF89x8QLEQ6wcaPg= X-Received: by 2002:a17:902:eb8b:b0:192:fb94:a40e with SMTP id q11-20020a170902eb8b00b00192fb94a40emr880445plg.62.1672868898812; Wed, 04 Jan 2023 13:48:18 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id h9-20020a170902680900b0018b025d9a40sm3856374plk.256.2023.01.04.13.48.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 13:48:18 -0800 (PST) Sender: Tejun Heo Date: Wed, 4 Jan 2023 11:48:17 -1000 From: Tejun Heo To: Yu Kuai Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH v3 1/5] blk-iocost: check return value of match_u64() Message-ID: References: <20221226085859.2701195-1-yukuai1@huaweicloud.com> <20221226085859.2701195-2-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221226085859.2701195-2-yukuai1@huaweicloud.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 26, 2022 at 04:58:55PM +0800, Yu Kuai wrote: > From: Yu Kuai > > This patch fixs that the return value of match_u64() from ioc_qos_write() > is not checked, > > Signed-off-by: Yu Kuai Acked-by: Tejun Heo Thanks. -- tejun