Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Wed, 4 Jan 2023 12:15:06 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc:     Yann Droneaud <ydroneaud@opteya.com>,
        Josef Bacik <josef@toxicpanda.com>,
        Jens Axboe <axboe@kernel.dk>, cgroups@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-iocost: don't make all constants unsigned long long
Message-ID: <Y7X6ajqnPrtFAL0C@slm.duckdns.org>
References: <20221220201819.1497577-1-ydroneaud@opteya.com>
 <20221222135855.GC20830@blackbody.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221222135855.GC20830@blackbody.suse.cz>
Precedence: bulk

On Thu, Dec 22, 2022 at 02:58:55PM +0100, Michal Koutn? wrote:
> On Tue, Dec 20, 2022 at 09:18:19PM +0100, Yann Droneaud <ydroneaud@opteya.com> wrote:
> > +enum {
> >  	/* switch iff the conditions are met for longer than this */
> >  	AUTOP_CYCLE_NSEC	= 10LLU * NSEC_PER_SEC,
> > +};
> 
> This looks gratuitous.
> 
> What about indivudial #defines with typed literals instead of the "lazy
> splitting"?

enums are so much better for debugging and tracing. This is a gcc caused
problem where there's no other way to generate the same code between two gcc
versions without splitting the enum definitions. I'm kinda baffled that this
is what they chose to do but can't think of a better way to work around it.

Thanks.

-- 
tejun