Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp45946rwl; Wed, 4 Jan 2023 14:59:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXuMQVsaUdfh2usx/uHGgG4q19U6Ar4rxbLnI6ZKIXLOqBb2HjtCNfvq+KK+TENJQekShMCd X-Received: by 2002:a17:906:ad93:b0:7c1:100d:331a with SMTP id la19-20020a170906ad9300b007c1100d331amr43655183ejb.70.1672873178808; Wed, 04 Jan 2023 14:59:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672873178; cv=none; d=google.com; s=arc-20160816; b=EvLDONpENaA/ILcOrpmniFydXyT3Bs5+T6e7st6TtRSOOOlOgv8+OH2MZYofsl9geb EXOsL3GU5mqd3WnacQC4jptbAZtSnFUFmnEZ+CXA971/SWuR/Rm6XAY/5WBdYsEu2WiI zC7E0uA+PM0aI+absX/Ixaxso3NoAzHH/avBx4+RzUPUvp0sgBmvj9T+SCI2MkbloIHV CoIoT/U2bftCZh0po8IWjOhWETKZDuxVuC+Y3CSb5pGuZzEiMjX9NRgy60OWLgEhSvci DpUVBdrwt8YRIStbCBEPF78qUOhUrU1sn8QVGTKqkN2sU2Vv57iZu7+zOU20D/vomQyj Ny/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=B/3ppUmh4bmqybcFcsNaCu/D7XFzMdaZVgO4yNK9uS8=; b=0hjWrS08IbfPxPQrXv1c/KYoFVqBk4O1oIWBSyMxG59470ddU2bKwrG2QcZy4V+2fr 3uBzSQRSry2EEdmQq6RJJfOvyhIlwhX76k56VLQGBO87/CKgxQBjBzVysFLQXeRG/JEt Mmw+kcTRhUSvykVK5JUVYD8uNf92EjqxOTeqyLU0camIHh9GJcQDJc13jW6tmFGJ/AHy U6iN9sPE2GULVAghFdqb8Cb3yxuZvuLSpEPXt53/WqOHIirNfOXVZmBlWMY2Cvp6ALE9 xXaQEg56qOa/nlRQ6vBVZ0wLxXl4L8Y3jh5uhemXeeQWKTtZlXxby6VAiO+GY9wfgsic XGIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="m3Sl/7J9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds19-20020a170907725300b0077951929340si27503642ejc.271.2023.01.04.14.59.25; Wed, 04 Jan 2023 14:59:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="m3Sl/7J9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240673AbjADWWr (ORCPT + 56 others); Wed, 4 Jan 2023 17:22:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240697AbjADWWN (ORCPT ); Wed, 4 Jan 2023 17:22:13 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A842E3D9DF; Wed, 4 Jan 2023 14:21:56 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id c2-20020a17090a020200b00226c762ed23so1497320pjc.5; Wed, 04 Jan 2023 14:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=B/3ppUmh4bmqybcFcsNaCu/D7XFzMdaZVgO4yNK9uS8=; b=m3Sl/7J9Eg2xJBzdmZbdAe60sOL/fthI5hRvSskmpX6OHx15gV3HeMT50kSGqypuOh FCbow/o8gEu5cXqV5g56v5bzEP2U6cGZuJNvfRWaO+dLFhB5eKEX571YWfow8VgC0Vfu hCngLTiyWszq+yaoa8COFsKDVGPnTZJnNFt3olQhC/dRejvoy6Qh5WUbe+qDJ0YQ/DzM 8+p2WwcZXk2+nwhC3EcLF0Tw0EClGyI5FwPJSFUoiBXpN5qKRXPQry85sGYRy+4ez/j0 M17e5MNoHlAmPyA/fHz4Gkh689AVXyJFuGxYRuSEfNg8daWv61TBk/mopeymvSnfm4AR pKjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B/3ppUmh4bmqybcFcsNaCu/D7XFzMdaZVgO4yNK9uS8=; b=NOGG/EGjRp/1FoGA7rZMdBnuYzKU7Z3IPq/rtjUlNJtr8frDUxRjqx/fz4FWZ81y0p lML3a3J55mHOm2eFuKKg1Unp+DVayGRr7NRR4IRDhAZ0QErIu6auvEq+1PbiYzyYngjT 5t00suBPE+ihBP/rYX4gH7TW+j6ywubLxuMcgovi6omQKKhrcMXtU8/37GSJqjAQVW8o rGOmVGKsO/5UOpc/WSwbb/5TDJxO1dMKuxP+TxUlF1isomlbX0+DVdEtVvw+L9PB5W2d ieIqyfDA2VOlpto/JVBxqxWvD8rSafweTOAG85jDwT+300vUxgUNsG8cRueKymlbtiL2 DKUw== X-Gm-Message-State: AFqh2koN2xSS6R5LxEjc9cMILcb5Vfc1O00t5/p/pxmlWs8TarWpTvGa ofbPeZoJpYV/0DuV5RUAay8= X-Received: by 2002:a17:902:d4ca:b0:191:1f16:efa3 with SMTP id o10-20020a170902d4ca00b001911f16efa3mr54923459plg.65.1672870915949; Wed, 04 Jan 2023 14:21:55 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id i7-20020a17090332c700b001894881842dsm4553569plr.151.2023.01.04.14.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 14:21:55 -0800 (PST) Sender: Tejun Heo Date: Wed, 4 Jan 2023 12:21:54 -1000 From: Tejun Heo To: Daniel Vacek Cc: Waiman Long , Zefan Li , Johannes Weiner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup/cpuset: no need to explicitly init a global static variable Message-ID: References: <20221220151415.856093-1-neelx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221220151415.856093-1-neelx@redhat.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2022 at 04:14:15PM +0100, Daniel Vacek wrote: > cpuset_rwsem is a static variable. It's initialized at build time and so > there's no need for explicit runtime init leaking one percpu int. > > Signed-off-by: Daniel Vacek Applied to cgroup/for-6.2-fixes with the following description: cgroup/cpuset: no need to explicitly init a global static variable cpuset_rwsem is a static variable defined with DEFINE_STATIC_PERCPU_RWSEM(). It's initialized at build time and so there's no need for explicit runtime init leaking one percpu int. Signed-off-by: Daniel Vacek Reviewed-by: Aaron Tomlin Acked-by: Mukesh Ojha Signed-off-by: Tejun Heo Thanks. -- tejun