Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <32c122e6-d87d-307b-72c8-a0ac74c42602@acm.org>
Date:   Wed, 4 Jan 2023 14:34:11 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] scsi: ufs: core: fix devfreq deadlocks
Content-Language: en-US
To:     Avri Altman <Avri.Altman@wdc.com>,
        Johan Hovold <johan+linaro@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     Alim Akhtar <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Can Guo <quic_cang@quicinc.com>
References: <20221222102121.18682-1-johan+linaro@kernel.org>
 <85e91255-1e6f-f428-5376-08416d2107a2@acm.org>
 <DM6PR04MB657555DBC49DF54716A98B6DFCF59@DM6PR04MB6575.namprd04.prod.outlook.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <DM6PR04MB657555DBC49DF54716A98B6DFCF59@DM6PR04MB6575.namprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/3/23 00:24, Avri Altman wrote:
>   
>> On 12/22/22 02:21, Johan Hovold wrote:
>>> +     /* Enable Write Booster if we have scaled up else disable it */
>>> +     if (ufshcd_enable_wb_if_scaling_up(hba))
>>> +             ufshcd_wb_toggle(hba, scale_up);
>>
>> Hi Asutosh,
>>
>> This patch is the second complaint about the mechanism that toggles the
>> WriteBooster during clock scaling. Can this mechanism be removed entirely?
> commit 87bd05016a64 that introduced UFSHCD_CAP_WB_WITH_CLK_SCALING enables
> the platform vendors and OEMs to maintain wb toggling - should they choose so.
> Why remove it in its entirety?

Hi Avri,

I'm in favor of keeping kernel code simple :-)

UFSHCD_CAP_WB_WITH_CLK_SCALING controls whether or not clock scaling 
affects the WriteBooster depending on which host controller is in use. 
Shouldn't this depend on which UFS device is present instead of on the 
type of host controller?

Thanks,

Bart.