Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761595AbXHTTW7 (ORCPT ); Mon, 20 Aug 2007 15:22:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758470AbXHTTWt (ORCPT ); Mon, 20 Aug 2007 15:22:49 -0400 Received: from nwd2mail11.analog.com ([137.71.25.57]:42774 "EHLO nwd2mail11.analog.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbXHTTWs (ORCPT ); Mon, 20 Aug 2007 15:22:48 -0400 X-IronPort-AV: i="4.19,285,1183348800"; d="scan'208"; a="37604301:sNHT50877911" From: Robin Getz Organization: Blackfin uClinux org To: "Andrew Morton" , torvalds@linux-foundation.org Subject: Re: [PATCH 1/1] ensure we don't use bootconsoles after init has been released Date: Mon, 20 Aug 2007 15:22:47 -0400 User-Agent: KMail/1.9.5 Cc: "Paul Mundt" , "Mike Frysinger" , linux-kernel@vger.kernel.org, "Gerd Hoffmann" References: <200708192246.05783.rgetz@blackfin.uclinux.org> <8bd0f97a0708192011m1b957e57je313850a255dcac7@mail.gmail.com> <20070820033143.GA4918@linux-sh.org> In-Reply-To: <20070820033143.GA4918@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708201522.47591.rgetz@blackfin.uclinux.org> X-OriginalArrivalTime: 20 Aug 2007 19:22:42.0962 (UTC) FILETIME=[7B137720:01C7E35F] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1688 Lines: 49 Try #4... (sorry) From: Robin Getz This is a followup to the cleanups for earlyprintk patch from Gerd Hoffmann http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=69331af79cf29e26d1231152a172a1a10c2df511 This ensures that a bootconsole is unregistered if it is not replaced. The current implementation spews garbage out the bootconsole in this case, since the bootconsole structure is normally in the init section, and is freed, but still used. Signed-off-by: Robin Getz CC: Gerd Hoffmann CC: Paul Mundt CC: Mike Frysinger --- kernel/printk.c | 11 +++++++++++ 1 file changed, 11 insertions(+) Index: linux-2.6.x/kernel/printk.c =================================================================== --- linux-2.6.x/kernel/printk.c (revision 3583) +++ linux-2.6.x/kernel/printk.c (working copy) @@ -1104,6 +1104,17 @@ } EXPORT_SYMBOL(unregister_console); +static int __init disable_boot_consoles(void) +{ + if (console_drivers->flags & CON_BOOT) { + printk(KERN_INFO "turn off boot console %s%d\n", + console_drivers->name, console_drivers->index); + return unregister_console(console_drivers); + } + return 0; +} +late_initcall(disable_boot_consoles); + /** * tty_write_message - write a message to a certain tty, not just the console. * @tty: the destination tty_struct - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/