Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <384d8a08-ec31-dceb-bb4c-f785a6418fbd@intel.com>
Date:   Wed, 4 Jan 2023 16:29:20 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v10 09/13] x86/resctrl: Add interface to read
 mbm_total_bytes_config
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20221222233127.910538-1-babu.moger@amd.com>
 <20221222233127.910538-10-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20221222233127.910538-10-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3Zrb0xUNWFwTTQ0ckhNMzlGRUxWQ0E4UEdvVUU2M3pEUTRJaVV4R0NYQzdZ?=
 =?utf-8?B?cjJUZEVpeUxvbUsxeUlYVGl4VHpXRkNpdDZNanhKQ1VUaXQwdU9YNVRZM0M1?=
 =?utf-8?B?eS9LRDVrRkxvemFmQkNNSklhbDgvbGNQMGcvNm5CcjlIL2czaEtwcHpmTCsx?=
 =?utf-8?B?dVBxcWxvSitxdGVpRlZZWHFEQURHZm5WK0kvMTJSWlVxR0FQM1kraCt3RUdj?=
 =?utf-8?B?eHlMbFJZUHlvTCthODd5NnVwQWZ3SGZEd2VVSFhuZnUrQ0pXcEQvQWNYOEFW?=
 =?utf-8?B?Z2UwU290UnVJTm1Fb3A0WUt0U1oxMDVyeUx1NmgxZng2ZVVDNUQybFVGdk44?=
 =?utf-8?B?YVdaOFZkMFZpRzdYR01odC9KMmRiaHcrY0c5bkthamdkQTdVVTNZL3NuajM3?=
 =?utf-8?B?Sjh6TUVLb3BGdlJKOFdjRlJRdTJBdWVjVW9wTkNUbUY4Yy9NV1UySHVLT0NU?=
 =?utf-8?B?VlNmbFhJTzhMUituTWpyRW5KYUxYUFVTeWRPUFlLSDNDUlBCY1UxQkRESHpq?=
 =?utf-8?B?d1p2UEFqVCtNTVgrVE5KcVhVbEtpSHBmaVdKZXF1eVhQbFd5T1NMakdGR2E3?=
 =?utf-8?B?TE9VY3dnK2ZJMGdmZDBaSFYyVWV0UnNVK0pnMDQzd2p5Vi9FdXltZUZoaGlO?=
 =?utf-8?B?c2lxcjFIVmczWlB2SEoyVTRKQklCZUlRVGt1N0JaVEkrU0tvNlJVZUpNcm5k?=
 =?utf-8?B?TEcwam5LTnAzQlJsaXNUQkYxeXB1VFhsOGI4WFlGUVZCdVlIQjV5OUR5Qjly?=
 =?utf-8?B?eGxxcTRRYmVhOWFZM0xEb2YzZHBta2hRUGtNajVCN2FlZzNZdTJqVzVqRUlD?=
 =?utf-8?B?MmFmdTVxZFhSV2ZuVHFYVXZxWFNvWWdibEpqTjJPNlJJMklYUHNKejh0N0lq?=
 =?utf-8?B?Z0QvcDRRbWRxSitGblByaHhEN0w3WStXRjdOc2xXQVVFeGg4SlNPd3JIaldQ?=
 =?utf-8?B?MlRqOHpoVEdvb2w2QndjYUhYd3RBakdBb1ZzZzBpS2JRdGt0ZnhqQlhVWTJt?=
 =?utf-8?B?TUhjcldMOFJVUy9COWNHK1BkbVI5cXBZNUFMS0FkTFU3T1Y1dVl4Yi9mYnZ1?=
 =?utf-8?B?Mk5SM21xMXYrTEgzUld1dDlFRk95SHFWaDZjS2lRZXRjSm1DK1pMK2lWdWhs?=
 =?utf-8?B?QUdRcTlmYm5zb3JRNCs0VkVLV1I5WDR4T3d5T21nY0kvd1lYMzAyeGh1MEt6?=
 =?utf-8?B?bEZzM0p6UUNqNGhjUXpoZ1grd3RWSGMzemwrTVovZHhGTWhRS2RSQXhndWg1?=
 =?utf-8?B?UEFOc0FOaHhLOWNnM3NCMjJxLy83akhvYmdKWll6TGNxM0dOYUdyRURWVVJo?=
 =?utf-8?B?bGdFSW1pYWZnUFl0T3NDTEZyNEdIanVYNXFRTDIxU3lENmZKZGNLRGR0NW4y?=
 =?utf-8?B?ekhPL2svaDBCQ2pNSmZFR1FoWGppRTRKV3FPdDdLL1JUT2l4QVNLRDNMNHhD?=
 =?utf-8?B?MlBTYUdmZDYvcWFQT2J3Q3h3dXdqODVMblMzdUkvVi9QUGU5OFNuZTBndEgr?=
 =?utf-8?B?REFvNi81WG80R3VuWEcxTGRLVUppSE1jMjhxQzRsTmVsYVpIR09Oc0hkZzlL?=
 =?utf-8?B?Z0pGZXhRTFRNYnZLY1lzK3dVVERsVEtKMERLR0M3OHM5Uk11TStwbDkwZUhL?=
 =?utf-8?B?S21nUjc1RlNpUVJNVzdnRVpaU2tFWElGMEVQWVdMYmFlY3ZodUd3YWo4ZUd1?=
 =?utf-8?B?NnVna3B1MzRTQmY4R0xtdm1wZGRTMWEydDhyNy8rMjdYaEdIMVB1ZGZkUWFR?=
 =?utf-8?B?RTNsam9nbFUvNG9PTVhENVhWK0Ywa1o5aW1JSDdoUDA0VjY5c1hMUldoWDgv?=
 =?utf-8?B?RTd4d1hyUmlPcVBabFZvS256dUdFZXl1MkNtUTc2VUd1YTRTTmlMYUNveWE2?=
 =?utf-8?B?WS81TFRhUmhVZzNaK2NyK1hiOS9pT1k4aU4xTHMvQmlUUjR5YXFpNGg5SUxr?=
 =?utf-8?B?dXFmS1NzVlNZTkk1cWNTNy9VbFBmS21yd3diakczd3MrM2t4b0ZTSHNvanBp?=
 =?utf-8?B?SnFJbmRqZTQ3VE9SMURhRXJ2Tzdrb0UxdUJyZ0ZIbnlNdWZHN3BBSEtHWlNX?=
 =?utf-8?B?b0dzM0dUZ3lyOUM3azZPbCtZdzdSZzZyckxXRUhYSUF0TW5aWWpGWmtENEIy?=
 =?utf-8?B?ZU9PWFF5MnZONUhtQlp0Y0FkQ1RLNE5EdnJ3dGNlSVcvemFsREZqNDBHZUty?=
 =?utf-8?B?THc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 936f5937-5524-493d-aead-08daeeb3e530
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 00:29:24.1044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oIMY+YX7lia4K/W34mp7P3v8QJqoS9Vo6T2Q9DspJ3jd2OFOIrkmLPZPmVJC063Y3AjLhrsnEP0QhiDM0k1ToSqBylbs79ylxkubYEWnGVU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7507
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 12/22/2022 3:31 PM, Babu Moger wrote:
> The event configuration can be viewed by the user by reading the
> configuration file /sys/fs/resctrl/info/L3_MON/mbm_total_bytes_config.
> The event configuration settings are domain specific and will affect all
> the CPUs in the domain.
> 
> Following are the types of events supported:
> ====  ===========================================================
> Bits   Description
> ====  ===========================================================
> 6      Dirty Victims from the QOS domain to all types of memory
> 5      Reads to slow memory in the non-local NUMA domain
> 4      Reads to slow memory in the local NUMA domain
> 3      Non-temporal writes to non-local NUMA domain
> 2      Non-temporal writes to local NUMA domain
> 1      Reads to memory in the non-local NUMA domain
> 0      Reads to memory in the local NUMA domain
> ====  ===========================================================
> 
> By default, the mbm_total_bytes_config is set to 0x7f to count all the
> event types.
> 
> For example:
>     $cat /sys/fs/resctrl/info/L3_MON/mbm_total_bytes_config
>     0=0x7f;1=0x7f;2=0x7f;3=0x7f
> 
>     In this case, the event mbm_total_bytes is configured with 0x7f on
>     domains 0 to 3.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>

...

> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -30,6 +30,29 @@
>   */
>  #define MBM_CNTR_WIDTH_OFFSET_MAX (62 - MBM_CNTR_WIDTH_BASE)
>  
> +/* Reads to Local DRAM Memory */
> +#define READS_TO_LOCAL_MEM		BIT(0)
> +
> +/* Reads to Remote DRAM Memory */
> +#define READS_TO_REMOTE_MEM		BIT(1)
> +
> +/* Non-Temporal Writes to Local Memory */
> +#define NON_TEMP_WRITE_TO_LOCAL_MEM	BIT(2)
> +
> +/* Non-Temporal Writes to Remote Memory */
> +#define NON_TEMP_WRITE_TO_REMOTE_MEM	BIT(3)
> +
> +/* Reads to Local Memory the system identifies as "Slow Memory" */
> +#define READS_TO_LOCAL_S_MEM		BIT(4)
> +
> +/* Reads to Remote Memory the system identifies as "Slow Memory" */
> +#define READS_TO_REMOTE_S_MEM		BIT(5)
> +
> +/* Dirty Victims to All Types of Memory */
> +#define  DIRTY_VICTIMS_TO_ALL_MEM	BIT(6)

Some stray white space above.

> +
> +/* Max event bits supported */
> +#define MAX_EVT_CONFIG_BITS		GENMASK(6, 0)
>  
>  struct rdt_fs_context {
>  	struct kernfs_fs_context	kfc;

Please remove stray white space. With that:

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette