Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6597dab2-db66-e4c1-e8e2-b18b2a0bc9e3@intel.com>
Date:   Wed, 4 Jan 2023 16:28:50 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v10 07/13] x86/resctrl: Add __init attribute to
 rdt_get_mon_l3_config()
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20221222233127.910538-1-babu.moger@amd.com>
 <20221222233127.910538-8-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20221222233127.910538-8-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3hhWElrQWc4Yko4dXh4TzVCYXUzWFAxd002MjU3Q2t2YmhvM0JRSDFVY25W?=
 =?utf-8?B?SzArY0g3M1pFRXFHeUR6eXBjZE9PVXZqeU03dkhJOWN6ZDdodzNPTTd3UTBj?=
 =?utf-8?B?aFFpQ3hQY3VYODJmUlJvNmdRemNnOWlVZFdwUVBXZTg1WVRScTZha0dSOWxX?=
 =?utf-8?B?WkltTE1MTXU1cDZITm45b3lXMXR0V1pXOE90a1doTVFQd2lDTmlNQlpSbklm?=
 =?utf-8?B?SVZwVWh3ZlRKVzFHaGRPMk04Z0M0UnlEWitrWk9EdE5QV2thWEdwVWNldEdI?=
 =?utf-8?B?MzFRUEpleDlNck82RkJUMXlQdjNaKzNiejFsUkZyU3JhL092eDFoY3I0dkhK?=
 =?utf-8?B?Q3l6T202T0RsSTRtVmV5UkdjRVFXOEwvZGR3aU5ZZHJXd2lZTVBzUm9WRkhj?=
 =?utf-8?B?VnRRalNDcHo2ZXVlQTkzSVM2RWZ3ZE5nNmp0ZmNDTzhPOTAwemVBRzR6anpj?=
 =?utf-8?B?eUY0OUZiNlJJbm5IR3dMNUt4SER5Zld4U3ZqL1FLa2VKY3pHd29KM3BaWTZh?=
 =?utf-8?B?Ris1eERhdExtclNtOUZTTVd3Z1IzOFdGaEJLam1UdVh4bzVzNUtwZlRveTdP?=
 =?utf-8?B?YjZQMnBod1g4VU5od2g1SjAzOHpMT1NvSzhLZ21EUW1zZmk1TWIwTUdVZ1RP?=
 =?utf-8?B?clZNbVZ3alJMb1FDOFdENWE4Z3VPdGZIZmRvRWlxNDhMZGM4OWQ1Z0dwQlVW?=
 =?utf-8?B?MVZKOGM2bEI5aHJkVStxY0x4N1ZvTFozMTJkYkhYanBnMzZnbDhUUEtQTFN1?=
 =?utf-8?B?SEhsbkt5Qk9lWmhuOXUwTGFRTUdvWGwyWUlJRWdmMTIwMXVtQzNrZUtpbU4x?=
 =?utf-8?B?bnRpcll3c2ttV3VZMGthZnRzN3BZZnlQTHZhZEthaVIvVEx1djV1b1M3MXZ0?=
 =?utf-8?B?bGRsMFE2YUc3cTdacEhMWHVNMHN2Tld1SjYyME5Rb3M1YjNUYmNWcnJubTRP?=
 =?utf-8?B?eVR4WVVaMkRKbStFWHllRXFZWTV6YXVkRmNyTTZsN3ErcnpkZWVXNEhubHhy?=
 =?utf-8?B?L0wrS1ZCbTlvaENrbXZDT3R4U3lUNHhybWVIRTVsNkt1MjFNZjFaRnk2eEw0?=
 =?utf-8?B?SzVCVVhqOFBTMEtRSTlXTU83ZmdkcXR6R2VTQnp0YVNSRElUcG92Umx3UGlY?=
 =?utf-8?B?TURHM3ZDTGFTMHpqY0p5WS9McllicHFPOGZoN3lzRkJBZm54WmxOQkVyL1VO?=
 =?utf-8?B?akExaEhPbGp3OG9VZk55NlBaV0kxUnYyWFhmSFBHbEpla0dINGNNMlRMaXJj?=
 =?utf-8?B?MlBzMWhHK3Fhc0RQazhDN3FoZ3Z5cEN3a2hjbmRUeGU5N0U5NE1yM0VJanlo?=
 =?utf-8?B?VjREOTRURjZ0SllhcytQdzZTN0dGRko4OGZHTjhvcG84eWJ6eURrUDdPZWpv?=
 =?utf-8?B?RjBOUXZVVGZudDBvYTNmbElGbjRXZkIzWFVsbXdqNVl4by9BdVZtaWYrTkdE?=
 =?utf-8?B?TGVmb2U5a0Fsa1NqRFhkbVBZU04wQXF3VWFSMzJja0tRU3FqL1pieTVMdXB4?=
 =?utf-8?B?elpwblh6em1tclJZZzdkM0ZZMnE2SEFDMnNqUGxtM3hLSzRPUms2QUlWbWRh?=
 =?utf-8?B?S0cwZVlFRzBSUVovS0hxVEoxdHBrb0lFa09ZT01JWW04L0ZtVkVaL09jZEQ5?=
 =?utf-8?B?L1hTWG81clFRZDMzSEV3UmtRMlhSOWlhQlJVYTNNTTQ0UmlJUVFiRGlTaENX?=
 =?utf-8?B?NTREci90TERING96Ty9GVlBiSlJFbnNGVndQcTRWSU1DMFJGTFlWYUxQd0xy?=
 =?utf-8?B?TTNiY29hMUorQXJZS0hPWDVKRTVMRkpwRTFJVmR6SnpZTDEyTDdaMXFac1B6?=
 =?utf-8?B?OEtua2MycDR4eDZVREg0NUo3a2ZlaTdrUlNhMHR2V1pMWUpJRVU0NHVXbHdQ?=
 =?utf-8?B?UzFIQTJkSEQ1blZBSStYZ0RGbGRMMVdNL3M4WTdsSUZuTWFZYVpCcEdGaGRw?=
 =?utf-8?B?cXkxbVpQUzA2MzFBOWIwb0o5dmJnSi9WL3BuRW5NaFBiY0hNcXZUdHVJTW5J?=
 =?utf-8?B?UjkxZk1WLzVQazJHNE96cjMreDRnSzl1UU1aWDFBUWhIUjdGM1NOUlNZalVK?=
 =?utf-8?B?OStzY1dscHV6SVhYTFZZdUYzbXZFM1NYbFdmbUxnMTNUSE1jU1dacnF1SHdW?=
 =?utf-8?B?ejBpbCtMcmw5OWI1V3p2Z3I2RHNtZTNXNmFvN1dwdVpBYVJGVUtxbnF4VG5I?=
 =?utf-8?B?OXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 951b1476-83b3-4fb3-fb3f-08daeeb3d339
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 00:28:53.8726
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fQNKJRMpFb9oQoD8+HmjNI1Pa5FCGYplqjXeoBzIYfKgnXLVxCHckdTqKCa0CxyAfLJtiR6mWdvH2yAasEiEPPf2N6hZNa9htEZ90/18PcI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7507
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 12/22/2022 3:31 PM, Babu Moger wrote:
> In an upcoming change rdt_get_mon_l3_config() needs to call
> rdt_cpu_has() to query the monitor related features. It cannot be
> called right now because rdt_cpu_has() has the __init attribute but
> rdt_get_mon_l3_config() doesn't.
> 
> Add the __init attribute to rdt_get_mon_l3_config() that is only called
> by get_rdt_mon_resources() that already has the __init attribute. Also
> make rdt_cpu_has() available to by rdt_get_mon_l3_config() via
> the internal header file.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette