Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5760f7f-5985-1962-1c89-f32eb743985c@oracle.com>
Date:   Wed, 4 Jan 2023 16:57:10 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [RFC PATCH v2 12/47] hugetlb: add hugetlb_hgm_walk and
 hugetlb_walk_step
To:     James Houghton <jthoughton@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>
Cc:     David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-13-jthoughton@google.com>
Content-Language: en-US
From:   Jane Chu <jane.chu@oracle.com>
In-Reply-To: <20221021163703.3218176-13-jthoughton@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlRKMmEzUUl5TVVTekVaYmhEUjQ3bjJjZjJSWGFEY2kyRXMyWUNnR21yTjdu?=
 =?utf-8?B?Ym9RSTE1Vm9nM2xMYTNSL3NVMUdqUm8raWhaMnRxbXAwSzBIS09MVmozZmY5?=
 =?utf-8?B?aXVQcTFqYW42U3ZHejhIc3hLSVJrMEcwWXFodERMY2gxLzZvUnplVW94amxN?=
 =?utf-8?B?dnJKSDZEakZLL2d2MTJ3N20vMmpqNHErT0g0QzJENUVhbThJTkE5TzZpVnQ5?=
 =?utf-8?B?Wmx0SHRnV0dtQWlzUTB5MTA1dDVIOHBEK2htckRmSFlFaUM0c1V3V0xicEhi?=
 =?utf-8?B?YitwMXA4Sk5ZWVkxOFlNS1RpdUlabGJiMWFseEhaSHIvN3AwUFBSMzdJRkxG?=
 =?utf-8?B?MTJxTGJtWmx1emFjdGE2WVBEMDJlVWpOVkdHTTgxTzlDcU5KRVR0blp6bDA5?=
 =?utf-8?B?Y1RpRVZHZENTb1VEaWFuTmx5RHE1ekhQWnBhNzBIemU1V3VtaUY4Y1dnTG5K?=
 =?utf-8?B?OUtpMWxhREN6SFJqQVZ1MXkreG9WSHl2MlhiejBBWUl0VWVBd0I3ZTZLV0Ix?=
 =?utf-8?B?OWhOUytsVldXeUdNVzd0aFNVM3dkZTRWMUFvS2RtNEU3Y3VaYnJWR2x5QXVP?=
 =?utf-8?B?aXpuTlFaU0h6QTVONkUzblZoai9XYk1kZ3loTEhBdmROK2o3S2JTVzNFQ3l4?=
 =?utf-8?B?UHhaVW9OTlpmQlRKajN1QmUvM21mWnNLQUlqWWJqcWZ5a1h4ZUlQc3NnQ0lx?=
 =?utf-8?B?bnNZS2o2U3ZSUFhUaC92Rlk5QU9FeWhWbS8xWGRKOUZHZkowdWtLYUxuZ092?=
 =?utf-8?B?YlZwMHNPQUdXNkNKM1ZLSmN0NkdLbjlyK29iZDlYMHd2cmM1eGgvdWNlZW9Z?=
 =?utf-8?B?Y0JhS2duakZ2OVFrSlhLZkUwQWg0d1BCR3FTQzdoWGpURll0Sy9pZHRPRVFz?=
 =?utf-8?B?TDdzOWdhODVHN1RmWno3WnVVYnlyN1dFMXhTdXNCaTVBMXNUUjRPejI4aWN2?=
 =?utf-8?B?dnBKWnJtaXRPYldYYVBCUzFJak1vMEdxUTVGVEtocUt4T2lrakNQdGZURUlm?=
 =?utf-8?B?VW1lRE5aVm1nVmVQaTU0QXl2SElnR0VZVDlvTjQzU0lPVGhwb3FYTHVZaFVr?=
 =?utf-8?B?VVRDb2JVZWpybTFOajhqVURqTEc2L0VEdEdaTkdiM2toQlVsY0FBa1hTU1p1?=
 =?utf-8?B?M2syYkh0UGVYZ3ZkRGE2c3ZxeHZnNlZQaTVzL0pMUEY4eWRZNGxkZkIwM3ND?=
 =?utf-8?B?YklBRklpQlpmMllrWmJONERyNGJYb1pIa2x6cHAwMUVPc1pNRDFId25uSlh0?=
 =?utf-8?B?UmJwOGYzclhmakV0ZXhWNkpsTXhBSWl5VzMzSXBjL3ZTT0d2SHZ5a2c4U1NE?=
 =?utf-8?B?ZGV3bVA2am9IZE5DL1RUNE5oeUtXL3BjZ3dOeThJUUtZSHpZWlBwNWtIUlBy?=
 =?utf-8?B?eTV4S3g0WVhyTW1QQ2NxTXlTb1hkbTRSbkNBck9zeEpNZXBQK3U0V1haSHRz?=
 =?utf-8?B?SmtBQk1nZFdvL2RzNjVoSzBUVDZ1YVlNc2oyc2ZQUHF5TlBXRkFSU0ZIZVcw?=
 =?utf-8?B?ZUhrVUh6TjJIWm1TbSswcXBFQjZOcnoxVUg0eU1jZjZQdlBMYVM1RDZXcmE1?=
 =?utf-8?B?QkprckdLdDY0Ym14dm9HK0M4c1dkeDRva0FQVHg0QTRlRDBnNVNpRElNWTBh?=
 =?utf-8?B?WEliQmY4ems3ZVBWVzgxMU9hTTRuNEdTRndEcDl3QjArV21ENG5mRGlDOWZR?=
 =?utf-8?B?OEg0VGV3OWhCeFVPa0xlM1lmUnJaTVpiaFROQU03dGh1bVpTbEMzKzZCb2M4?=
 =?utf-8?B?ZkNBY09CbWwwckZEbnpsaVIyMHBTWUxIbUF1YXYrUnBMaTR3VGtESGtoY2xn?=
 =?utf-8?B?WmZYMUxMVlF2WFhDUVl5MFIzeWo2VDlnRW1BMWZZWWl5NkNnQWhTRmNzVUVi?=
 =?utf-8?B?TWlOcE9WckhMaFMxOXFSVExGdjFFVW90UUQzWnAyYUJpUkJVbmMxbEJkMWwx?=
 =?utf-8?B?TnFHcnVWMWkyeFBmbmE4KzBkQ2NPdmREOW9zVjdnenc2TjRaeDRvcGFmYlRM?=
 =?utf-8?B?YVhXZllveGZpeW5NaHgra2pCeG5VdCtEMEVFbkRreHh2Qm00dU15MmFHUVMr?=
 =?utf-8?B?RTA2Q21QUUJRRlRrMENMY203UGRVeVFtamZNVnkvd2xPYklCM3ExNGtXYkd4?=
 =?utf-8?Q?UyEN74ch5u6L2GipWZsTe1qzl?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RDVrRXVjZHo2YW1jUU5tdnk2OGlCc3lQQnIrM1pYdW1YeHNoVndtQlBaVVU5?=
 =?utf-8?B?dndBbnBPUDI3am94YWE0NHhHNy9hNWVLblIzTXpkNkhQWDJzVmlMWkNUVmoy?=
 =?utf-8?B?eHZ4V0FTT0Y1ZElSRnNPTzlVYVhybnNGR2FwNHFKeWloM3kza3dXYzYxc1dJ?=
 =?utf-8?B?LytnWFFjcnZwbnRlWU1QRkZob1B5UE8xRjVHT0M1ZjRsZGRDNVJjcEpZVUp3?=
 =?utf-8?B?aTJiUkRneUs2dnNWaUpySG0vN05xSmZVNDZNWFZlRE5tVTk5ZGZaMGVNVzg0?=
 =?utf-8?B?MUFxRVJKQmN0RFpBdFJYSHlxVDViSFFnOWJnNjFKWmtqRVVDdFFLMnNmbkU3?=
 =?utf-8?B?U1NEL2lXM2JRdXltMGc3RnVIeGtNc3Zhajk1b28rSjdOb25hTkFCSVU0bWxW?=
 =?utf-8?B?M0FIMUxTeGl1dmlvQ3FjNEhKaXFKdTRjVzltWEVXNEphRzBaSVUrNmdBcERn?=
 =?utf-8?B?di9IeHBMWTFza0IxK3RQTzFjVElQazE5S0RMb0FZZnRYaktxaS8vVklzY3R3?=
 =?utf-8?B?MXdFcjFkNG9SZ2s3UzFPNSt3RlhaNVpYTys4Z0JhOEl2UTZ5M3BTN2tqTGpt?=
 =?utf-8?B?Q0V4MzRqNStLS251VEx1Q0hKeHE2eDloY1pPN0pkQWZBd0xMYmVrNUsxL1pL?=
 =?utf-8?B?d0dKNkI4WFhhWG5YQ1grUzVETlExZkZjcklBMDRGdU0vcmdvb0orOEEzakhs?=
 =?utf-8?B?NUtPSGxxY1h5eGhnWkNMSk85MGlZbnRMUjAzUjM1bU5JWVoyekRud1NVK3hT?=
 =?utf-8?B?cFhLWkxkQ0RXa1ErT3JmRzUza0YzNHRHRTJ1VGdjOHB1NVoxcEkzUkxJRjBC?=
 =?utf-8?B?bG5CZFRtOTdPY3BVY1JJYVU1ZnUzRnRCTVRvSHdhaE5ZVmVYNXdQMXhWMitq?=
 =?utf-8?B?YVA1Q0VGbnE4SDRlbVgrei9KaTVSVHFFMjJ6UGNNK0hMSjVqbU56aEdRSWlM?=
 =?utf-8?B?YkZTWi9LT2lxZktTUTRuTjB5R0NqUGJjejVwNHA1VDJjRWluZTRmeWFvWnBq?=
 =?utf-8?B?c2xUVFhsK05UTTloaFNsNWJtRkswSUJXSFQ3RmVhYVR4azIxMFBKUGU4VllI?=
 =?utf-8?B?dnlDVWZRMXY1bFZvTjd3SXJrL1lKWkZJSnlZZHpqbFJMS2xzeFhGR1JIT096?=
 =?utf-8?B?S2hhNnppTENkWVNFTVRvVWgycGFENHpGbW4wYk0vbVhNWXVYaXczdHFPQUFO?=
 =?utf-8?B?NmZROURMYllzeXpSSEFpOUpaZnZRNThCL3ZKcWxReFVOdmNTRW1RRDN6Q0lZ?=
 =?utf-8?B?aVRsa21WS0YwR3VTZGtNUjVZcEttOWYrVmlCQ0ZybkxTQlNCcm5NUk9Yelc2?=
 =?utf-8?B?QTJnSzROZW5HMzkvVENpYkJuSXBwYk1VaGs1MVFWOE56SE54SXhJeGlHVjJx?=
 =?utf-8?B?NnB6L0xUT0MrWUYycnhBZlA5K0FCYmdwMDZJdXZKTzBXbGZZaEczQThvcWg0?=
 =?utf-8?B?a2lzYTBxWDZ2Vk1QWHdzcmRnM3pmRW1KaExOR3pueFNhZUpINzdUWkk3bVhj?=
 =?utf-8?B?RlBFOWI4Q2cySzY3N1dCT3BUdFg4SThmTkdNVVhBVTZjYXRuN2dPMGhPTnV1?=
 =?utf-8?B?eWpLY1BRUXJTZ1NXOFNadUoyRHhsSEhFL0tDQUdGUkFXcWFIZjVBaE9Sa2ov?=
 =?utf-8?B?QjRtR0dYTkNTbmI2SHNuZERtQmJNRHpoemRXVENsbkEyWWcrWms0aitZZkY5?=
 =?utf-8?B?eEUyL2FRd0cyRWVxTE1PM0JQUVJuUmZOaENXbnhodjRuakUvUytJUzh0cEJm?=
 =?utf-8?Q?VN9nLEjQsFiTN9EecUek/n1NjPLziVP/wpBD3wg?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85940dde-0c1e-406f-2acd-08daeeb7c9c6
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 00:57:16.0791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zKhkl2DLkAlNmZjc35sXyT4rL0C1UKL68KrL629aY5UPprBDNEas0VkEeetjY+8zhpd3Uvdq0dst563PHvC7sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4194
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-04_07,2023-01-04_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0
 mlxlogscore=999 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301050005
X-Proofpoint-GUID: 9UBWIi12el78TrsQkXeOKplCT0FfzPPZ
X-Proofpoint-ORIG-GUID: 9UBWIi12el78TrsQkXeOKplCT0FfzPPZ
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> + * @stop_at_none determines what we do when we encounter an empty PTE. If true,
> + * we return that PTE. If false and @sz is less than the current PTE's size,
> + * we make that PTE point to the next level down, going until @sz is the same
> + * as our current PTE.
[..]
> +int hugetlb_hgm_walk(struct mm_struct *mm, struct vm_area_struct *vma,
> +		     struct hugetlb_pte *hpte, unsigned long addr,
> +		     unsigned long sz, bool stop_at_none)
> +{
[..]
> +	while (hugetlb_pte_size(hpte) > sz && !ret) {
> +		pte = huge_ptep_get(hpte->ptep);
> +		if (!pte_present(pte)) {
> +			if (stop_at_none)
> +				return 0;
> +			if (unlikely(!huge_pte_none(pte)))
> +				return -EEXIST;

If 'stop_at_none' means settling down on the just encountered empty PTE,
should the above two "if" clauses switch order?  I thought Peter has
raised this question too, but I'm not seeing a response.

Regards,
-jane


> +		} else if (hugetlb_pte_present_leaf(hpte, pte))
> +			return 0;
> +		ret = hugetlb_walk_step(mm, hpte, addr, sz);
> +	}
> +
> +	return ret;
> +}
> +