Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp209070rwl; Wed, 4 Jan 2023 17:55:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXvhFS6uWra9QBgc8XcOtWO9bjNVuYRt3s+eOmKcjjPd2C92WY1RxajbhqAGtodYfE4JkDr9 X-Received: by 2002:a05:6a00:1906:b0:580:9d4a:4e1c with SMTP id y6-20020a056a00190600b005809d4a4e1cmr53716846pfi.3.1672883722881; Wed, 04 Jan 2023 17:55:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672883722; cv=none; d=google.com; s=arc-20160816; b=Depr1ChS8JxosQHpkA6HdRggNwydNEj5PVIGaBQcBaohBZU7/mbvdMfsAVSYE1CXOF QDpxFtBp5nApf3cyclcmBIt5GJIhRxqA82IkzDKBXqWf2NRWWMicYkBVIhs8tLa7av3k anS5nGox4xd38VnDzbaK7zNc1MmCIiEEPYc6C4zcYmkl9TUxdeO1IVnizqW0U3yDQ8Pz UGWNwLjtPqqjpIE8pAFKbuX8EK+34CP4z5JFdsMtmugJ1OM2bOCguHNk3SmA+uuJrlEP Iz5pvSDz0n7KW75FwDEtCqEBbNwfTpYcL9Ps970jv/znM7r9ZF7+ko3/dhGPavxlmkv2 GMtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=iL5xB5HfG9cFdqqw1T7Vg0Wv3W0CVfKo+qbv9RQt2Tk=; b=jILN0bQUSU3TRkZtp/zBToPShNrDxvsJlbUPiumK/dGF4tXTUfVcZv/xf2j0dThEP2 RYSLL2DoXGp9XJ83Nx+szvhWY1wcbamY1TPZWVkKz5F/zMJCh1mKzf8j0FujMaFW//7e tLFcmvRer0ySSxFFaNqHMkG3YIzXemWQNzf+Jc69NPOt5VRHURz6W6kijxV1fb6SWpQh eeB/sWVNKg7vpY81PqJhjsV4/7qpHKJ8+gUk++SthVoC3vg56+h7TqAMHFjnet2nV/zA GDr0KkcCMmwWpEj8izt17YAC7yTo6sF2BxlotGdMCfbpJBUmqEFzBfHuPaVTRdKpGEd3 v1GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=dTardMPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z12-20020a056a00240c00b0057d34473bc6si37839587pfh.147.2023.01.04.17.55.15; Wed, 04 Jan 2023 17:55:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=dTardMPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229605AbjAEBjE (ORCPT + 56 others); Wed, 4 Jan 2023 20:39:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjAEBjC (ORCPT ); Wed, 4 Jan 2023 20:39:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4162A2009; Wed, 4 Jan 2023 17:39:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ECF33B81983; Thu, 5 Jan 2023 01:38:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97678C433EF; Thu, 5 Jan 2023 01:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1672882737; bh=Hba6ddPoEuFTAiIDFk8w8K0/JAQAQv7vkxWx0br15B0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dTardMPjP6dU0Nt3lM/chNUUy2Ia0ipFBa82JnL+BAQDimpfCGwbvTkIwTmXwc2OJ OIWCs0xbqjRK5ZtRyWd9GW4oW0BZYDOHuNPOMxr7n1d0/1tsJ/H++ZkCi9UR8H5Ss9 gHXUcp4AeRhRk67n6rU7CEpSu0SZtzc/OtUcJoeA= Date: Wed, 4 Jan 2023 17:38:55 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: hughd@google.com, hannes@cmpxchg.org, david@redhat.com, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@Oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs Message-Id: <20230104173855.48e8734a25c08d7d7587d508@linux-foundation.org> In-Reply-To: <20230105000241.1450843-1-surenb@google.com> References: <20230105000241.1450843-1-surenb@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan wrote: > free_anon_vma_name() is missing a check for anonymous shmem VMA which > leads to a memory leak due to refcount not being dropped. Fix this by > calling anon_vma_name_put() unconditionally. It will free vma->anon_name > whenever it's non-NULL. > > Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") A cc:stable is appropriate here, yes?