Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 Jan 2023 19:16:18 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
CC:     Bjorn Helgaas <bhelgaas@google.com>,
        Lukas Wunner <lukas@wunner.de>, <linux-pci@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH V4 1/9] PCI/CXL: Export native CXL error reporting control
Message-ID: <Y7ZBAm0wbh3Cg2UR@iweiny-mobl>
References: <20221212070627.1372402-1-ira.weiny@intel.com>
 <20221212070627.1372402-2-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221212070627.1372402-2-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x6lxtGeLOnPEcwtdZFsLqV0cct37VVZgLPpHqV/QTNe9gjJJFJyrlBwKtjx/?=
 =?us-ascii?Q?fpN7Qx4WV6ofJqrae4/DwSsO7cx60SfFKFvwlIrVLCCxusR8Ugkq+SMvwkVK?=
 =?us-ascii?Q?PdMuX/c/1rKRbXhVMqg0IA4fGnlA2HIdJBkGVrinEhddGyLxyDexpU67XIK7?=
 =?us-ascii?Q?WvmZTSofrGzASRcg9oP3DVGPOm+1EWp4RbmJoNbDLfybiYeDDBfMS23cSt0T?=
 =?us-ascii?Q?Li7lL36fDD65QtjrvvY/UPiEwEELB2jpxrLW69ivGhfqa0iYDi80CAQd9JKC?=
 =?us-ascii?Q?7ryMN1at/RlY5PGxrczrbWTfTPK/0wVclNR/SfM0+Sw8JZLfmHhP2mk62W/y?=
 =?us-ascii?Q?+slDTu0+GvLGA7u/cZWUwtNO7Ju0aBlmudlDM/OyGaie6STzuyHwbSZEOadV?=
 =?us-ascii?Q?XpKyNC7DtD/xwckzcK3DXzHKgBPUjJ2LNZC0fWEx3uJHjpr4iVYMpAxrEqji?=
 =?us-ascii?Q?WjeRPSIcdBvQay6Zm8/nI4vMBeKzLHLmhwA2UPY0D5jpMjx4rr1S02++YKD6?=
 =?us-ascii?Q?TNfdCsmfXaIRjEqM62jbIjIyS18uD149v8hNZEVknbltFr6hJjl0ftDSiCei?=
 =?us-ascii?Q?6RrAQmM1JN9pyhS5SuIqIvwHBHZJ3jXcWYEDk0aeCEcQIWAs1mnhxn/a33ye?=
 =?us-ascii?Q?u4OHiewbZZhDhVPmWTzDwaYPoETFm3LcLKTrDrEBYSWwZKjAyPsdxz1eEuo8?=
 =?us-ascii?Q?ZF6z1Kt6kWOOl1dI4Lc8BwCUQ3oqw6HZ94Q2nM+dAOEXGQJZPmxULDgXcCwr?=
 =?us-ascii?Q?JilWD26QVRb89DfI+y0M/pGTJRliN0Lzwc/+mDhD6tZx+/RrPR58G+XNVVfy?=
 =?us-ascii?Q?LtVvggxVn2eYr40bCTHCaRfsARBIeB15eZSm1Xg0x4ur67scVVJG+h9eFfPN?=
 =?us-ascii?Q?w1X50kGqjilA19nEIKSo39Tvhhe13S2YbSLx9n6sYPu3e/jcWbOhoR9jz4J5?=
 =?us-ascii?Q?H8LjOBpKaZjPEj5HsMai9utdaLvURA+iaMVvjEpPsKuHoYCA7O7E5HfupEF0?=
 =?us-ascii?Q?zon3Sv+OYt6F6JW4bQJC4jZkAQH0x0ebsJ2dG1rDOHeLq1esoYB32X8Z/n5C?=
 =?us-ascii?Q?MvBIEwll8WpcyA2KNBfktaZpRTjHOLwuy4zPrxLepTFmJdtH2aY6SMJFAW60?=
 =?us-ascii?Q?CKjj3scU6SmArtbRdXQ1djBLRcN0nwq9+oR25mQ5qXaB3Zi5vDMUbdIIALl9?=
 =?us-ascii?Q?FxV21xKKMF2m/GJ+LxGSUaAl7P6t/ChFWEHZMasXEo1GJiU91msRK0u4MBan?=
 =?us-ascii?Q?E4NuLAdPwNHFLxiIJau/HkCllIXLgRIZ6tFUXf8Jb0LQZgYpYMTwc4iPtgjR?=
 =?us-ascii?Q?sSa3qsw/3xPnDMsX/cR408736ZTU41FWLWE/JsZwvM1c74OZH1Up2ZoiBkGf?=
 =?us-ascii?Q?c2UC+OvQQRXhQXxvI/QxMg6UmkMbg+VNGA6QfN1YIrlAI14ohA3uEWM8ay8X?=
 =?us-ascii?Q?oDMgjpoz38p8EQUzqgxCPqEXv849VJU7zBdAMsXsQnpSn2URAjf6CTteWDCr?=
 =?us-ascii?Q?rRTzdUtNk4p5AEkvRYI3nklTnGHyGO8vAGUg2l90/I51xiXf5YvUn/aCPj1z?=
 =?us-ascii?Q?4Wtcn2sCL2s/Ze03Hx/sxCegIUDgbQ9I+aWiq+Cb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e4fe6059-6367-47f8-054b-08daeecb38c5
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 03:16:22.5960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yYnIcZsrZa7/xRWzFHAzP7nkw/JBb6yWOgDhV/+NzwcoyWzXeskTc726y5LBV8jgbzxc05d+I3Tk6JpxIGd6Xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Dec 11, 2022 at 11:06:19PM -0800, Ira wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> CXL _OSC Error Reporting Control is used by the OS to determine if
> Firmware has control of various CXL error reporting capabilities
> including the event logs.
> 
> Expose the result of negotiating CXL Error Reporting Control in struct
> pci_host_bridge for consumption by the CXL drivers.
> 

Rafael,

I should have CC'ed you on this patch.  Could I get an ack on it so Dan can
take it through the CXL tree?

Thanks,
Ira

> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Lukas Wunner <lukas@wunner.de>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-acpi@vger.kernel.org
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> ---
> Changes from V3:
> 	New patch split out
> ---
>  drivers/acpi/pci_root.c | 3 +++
>  drivers/pci/probe.c     | 1 +
>  include/linux/pci.h     | 1 +
>  3 files changed, 5 insertions(+)
> 
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index b3c202d2a433..84030804a763 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -1047,6 +1047,9 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,
>  	if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL))
>  		host_bridge->native_dpc = 0;
>  
> +	if (!(root->osc_ext_control_set & OSC_CXL_ERROR_REPORTING_CONTROL))
> +		host_bridge->native_cxl_error = 0;
> +
>  	/*
>  	 * Evaluate the "PCI Boot Configuration" _DSM Function.  If it
>  	 * exists and returns 0, we must preserve any PCI resource
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2f4e88a44e8b..34c9fd6840c4 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -596,6 +596,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge)
>  	bridge->native_ltr = 1;
>  	bridge->native_dpc = 1;
>  	bridge->domain_nr = PCI_DOMAIN_NR_NOT_SET;
> +	bridge->native_cxl_error = 1;
>  
>  	device_initialize(&bridge->dev);
>  }
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 1f81807492ef..08c3ccd2617b 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -577,6 +577,7 @@ struct pci_host_bridge {
>  	unsigned int	native_pme:1;		/* OS may use PCIe PME */
>  	unsigned int	native_ltr:1;		/* OS may use PCIe LTR */
>  	unsigned int	native_dpc:1;		/* OS may use PCIe DPC */
> +	unsigned int	native_cxl_error:1;	/* OS may use CXL RAS/Events */
>  	unsigned int	preserve_config:1;	/* Preserve FW resource setup */
>  	unsigned int	size_windows:1;		/* Enable root bus sizing */
>  	unsigned int	msi_domain:1;		/* Bridge wants MSI domain */
> -- 
> 2.37.2
>