Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 11:13:41 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH 00/27] drm/i915/gvt: KVM: KVMGT fixes and page-track
 cleanups
Message-ID: <Y7ZAZRK9NEvfV+J2@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20221223005739.1295925-1-seanjc@google.com>
 <Y6VvVrYURd/an3Zp@yzhao56-desk.sh.intel.com>
 <Y7TP2R01VAbmmfcT@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y7TP2R01VAbmmfcT@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HkIodUZLjV9YALDx8ADLZBIMENo6Nn8jy4vCUpyG6fagLmOPmUCSKS8+l5o/?=
 =?us-ascii?Q?i8dJj2P8mD0zYLsz5F478PnbYmrRB1UPo044ofsgC04iEYwrDZR2LSHp7U9u?=
 =?us-ascii?Q?hjf07Da/TqyCzbUgS6slssiLEbwj0y6m8T6vZ4g9dECryDV/pGWkSg+sKqNP?=
 =?us-ascii?Q?7mwBBkapQC/I7WtACeVJ6sS7XLzCykX23Y7M7c5Dh7HyXgWo8JTfrIb9ws1V?=
 =?us-ascii?Q?Ud4GG2Y46x42QBCokkNYsvM0CZFwMxt6P3J8nquVSOosM01cmbISSLZzeyiO?=
 =?us-ascii?Q?h1D/r5TE/lzkcwEO2c4ougLZP9jpts3n8tKYtezPW7mLO2BvR4TxWFhKDx87?=
 =?us-ascii?Q?IMfBDv+auN5bizx65OaUF6ke4TkpbYPa9wFRIFG+l4WZcpFhh2j4b+I0EZKm?=
 =?us-ascii?Q?FfD0m0e3TIGeGtDUgVHYsFSGiPF/PcSqH/iF510nqc4PB2Xjd3pigNuJZgls?=
 =?us-ascii?Q?o0G80H0BxFf3zrW6Ys+gGGRI8Cs7NhuW+XRwutw/iBViksQyZI1cMTLTDJAM?=
 =?us-ascii?Q?6KIF5K216XnX2B3vJ4EkapqNBqpPiz1XpKouo/zGu1VUFAOt5kuKEPaAZ4Wm?=
 =?us-ascii?Q?Bt/G3I14Bju3ql/7DD+dIZVzm/kG3/N/VCeM0DmKkUPOBgZy4CDUrGZcBe2/?=
 =?us-ascii?Q?Jt5zj7G6K523gffeDVNvuQyXfmaSwDfe53LHGl/33ENL/7VtH7xfD0CsRIN6?=
 =?us-ascii?Q?bWQ5emcXU7xc3lqJulfFSXjgdBs4KflW92nlVQCX68bov51OAqkCav0pJ3G5?=
 =?us-ascii?Q?cZGJ42ECs8CzY1xKlFXrtIzuFFsWCC8Fj5W+2b6WGTSPtF5KmgA3KstDGoQD?=
 =?us-ascii?Q?JKuTU/MJwui1/SJxulvGEb7Ie3XyrukUkvRNvn6VRSe4aRDLDRUeOkTnZSEk?=
 =?us-ascii?Q?M+2Km/89euBdVF+f/h/XxtKsAp24WmUbqaRVEJjO1/PdTsXX95Fo30mk6D4H?=
 =?us-ascii?Q?BNAtPprDctObe6N4d/KCkwzDlut6A54cNcR8/E413ZdDPjGnIc+Y8VNHvYdt?=
 =?us-ascii?Q?pGnSiOZjvVeqLag/X+VoXcs4/0+fUgsgeaF9kk6g+tGcPIQ8O78FsGNFs8PD?=
 =?us-ascii?Q?RFHCLhBWsE5guiMD4hOoH85T9kJL+aT5wraHrgnXKNW0IlugbquDxmP1ady0?=
 =?us-ascii?Q?jZxxSXCGgbuA5xCfBxneZgrp8b/91kcP+dTf2Adg3sgKJw+ivnOF2fzrBwpO?=
 =?us-ascii?Q?F6IkUqnMioS6Ai+b9P9plH6AZGbo4a6sHCKk9eGErCM7CEfPSz8yaC4zKMFV?=
 =?us-ascii?Q?xLDe/tkhaLI3x4o/DCtFi4SXH83NIffEjfwXR7MH/w7ewp5h9cKYCbB/x5ku?=
 =?us-ascii?Q?PpCpZugorban2AxCh5N9/b+/CkcTZGLk+PKll16T2yJPHUKC92qcDKe9l7mA?=
 =?us-ascii?Q?PZhnS31aebnL/thzE0/G2OO5O+ozlZk7Q4NRAUgwLUWjMvgUJjaFNQ0olQRN?=
 =?us-ascii?Q?QSrMYqchszljrYib9Lg63JJyVWYu6FfvEkZKmMx+z487Ia6RGGHMMkS/ahJ9?=
 =?us-ascii?Q?7xsNnR0zUAWAilwb+jfQ0pZhtQjGeDqmPrmcLNiknQa0pBRPwQsN17EyKnMB?=
 =?us-ascii?Q?xSjWX5jc7PiFmhvi1yJWbn4ksKJPNoMnW5uzsAMjAhxepdwOYw5rIsiL/EHO?=
 =?us-ascii?Q?rg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fcf3ccdf-b47a-48bd-37a7-08daeece189a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 03:36:57.1498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: olks6nUL1cDvorkWgJmsoc934iyUWwR8+3Lp7YaBLU5zn56zANYGHdV6OdyjITn35VpRSNULuccxXiNK4EuOPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6149
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 04, 2023 at 01:01:13AM +0000, Sean Christopherson wrote:
> On Fri, Dec 23, 2022, Yan Zhao wrote:
> > On Fri, Dec 23, 2022 at 12:57:12AM +0000, Sean Christopherson wrote:
> > > Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's
> > > page-track APIs to provide a leaner and cleaner interface.  The motivation
> > > for this series is to (significantly) reduce the number of KVM APIs that
> > > KVMGT uses, with a long-term goal of making all kvm_host.h headers
> > > KVM-internal.  That said, I think the cleanup itself is worthwhile,
> > > e.g. KVMGT really shouldn't be touching kvm->mmu_lock.
> > > 
> > > Note!  The KVMGT changes are compile tested only as I don't have the
> > > necessary hardware (AFAIK).  Testing, and lots of it, on the KVMGT side
> > > of things is needed and any help on that front would be much appreciated.
> > hi Sean,
> > Thanks for the patch!
> > Could you also provide the commit id that this series is based on?
> 
> The commit ID is provided in the cover letter:
> 
>   base-commit: 9d75a3251adfbcf444681474511b58042a364863
> 
> Though you might have a hard time finding that commit as it's from an old
> version of kvm/queue that's probably since been force pushed.
> 
> > I applied them on top of latest master branch (6.1.0+,
> > 8395ae05cb5a2e31d36106e8c85efa11cda849be) in repo
> > https://github.com/torvalds/linux.git, yet met some conflicts and I
> > fixed them manually. (patch 11 and patch 25).
> > 
> > A rough test shows that below mutex_init is missing.
> > But even with this fix, I still met guest hang during guest boots up.
> > Will look into it and have a detailed review next week.
> 
> Thanks again for the reviews and testing!  I'll get a v2 out in the next week or
> so (catching up from holidays) and will be more explicit in documenting the base
> version.
That's fine and it's a pleasure to me :)