Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp339011rwl; Wed, 4 Jan 2023 20:36:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXviQ4hpCfN9FuCdiEQoi4GTPUoLikPReSsxQxoaU7zDm8Yvpm1jxFcyBAR84NgOzXIKJA2o X-Received: by 2002:a17:902:e948:b0:191:309a:d752 with SMTP id b8-20020a170902e94800b00191309ad752mr55622434pll.47.1672893368692; Wed, 04 Jan 2023 20:36:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672893368; cv=none; d=google.com; s=arc-20160816; b=NRfVHj6f02AUg82jmYfSpF4GV8GuJHhClQtFMB2tj9O7yqcT+c2+N/BlWG6/mMeyP9 p9HZCKIRtgCJtQwugeVL9j0qEVpeD+tkHy0+JJuWWznNTU0obH/YnB0xfiF7cMkSqewB ZxtnGMRTw4rnEEk1dnFm69uI998yromAGlhDzpd18diXgg19RFWSq/dVpYhs02iw+i5y E48wPvMIu7qvEMXAis71gmQOvRUwyvHvRw4nx1olxGx8LAYFUOlJ5SFZNohm20nyAZxQ 6kR4mm5Ugr5I6RO2Y8f81Q5gLdtAMPN8k6chl+XO/cVnYtqYsV58TtKR7jVw5cmuzHEK gEnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=J4oDPGt7tSAoPWGWfIL7yp1U4a7QkzAs7ExHzBT4k0A=; b=Xth4vOy9YGL6u87ZM/gf9X2rfh7kChAHRzenBuTH9SXuxvtabLOcnk8fGC9B5qK+VU fYB09V7mrlo+aVa++Vw0fqTzkmojOpN+2i+ukacN2FGSxlNuu7sTKmNKK4SNPDOVctpd DliwZnnJDitCXQ8cviLIfeVrzEi1u/pi5pvCzH0hd42mADQHl4FFXyUyHUKSgas5sdfT HHp4ze2iPHJQliO6ZkzQu/zNQaX2GWpPdEIbHKkNPjjXcb4CGaj5MhZ+5bi3am9U1mIA qLjPVTOWwbQgsqzSY8ZY7zTu1Aa0DvVUgs8rtbaRw4QXNdM0MRuKd9Y8IW6AWAr4uS+8 fHQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=f1SY0Zch; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k23-20020a170902761700b0019258ae3da2si35397252pll.106.2023.01.04.20.36.01; Wed, 04 Jan 2023 20:36:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=f1SY0Zch; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbjAEEEH (ORCPT + 55 others); Wed, 4 Jan 2023 23:04:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjAEEEE (ORCPT ); Wed, 4 Jan 2023 23:04:04 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC7BE3724D; Wed, 4 Jan 2023 20:04:03 -0800 (PST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3052ocgB031542; Thu, 5 Jan 2023 04:03:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=J4oDPGt7tSAoPWGWfIL7yp1U4a7QkzAs7ExHzBT4k0A=; b=f1SY0Zch5ZHi4c2FP+6K6ocFOP2AtE7284pb9xcdiijeqJ2sTMwbQ/XPdVvG/Ei4X+Gi Q+hcZre9OvEbi01e4Mc9Hw0rBxfJ7/E4TMwuuZfVsb2pa4PL2WCX5tGTQqkNXwVJDiJS kAzy/yMjj+bulch4e/GAz7FAGPOgWg6kW2vfUkCZScfwr1HOg9SocUBeZa/i/IWRj/Yj P8IIGjEtxgawa3Uqgb3BhP14JgwAfnzM+miCUM45HKaUlvjNCCa6VYmzhNLIFQZzK56m 7M4Wy+5Eu5nbixicIEx+t7aozmjM2vI6zLN81w3RRzyH13S+UFDEMjgzpqhvJMFCfeU3 nQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mvsvfbcux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Jan 2023 04:03:56 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30543utx015824 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Jan 2023 04:03:56 GMT Received: from [10.239.155.106] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 4 Jan 2023 20:03:54 -0800 Message-ID: <9a0d7b7c-53bb-cfa6-8629-a0c48b70364f@quicinc.com> Date: Thu, 5 Jan 2023 12:03:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [RESEND PATCH v5 0/2] Add LED driver for flash module in QCOM PMICs Content-Language: en-US To: , , , , CC: , References: <20221227081523.2277797-1-quic_fenglinw@quicinc.com> From: Fenglin Wu In-Reply-To: <20221227081523.2277797-1-quic_fenglinw@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: dK-Adf1Vcl-VWoQ_gXdV7Mrov7rgc1aP X-Proofpoint-ORIG-GUID: dK-Adf1Vcl-VWoQ_gXdV7Mrov7rgc1aP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-04_07,2023-01-04_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=870 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 mlxscore=0 bulkscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301050032 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, Jones, Can you help to review the new flash LED driver changes for Qcom flash LED module when you are available? It's pending for while. Thanks Fenglin On 2022/12/27 16:15, Fenglin Wu wrote: > Initial driver and binding document changes for supporting flash LED > module in Qualcomm Technologies, Inc. PMICs. > > Changes in V5: > 1. Add MODULE_DEVICE_TABLE for auto-loading. > > Changes in V4: > 1. Added Tested-By tag. > 2. Addressed review comments in the binding change and added > Reviewed-by tag. > > Changes in V3: > 1. Updated the driver to use regmap_field for register access. > 2. Adressed the review comments in binding document change. > > Changes in V2: > 1. Addressed review comments in binding change, thanks Krzysztof! > 2. Updated driver to address the compilation issue reported by > kernel test robot. > > Fenglin Wu (2): > leds: flash: add driver to support flash LED module in QCOM PMICs > dt-bindings: leds: add QCOM flash LED controller > > .../bindings/leds/qcom,spmi-flash-led.yaml | 116 +++ > drivers/leds/flash/Kconfig | 15 + > drivers/leds/flash/Makefile | 1 + > drivers/leds/flash/leds-qcom-flash.c | 701 ++++++++++++++++++ > 4 files changed, 833 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml > create mode 100644 drivers/leds/flash/leds-qcom-flash.c >