Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp352841rwl; Wed, 4 Jan 2023 20:54:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXtxbQdVy986N/GKIAsNu3IcF3wtk/Vbv/8RvKtM8vmdJzsDFB6d+HwBQ3iEM04hVUSHZedm X-Received: by 2002:a17:90a:a788:b0:219:9a7b:b6a8 with SMTP id f8-20020a17090aa78800b002199a7bb6a8mr54051250pjq.32.1672894495964; Wed, 04 Jan 2023 20:54:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672894495; cv=none; d=google.com; s=arc-20160816; b=d/pVr1O4kKOFhMvlR39sjKQNYeklq6H9FjSP4SaFQT5sHqca/pXo1YnfXx2WMkVarA RW1S35KRd0/WhoUFb7j3xxi+nKfbow9EJcZP2j4PeQw9lxLBfWmAZL+lwmBZyIoOhwdZ W+9SdTgFm+es/gKwjhbVuAz1Cg6SKlt/Kc80de6XVfarfZWKz+z5hnLO+NV6QVcj1wZp Kxq8EhGnQA8RWLqBsVXfcblB5nnSo6sQQ8m1ycHRz79oK25QG3s9XVPeHs2BXE0+jYQF QI/efp+SE1PF4gvBgXXSJFT8kZ+o1KOoDZxzcp/uli1xe+sMMGT2ggaGRE43w//AvWLm 0Zgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=L3RKDUpLHSH4OD7mBSrVtKOYMv8CoVoHckaHZEsIkq4=; b=Qik05sCvLhTBxthkPzu5z2k/4HXeUra57Y6wZyJM2FFuMeQw4vHkpgN0/vSo6gyenS 5FeU99Ps8tPmin6u16IRHrZaH0VigI/9avzY1fj8AIZK1pqpNZ+qzERsoDfTw68EMjxI NxLHUY5v3WfMy03lHxcBEQCXgkFe1nSV8I/iEkVVJnofC8PpuPYjLB4MgiFR21BVApUm L5HrnF29HFZDKWuPIr84VkJtNBsbENfreRvMgBM4K4jZKfyz8361S0VzS/VdNZ8U/o8N Lhy+MeexllR3bMSEfZDkgDyxmr6x/vreulJxUEjiJZHmCcRFVKPYCe7ry0/rPtmVLXQW ajTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="RQIVRGo/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020a634e0c000000b004785d1cf6c4si35867844pgb.380.2023.01.04.20.54.47; Wed, 04 Jan 2023 20:54:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="RQIVRGo/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbjAEEkx (ORCPT + 57 others); Wed, 4 Jan 2023 23:40:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbjAEEkm (ORCPT ); Wed, 4 Jan 2023 23:40:42 -0500 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FBFE41D7B for ; Wed, 4 Jan 2023 20:40:41 -0800 (PST) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-476e643d1d5so387676987b3.1 for ; Wed, 04 Jan 2023 20:40:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L3RKDUpLHSH4OD7mBSrVtKOYMv8CoVoHckaHZEsIkq4=; b=RQIVRGo/f16meY9QNhwDHd5XV7H+7Q0kl6ORpJs2ivxGA7VlKL9MUklTWB6DRLKkXs WPzOx0IXj3aKuIyb02gGvX+mLXzpbmUaU2MVjnZEMBBpqRKLU9C2AF79GJoXOxfC9Cgl C8+5FjbkK661w2xwzzmQ4ryrepXFv2iiB0eDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L3RKDUpLHSH4OD7mBSrVtKOYMv8CoVoHckaHZEsIkq4=; b=KOoKfL9KXw/F+7KW1diS9Jr12qxxWDMSZo/4JgMAVapqBzfJW0f7PcsTw//FfwPVYu MEg92t/MAFxCZGKY5Re9tVlsTtgWvxH1DVE3+VBrmBhucz7J/53CDIr6vQsAY+WzIYUw FqV5tzpsKUSs960Exn5F66O101FOXwLnKaszyajWh0iNE2fGMVgXojJ1f/YaTeyoLSH0 PM/oMgGNCX23v7R1Uzk8cwEx/nGDNsafz1YwPKXGdSlzfcMykZslxl6DC7gaVWPln2m4 NhzUXcHvzoUMlp2kLG8B3GcDujaF39Y6BcH5DaTr3dJCVT65gD5O/+CtLIOHpcFsUNA4 IHsQ== X-Gm-Message-State: AFqh2krvZtEhYhwXhkuWqeqR3Mx9oYGOlMuWqVHIHdr+nNmA+sLJIeqv 7ny5IdXaNX3UutblZ+2X5UyKOOb2NQTdF1+n62lAtQ== X-Received: by 2002:a05:690c:589:b0:4b4:f4a7:3ac5 with SMTP id bo9-20020a05690c058900b004b4f4a73ac5mr685186ywb.187.1672893640435; Wed, 04 Jan 2023 20:40:40 -0800 (PST) MIME-Version: 1.0 References: <20230104011524.369764-1-robbarnes@google.com> <20230104011524.369764-2-robbarnes@google.com> In-Reply-To: <20230104011524.369764-2-robbarnes@google.com> From: Prashant Malani Date: Wed, 4 Jan 2023 20:40:28 -0800 Message-ID: Subject: Re: [PATCH v3 1/2] platform/chrome: cros_ec: Poll EC log on EC panic To: Rob Barnes Cc: groeck@chromium.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, dtor@chromium.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 3, 2023 at 5:15 PM Rob Barnes wrote: > > Add handler for CrOS EC panic events. When a panic is reported, > immediately poll for EC log. > > This should result in the log leading to the EC panic being > preserved. > > ACPI_NOTIFY_CROS_EC_PANIC is defined in coreboot at > https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src/ec/google/chromeec/acpi/ec.asl > > Signed-off-by: Rob Barnes FWIW: Reviewed-by: Prashant Malani