Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad7ef8c4-c16b-28a8-7ccb-eea98da28f62@marcan.st>
Date:   Thu, 5 Jan 2023 13:51:44 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 4/7] iommu: dart: Support a variable number of TTBRs per
 stream
Content-Language: en-US
To:     Sven Peter <sven@svenpeter.dev>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>
Cc:     Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Janne Grunau <j@jannau.net>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, iommu@lists.linux.dev,
        asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230104110013.24738-1-marcan@marcan.st>
 <20230104110013.24738-5-marcan@marcan.st>
 <6852ebfa-bebc-48cf-a31c-04801fc90af1@app.fastmail.com>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <6852ebfa-bebc-48cf-a31c-04801fc90af1@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/01/04 22:18, Sven Peter wrote:
>> @@ -993,7 +1003,7 @@ static __maybe_unused int apple_dart_resume(struct 
>> device *dev)
>>  	for (sid = 0; sid < dart->num_streams; sid++) {
>>  		for (idx = 0; idx < DART_MAX_TTBR; idx++)
> 
> s/DART_MAX_TTBR/dart->hw->ttbr_count/ I think.
> 
> With that fixed:
> 
> Reviewed-by: Sven Peter <sven@svenpeter.dev>
Yup, good catch, thanks!

- Hector