Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp387725rwl;
        Wed, 4 Jan 2023 21:37:02 -0800 (PST)
X-Google-Smtp-Source: AMrXdXv9VySQ1+YBc8R6Cfjab155+CJRv36+2PZ2USC86fPDj7aQ2zDcTQt0iAFnrywD13ommz2B
X-Received: by 2002:a17:907:b9d5:b0:81e:8dd4:51c3 with SMTP id xa21-20020a170907b9d500b0081e8dd451c3mr42928319ejc.76.1672897022604;
        Wed, 04 Jan 2023 21:37:02 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1672897022; cv=none;
        d=google.com; s=arc-20160816;
        b=Nr9zRhUULXwmYUxB1s01llCaLY79HlnJ9ckyuwrxjIubfHu0W3hEErytnSdGD5HLeU
         VrTEAgzACBihP7qaqLgkt2oo/9pQ5NWx2iwz0o+t+OTy/EPusIvNREoa07SWSAyglb5k
         hzwv+N2Jc3KZF8U5ghH2qxUzH8LtDit6CSUEzwNono2BoLVXqah17nCuXpg23jobrtdM
         fmdyeUJ98gnCK/GQW+1GpGq7r36IEZIDSlsKG7ytANse3IUqu63qZnaUViVuXJnxD19w
         QBhnWNF8VLbakUYgS1w44Dou+zYaunMdapfMjSQyfAAFpNrbyAgGjd7pNTY6SgjVEYEA
         PALQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=okWfhA+N6oQp+BC0tffLIVAurhQqoHjLeEiric5Wo3M=;
        b=jdRB/CYAXuHijmzfMq496h1B9bihcE5iSbCstBjUEnKol61qGUGAlpCH2akDkIdrZn
         zD3f/Yo4aVtBOlIZsnjVq5Wy7yMc82nzYrhCdcPbPtXFRBoDo5/tigfXx3Zexb+RVo6I
         7GiE0EP7qYxLlGwLOHV9+NA6qgejKkeW476op1aUHUYEuc+qeAVXQiPXOhqDKCr90VsH
         w5i1+2cXsDGKQ3qhhBpeNj+/M+Mlq4VKeQRLEnHhtIb6yDym8zWCSQ6RHZR3wpjX+BV4
         zTpbXamUv7h10GBSLbuxiWXygSUuzwR9f2E8E5G1joSTCavZuJvPRvQ2EqszjwbMu/qg
         UM3A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sYvGkKEG;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id g23-20020a170906349700b007813b1924ccsi25353248ejb.934.2023.01.04.21.36.49;
        Wed, 04 Jan 2023 21:37:02 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sYvGkKEG;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229778AbjAEEyr (ORCPT <rfc822;69blacklab@gmail.com> + 55 others);
        Wed, 4 Jan 2023 23:54:47 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53376 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229759AbjAEEyn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2023 23:54:43 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D81A48839;
        Wed,  4 Jan 2023 20:54:42 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id E02A3B818F2;
        Thu,  5 Jan 2023 04:54:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DAFBC433D2;
        Thu,  5 Jan 2023 04:54:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1672894479;
        bh=3jGxlIIBUtNtU8F7fzNaR/sMnXA6GWowBwE8yID47R8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=sYvGkKEGukfc64sbaHmt08pESFnbfWarRFkfT/O4/FYRdGF8I3boTRUCEdKs54bN8
         pxs8QBjxTaOIfhtyZDlR28aAZlGc+vNDIyDWMR2q7qENzNNNrMKiADCXHCNv+c3Rd9
         1H12lsJcagXjXbdAvP1jlalUHgFadKSLfWoma4cR3k+nf+18xtXrZVgDqhwcsL/ygA
         m2HoF8oojqEmUFg2qHTBMrRM1aM0Ar/vw7MyXFfJVRwxb9/VqPkMV/GyGyj9Q4iQP+
         Rd+/50OasXEZ+hR47YgZ0p3xOGkcxqp1HSJ5FVmAQkDfy6E/ZKokl6zvKduEbv4e96
         9odlMwB+6T1uA==
Date:   Wed, 4 Jan 2023 20:54:38 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] ezchip: Switch to some devm_ function to
 simplify code
Message-ID: <20230104205438.61a7dc20@kernel.org>
In-Reply-To: <e1fd0cc1fd865e58af713c92f09251e6180c1636.1672865629.git.christophe.jaillet@wanadoo.fr>
References: <cover.1672865629.git.christophe.jaillet@wanadoo.fr>
        <e1fd0cc1fd865e58af713c92f09251e6180c1636.1672865629.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed,  4 Jan 2023 22:05:33 +0100 Christophe JAILLET wrote:
> devm_alloc_etherdev() and devm_register_netdev() can be used to simplify
> code.
> 
> Now the error handling path of the probe and the remove function are
> useless and can be removed completely.

Right, but this is very likely a dead driver. Why invest in refactoring?