Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        "jiri@resnulli.us" <jiri@resnulli.us>
CC:     "leon@kernel.org" <leon@kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v4] ice: Add check for kzalloc
Thread-Topic: [Intel-wired-lan] [PATCH net v4] ice: Add check for kzalloc
Thread-Index: AQHZCwn9v0rjK++f206vYyno195yEa6PfYUg
Date:   Thu, 5 Jan 2023 05:52:13 +0000
Message-ID: <BYAPR11MB3367038BA3776DF1C17D1B97FCFA9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20221208133552.21915-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20221208133552.21915-1-jiasheng@iscas.ac.cn>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3GKaj7n2WUHqGQH00REZ5d4zUl8gQiUvAbJZv3ool3wWVbjf2EUPiBEQ1WOr?=
 =?us-ascii?Q?XNSfHU+tuIB1MiPmktu7MRwL/siDUwHMN5RBJYubnaPubAxaJgxKIYl2LG1O?=
 =?us-ascii?Q?0K3otVO9WPBUj+pFn0+73i5jBV8ih1GAU1oP+an5MP7CVOQK/kNmINVmR1WI?=
 =?us-ascii?Q?IzervQfEDrrJORp7lzbNmjb5zLZ3PixkB/SXD1AV9gEATLXCXxOyGfStf72o?=
 =?us-ascii?Q?YCk3C91AnrjibPBjdwCH0s5ZcLQb0LpTmBh4v98oHlZwijKRlHE+FvIjIqm/?=
 =?us-ascii?Q?mORywcWIUeTDUkmsPaAnlean+b8xYye5eHvrLXcfq8Svbc7JwoWnW15KCP26?=
 =?us-ascii?Q?ljMnjek2/4A616CVvzDhqSROKsxUQTV+fX9YWtCmhmuvxKk7OFJ4guR6kFo3?=
 =?us-ascii?Q?AW/wzM/c97vt/Lri060aB+22ffyjPENu+nAFKd+G+0+AquWOBXzjveU1UbzB?=
 =?us-ascii?Q?hmAbwiEO3rvyq2zPRy6udtF9MqwA2u8CIMyNk+4wJDsZBfjo3zIJ+W4Uhopq?=
 =?us-ascii?Q?XgiL/BPdMgHr3Q+RSA5OYg96IdJ5FVoi+9Flsaqkk7gAbBVdzUqiqgo6Mk98?=
 =?us-ascii?Q?aw9eFT8uyvPG+IhJic0YXNjAe4IgpQzdZ3JvnLidawLNlrX+WjBzOTGkUIdG?=
 =?us-ascii?Q?7EOAHg3xhzDGiRUYH6971/pRnGHffb7JJrTrNTvNR3wNL0GxUUYZBAAmz8Ht?=
 =?us-ascii?Q?JCkkMJ271yOpfaipakTw1F9hKfWpFVQbbU9CWL1SzKsQFb6iFzO+F6h+haOF?=
 =?us-ascii?Q?1fEZOXqMper6wj48YnIh28frrwGLSCLJGGduAs1fq4G7PSePUY1UF5GCiYtA?=
 =?us-ascii?Q?cs1Ioy9fhcMzPIVO+9Hi/Yc7tSf9QK/R5GTQJIJnajoOgrOVEaoxeg4SgLMR?=
 =?us-ascii?Q?gCrf67B58RoWoN5o5esGbPriUoYHl9dlCw/Hz2les7bgPL2omzy1QPcPAmi8?=
 =?us-ascii?Q?JojAV+OTE2T66I0ih06bU7a3B474eZ4IkOdHUwoQa4umlF7s0nA2GLJ+eWHH?=
 =?us-ascii?Q?1J10To5jiRUrZvBMoY3RGInxd90syJgsMDY33Qv6ig6UGjgxANhL8zBYGYPw?=
 =?us-ascii?Q?bRnVTmaY2zJRKzx1gFVIxy/9f1ucHOgQ7f9VF7HfAW/5aKbZYKoaphJ3ngre?=
 =?us-ascii?Q?gLB8ad7hbqrVbWAv3Gmob5ftrEPa+LLnLrH4ZQSB4+r+Op0bTsYmoNxPiod0?=
 =?us-ascii?Q?M4Vjzqg7GxVP9QPaKkfY1MVD8n+SOXE2xzomtur54HOWtZ1/Wt6wBEfMtkTP?=
 =?us-ascii?Q?1bT4SsXJeNDUb1SDYVRVzZKfhe0Lmz1/CiodaRsAGECqqYcPQBrZQBl5YCyF?=
 =?us-ascii?Q?duk6TXadUJercvh/Aul+jMERqISWPuykpX5tuQ6O/wwIsO/GjQuhJK71w2Dt?=
 =?us-ascii?Q?h3ec41iaR/CACSfmbpF8cIIN+uXbMf8m1azLVyZHmsHjghpYvMXyOPsK1RWx?=
 =?us-ascii?Q?UNwYs3pSdg9DmwPXduUGTUnL8nNdXRqrnQsQyUer5nj0V21CBN4yl0R2vOlL?=
 =?us-ascii?Q?58arP8G0LpJlZ+M2qrcytWhZECj5qv8gTHWAW0ChcZPuVltgk9NhQU3AcWPb?=
 =?us-ascii?Q?EIrwLzXswTyen+E9dKUewEJ+rbFGJbzgzybVybO+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b23d99ba-9356-48ea-5dc5-08daeee0feb8
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 05:52:13.9770
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ayndtA8It02B2uqE3ZA9YhDD/ICSyKqfn3Mxs86PypJQKYknaedQH26FvsMPKH630+hck8MJbqUwcT0Qx4xA9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6197
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jiasheng Jiang
> Sent: Thursday, December 8, 2022 7:06 PM
> To: jiri@resnulli.us
> Cc: leon@kernel.org; intel-wired-lan@lists.osuosl.org; Jiasheng Jiang
> <jiasheng@iscas.ac.cn>; Brandeburg, Jesse <jesse.brandeburg@intel.com>;
> linux-kernel@vger.kernel.org; edumazet@google.com; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; netdev@vger.kernel.org; kuba@kernel.org;
> pabeni@redhat.com; davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH net v4] ice: Add check for kzalloc
>=20
> Add the check for the return value of kzalloc in order to avoid NULL poin=
ter
> dereference.
> Moreover, use the goto-label to share the clean code.
>=20
> Fixes: d6b98c8d242a ("ice: add write functionality for GNSS TTY")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>=20
> v3 -> v4:
>=20
> 1. Move the check right after the kzalloc.
>=20
> v2 -> v3:
>=20
> 1. Use "while (i--)" to simplify the code.
>=20
> v1 -> v2:
>=20
> 1. Use goto-label to share the clean code.
> ---
>  drivers/net/ethernet/intel/ice/ice_gnss.c | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)