Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89be7b77-3478-640b-1400-5c0a1548c332@amd.com>
Date:   Thu, 5 Jan 2023 12:59:22 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v9 09/13] cpufreq: amd-pstate: add driver working mode
 switch support
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        Mario.Limonciello@amd.com, ray.huang@amd.com,
        viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221225163442.2205660-1-perry.yuan@amd.com>
 <20221225163442.2205660-10-perry.yuan@amd.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <20221225163442.2205660-10-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1FUakVOMjJpNWJMNnMrc25RS1BEL1VrWUN1NVJSMnFuRTU5M08zVVdrRi9I?=
 =?utf-8?B?c3BzZ2RKR29lcGVseFV0Wk0zTlZtT3lCYlg3alZYNVgySktaVmNlRXBscE5Z?=
 =?utf-8?B?M1l6ZUpYZGxNM21rMnZXaExrMGc5RDNhb2pYb3pib0d0Z0F3MFhDVTgyd3hu?=
 =?utf-8?B?WnFHaGQvalRwcFM4dDhxVTAyYnpuc3ZKQXp2aGI2OHpMZXUvOFgxSE5OQk92?=
 =?utf-8?B?emVXTTEydUQ2aERWc3E2dXR4RXBjeTJQWmwxVVpGMzNJaXEvQzNweXhyWjlt?=
 =?utf-8?B?dzMyQ1Qvamx0c3gzYVRGVmxGYnBqV251dWJ4d1RmcHgwQUFRb3NCaElOWDhn?=
 =?utf-8?B?K0VtbkYrVzZyWkR5V2tTVTVVRE5WdzIvRVQrekEzVnkvWURVSWpCRWJTSjhC?=
 =?utf-8?B?RWhtQUtwZzYwRFBHQkwwcXNuZDlXVExsbTV0Q3o3MTlFWTlBRUdNSElRSjNh?=
 =?utf-8?B?RklKUklQOVF3RmZrakxKd0JWUGlFZktydkhvY29KcU5YUlBMVTFmRkYvR0lu?=
 =?utf-8?B?enNxd1lJVkdhKzRxTUt2dzVWdFJnN2svaXhERmtyUjFmOFVwOFZtTndrMW1T?=
 =?utf-8?B?by9qbmhnK2ViaVJPeXNLM3dBY2w0Z1FCcWtraENFTXVUOUlUVHN2ZmNUR1U5?=
 =?utf-8?B?S1FVQm5KeTdGa0V1aHpwWCtja01JZHVHbGxZd0lRelljaC9jR1BicU1yWFZZ?=
 =?utf-8?B?TU44SThQY1BlZVVWOVlTRGNVcW1uZkdnS3JmQWxFSlpHYnRZc0JPdGo2ZkdD?=
 =?utf-8?B?RUV3YURYRXB5RzBrVFkwbDBuL3VleDAyaWN1VTk5MFBQV242L05BSFZka0w3?=
 =?utf-8?B?bHJJa3BaVHdZZ0p6SEZ2YlpqQlcvbHdUdE9LZ0xja1A4dnJXL0IzN0xKUWlL?=
 =?utf-8?B?OW1pNkdFT09yWEFoRlJod29YYXdwSGF1Tk5GUWp6QkF1MktyMDg5ZTdiL3NC?=
 =?utf-8?B?c2lZQzl3cE1YdXRNNjA4Tm9PelNwSlNUVDJkSllINVpIMVF6YVlQOEdjaWxp?=
 =?utf-8?B?WFl4bjhMQ0Z4SzdYeUFtcGwwc01qTm1tV2dnVTFiQnRtZldYUmZWY2lkMGlY?=
 =?utf-8?B?MWtTOTdHRVBmTG02VUJTT3lnbEpRdjNXZVJlQmxNWFVsRkZWeHVJZ0tVeDB0?=
 =?utf-8?B?UzU4R3dzTWFWRUhMdjFKTjBYMzFoSEtpc2t4aU1IeWFwTWM3RjJnWUI0U2Vu?=
 =?utf-8?B?TC9NTkc0cDZ2MkNOSVVuQXhEbUhEbkQ5TWxCUGVZUStwY09RMGErZUxiWlUy?=
 =?utf-8?B?WGlQVElPb2ZLV2tqYW5wVEQzeWdPTlFML3YxTXZsTWxFMHlGZUpYM1JXWXNU?=
 =?utf-8?B?ZDRvalR5aklYSzQ4V0FwNlFyNFhVeHJxd3lWY0VxeVlsMElZWlJuODE1eWlN?=
 =?utf-8?B?UVFHeEdXZTB3a1JERzJDNlk3T0x0ZWp3MTRNU3dOMTJOTEhLWXdPYjAvMnNp?=
 =?utf-8?B?L1d6S3ZpWllnYng4Q1UrU2F1Vk56UGxQVEhPMUt6WXVWMEFFZkdhNzRBV2I0?=
 =?utf-8?B?T2Voek01b3dqTjBBbHd5VDcycDZLeTRUSVRaeVZLdk42QTFmRkFYdm1aVTVl?=
 =?utf-8?B?YnB1OFR0VUhqbEo5NlRnbmdTM3VtV3ZpUG1IQWFpZWM0VndGNTlVVEtFT091?=
 =?utf-8?B?aFIyeDExWXN6YXZtTFQ3d0h1dW1OanlLbmxJUmQxck9ZcjJ4UkpmeVBrZjY2?=
 =?utf-8?B?YmUybktuOUIyR3dMNEJOcm9wR2hOY0d2ZHY5QmhzNU1ndEtPS3lNZnA1RWdM?=
 =?utf-8?B?bmF3a2dYcUdjT0w1VUNlekpCV2x6TEpJMDFZejVualBpMnRTa3MxbHAwTEdS?=
 =?utf-8?B?c1dJWUc0Nkw1RkNIeHJYY2tud2J3ZjMwbTI2L3BEN3YreTNpR0hzcHJlczAz?=
 =?utf-8?B?dFpsd0tpTWdhSmZDVSs4M1BYY29qZVFqRHRtN3hXU09RUmt6QmJ6TmF4aTlF?=
 =?utf-8?B?R3oyMitYb1Y2dEx3U0w2WVZXL1VGODBnTHF0U2twWk55bzhvdHJCSDdnanc3?=
 =?utf-8?B?RkN4blF6ajRsRnM1TUlHcVJZL2tGTzRLSUtaNEVFVG1rS2dYSGkwQmE1SWxE?=
 =?utf-8?B?TEJ0QmovMTFtQXNhTkZqeHR6czNydXhEb0NibGliS2pkR3ozWVV4K3o0S1B6?=
 =?utf-8?Q?zmj2LYFbnlDIhyNXlN5Nbjclz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56e158ba-d598-4dee-49bb-08daeeee9775
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 07:29:33.7957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IBUgGQAv4c+omDxZV6PLKafusudenjfS5XvRaMVnT5QSdGnkfFoA/5MTTjvd8dAucB37zr8h7u8ZLy8gGzfUvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6019
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Perry,

On 12/25/2022 10:04 PM, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> While amd-pstate driver was loaded with specific driver mode, it will
> need to check which mode is enabled for the pstate driver,add this sysfs
> entry to show the current status
> 
> $ cat /sys/devices/system/cpu/amd-pstate/status
> active
> 
> Meanwhile, user can switch the pstate driver mode with writing mode
> string to sysfs entry as below.
> 
> Enable passive mode:
> $ sudo bash -c "echo passive >  /sys/devices/system/cpu/amd-pstate/status"
> 
> Enable active mode (EPP driver mode):
> $ sudo bash -c "echo active > /sys/devices/system/cpu/amd-pstate/status"
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 118 +++++++++++++++++++++++++++++++++++
>  1 file changed, 118 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index e3676d1a85c7..8ceca4524fc1 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -63,6 +63,7 @@ static struct cpufreq_driver *default_pstate_driver;
>  static struct cpufreq_driver amd_pstate_driver;
>  static struct cpufreq_driver amd_pstate_epp_driver;
>  static int cppc_state = AMD_PSTATE_DISABLE;
> +struct kobject *amd_pstate_kobj;
>  
>  static inline int get_mode_idx_from_str(const char *str, size_t size)
>  {
> @@ -632,6 +633,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  	policy->driver_data = cpudata;
>  
>  	amd_pstate_boost_init(cpudata);
> +	if (!default_pstate_driver->adjust_perf)
> +		default_pstate_driver->adjust_perf = amd_pstate_adjust_perf;
>  
>  	return 0;
>  
> @@ -772,12 +775,99 @@ static ssize_t show_energy_performance_preference(
>  	return sysfs_emit(buf, "%s\n", energy_perf_strings[preference]);
>  }
>  
> +static ssize_t amd_pstate_show_status(char *buf)
> +{
> +	if (!default_pstate_driver)
> +		return sysfs_emit(buf, "off\n");
> +
> +	return sysfs_emit(buf, "%s\n", amd_pstate_mode_string[cppc_state]);
> +}
> +
> +static void amd_pstate_driver_cleanup(void)
> +{
> +	default_pstate_driver = NULL;
> +}
> +
> +static int amd_pstate_update_status(const char *buf, size_t size)
> +{
> +	int ret;
> +	int mode_idx;
> +
> +	if (size > 7 || size < 3)
> +		return -EINVAL;
> +	mode_idx = get_mode_idx_from_str(buf, size);
> +
> +	switch(mode_idx) {
> +	case AMD_PSTATE_DISABLE:
> +		if (!default_pstate_driver)
> +			return -EINVAL;
> +		if (cppc_state == AMD_PSTATE_ACTIVE)
> +			return -EBUSY;
> +		ret = cpufreq_unregister_driver(default_pstate_driver);
> +		amd_pstate_driver_cleanup();
> +		break;
> +	case AMD_PSTATE_PASSIVE:
> +		if (default_pstate_driver) {
> +			if (default_pstate_driver == &amd_pstate_driver)
> +				return 0;
> +			cpufreq_unregister_driver(default_pstate_driver);
> +			cppc_state = AMD_PSTATE_PASSIVE;
> +			default_pstate_driver = &amd_pstate_driver;
> +		}
> +
> +		ret = cpufreq_register_driver(default_pstate_driver);
> +		break;
> +	case AMD_PSTATE_ACTIVE:
> +		if (default_pstate_driver) {
> +			if (default_pstate_driver == &amd_pstate_epp_driver)
> +				return 0;
> +			cpufreq_unregister_driver(default_pstate_driver);
> +			default_pstate_driver = &amd_pstate_epp_driver;
> +			cppc_state = AMD_PSTATE_ACTIVE;
> +		}
> +
> +		ret = cpufreq_register_driver(default_pstate_driver);
> +		break;
> +	default:
> +		break;
> +		ret = -EINVAL;
> +	}
> +
> +	return ret;
> +}
> +
> +static ssize_t show_status(struct kobject *kobj,
> +			   struct kobj_attribute *attr, char *buf)
> +{
> +	ssize_t ret;
> +
> +	mutex_lock(&amd_pstate_driver_lock);
> +	ret = amd_pstate_show_status(buf);
> +	mutex_unlock(&amd_pstate_driver_lock);
> +
> +	return ret;
> +}
> +
> +static ssize_t store_status(struct kobject *a, struct kobj_attribute *b,
> +			    const char *buf, size_t count)
> +{
> +	char *p = memchr(buf, '\n', count);
> +	int ret;
> +
> +	mutex_lock(&amd_pstate_driver_lock);
> +	ret = amd_pstate_update_status(buf, p ? p - buf : count);
> +	mutex_unlock(&amd_pstate_driver_lock);
> +
> +	return ret < 0 ? ret : count;
> +}
> +
>  cpufreq_freq_attr_ro(amd_pstate_max_freq);
>  cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
>  
>  cpufreq_freq_attr_ro(amd_pstate_highest_perf);
>  cpufreq_freq_attr_rw(energy_performance_preference);
>  cpufreq_freq_attr_ro(energy_performance_available_preferences);
> +define_one_global_rw(status);
>  
>  static struct freq_attr *amd_pstate_attr[] = {
>  	&amd_pstate_max_freq,
> @@ -795,6 +885,15 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
>  	NULL,
>  };
>  
> +static struct attribute *pstate_global_attributes[] = {
> +	&status.attr,
> +	NULL
> +};
> +
> +static const struct attribute_group amd_pstate_global_attr_group = {
> +	.attrs = pstate_global_attributes,
> +};
> +
>  static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  {
>  	int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret;
> @@ -1154,6 +1253,25 @@ static int __init amd_pstate_init(void)
>  	if (ret)
>  		pr_err("failed to register with return %d\n", ret);
>  
> +	amd_pstate_kobj = kobject_create_and_add("amd-pstate", &cpu_subsys.dev_root->kobj);

IMO amd_pstate would make it more consistent because the boot param is called "amd_pstate".
But no strong opinion on this.

> +	if (!amd_pstate_kobj) {
> +		ret = -EINVAL;
> +		pr_err("global sysfs registration failed.\n");
> +		goto kobject_free;
> +	}
> +
> +	ret = sysfs_create_group(amd_pstate_kobj, &amd_pstate_global_attr_group);
> +	if (ret) {
> +		pr_err("sysfs attribute export failed with error %d.\n", ret);
> +		goto global_attr_free;
> +	}
> +
> +	return ret;
> +
> +global_attr_free:
> +	kobject_put(amd_pstate_kobj);
> +kobject_free:
> +	cpufreq_unregister_driver(default_pstate_driver);
>  	return ret;
>  }
>  device_initcall(amd_pstate_init);

-- 
Thanks & Regards,
Wyes