Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ba9a15cd-5d95-d766-19a7-17e0925bc63c@suse.com>
Date:   Thu, 5 Jan 2023 17:06:09 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"
Content-Language: en-US
To:     "Paul E. McKenney" <paulmck@kernel.org>, rcu@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, kernel-team@meta.com,
        rostedt@goodmis.org, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
References: <20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1>
 <20230105003813.1770367-18-paulmck@kernel.org>
From:   Qu Wenruo <wqu@suse.com>
In-Reply-To: <20230105003813.1770367-18-paulmck@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTVtYVNtWkpvNlVNdzR1RmRidGY2RURpRXZLS0JSbFc2Z1VBWFVzaXlQSXRY?=
 =?utf-8?B?VVJtcEwzZi9aOTVrRVJDNHYyOUNUZDZ1ZXl0SmdnWDM2TU10M25SOGtaa2Y3?=
 =?utf-8?B?a010Mm96Ui9STjFrbks1U0UxbmNJb2M4OVgvUWkrQlp2UHBXUXh3TUZDVi9m?=
 =?utf-8?B?ekFEK0Q3ajE0Q1dHbTdIOWhZYnh2a2ZaT2lwZlpNOTZ6TEltU1NiNlMwQWpm?=
 =?utf-8?B?dmZxS1V1UGMrSGx5T3RIcFVlN01RZ1NQb0E3M0xaWVpnQ3N5L2dZbWMxN011?=
 =?utf-8?B?cTZGTmcwNXZNOE94eG1rb1Z4S0VDb2REUUZ3QU9odTRBRlBRVjdQbXdPVmFl?=
 =?utf-8?B?c0V3UVZDNTJ3eXVHbHhaR2trNUNYdmJFVko3VktBK3V5MDMyeHZ3bUYyWHRh?=
 =?utf-8?B?c2czV1UrL0lBM1N6dUgzOFpDQlRFblViWnYvY2N4dDdlK1lMeHNnQzFjT3lz?=
 =?utf-8?B?cmZUMVZ4RmJmNG5JSUllMkRySmdMOEVOanE2d2hlMS9iaEY0UXZOQXpmRi9N?=
 =?utf-8?B?dmw3OTVEVnZQOWhzaW1QRytOdnpmb2R2eUFFWlVmc0NCYVlCZDY4SkVMczBr?=
 =?utf-8?B?dFd3OVlWbnZBZ2lsRkRxK1c3UHR3U3VNb3EyWDlUeVJTMTZoaVVaMmFDK2pE?=
 =?utf-8?B?SzdXOXZzV004VHV1ODZnSlVJTGR0ek5YOHBMMkQvdklleUdXcTRpcjZ0TGZa?=
 =?utf-8?B?dGh6TGNJSTRETmR4Y1BrckR1WXFQRnZ5SkVpNUdOdVBBSk9sOFBvZkxrOWtW?=
 =?utf-8?B?M2pxcFprVE5BdlBBTmpsMTF6OGJGSkhxUGNZeEF2aHh5eUdLSDF6SjlqRW9m?=
 =?utf-8?B?RXRIbWJWdSswSEZoNmdsQ25SdElvMHhVQjlGVnB6aWJtQ3hRVk1EbEVKMU9h?=
 =?utf-8?B?KzlsdzIrSUlYOFFKdk9wL3p0cnRWR2c1VmFDT1RzbUZUM3ZuUlJLUTV5eUFk?=
 =?utf-8?B?NzFnd3p5bnpMUnFseGxHMFJFT0xWRjFCT0JEbSsyL1NQUk1SS1BZWXZMUnZm?=
 =?utf-8?B?dTJYY3Vra3NaQkVqdUJNYVhmK3BLRWlGODJpendnWi91ZnZ2RzBWbkZpMk1k?=
 =?utf-8?B?QmIwby81STFvcExjdkc2dEcxNmdHU3NDb2FPMjNDR1o1K0tsVW9nN3pka1BT?=
 =?utf-8?B?cGM1SkhwU1p6TFlDTGJUSDV1TnMxT3ExYWV4VXFvZEU1Szl6SEcrQktiNllT?=
 =?utf-8?B?UWRGSkNaQWRTOXJ4YTVQR3hsenE2N0JqN0p1QU50TWlLaUltSWVPb2M2NXAz?=
 =?utf-8?B?OFJPZndDR2JSWCtDeWo2OTZqUXgveHNqczh6alloUVRQQTUrc1MxTmJVMW45?=
 =?utf-8?B?dDNNazBNRHlrNjhpVXlqUk10U2dmeUUwODdkdHFhRmxkQXFvS2U1dWZZS0k4?=
 =?utf-8?B?VFQyUFgvc3VGSGpCYjdYWUhxS2d3aTNhUzVlRjNlOFJheFdKTHhDWmQ3cFpR?=
 =?utf-8?B?T0dLM1FqWHovZGxFWnRab1dsR0htaDcrL25PaUwvbTJGUENOMndPMloxTElN?=
 =?utf-8?B?bnBDd0d5dFIxWEtMeHJoejh3bmZRVnlDcnZNaHQzMW45WGxDcFMwazVVZi9D?=
 =?utf-8?B?eWovSVArYW1BTjkzQlpGTWlQcnlTZlo4cDhzWXJhQnMxRkpVanpGcG53dUd2?=
 =?utf-8?B?bnQ0SnRGckZ3NU9CVUVwWGYxcjg1RjRaVDZROU9TUXUzcGNCbUJwNHNCTGh5?=
 =?utf-8?B?QUZVbE0zeHZUTmJHNVFObng0U1NEVVFqOUI3NEsxNGFsWVVOd1BHR3pUVm9S?=
 =?utf-8?B?NFdZYzhJTkdkZ1ZwYk5WUDUra1ErS21Ra1RHU3JCbk0xcXhETnZGeU04VFVn?=
 =?utf-8?B?MUJJc2UwVUR0K3UrejR4S1FNbHhOMzc3WnBlcUc0Q3RqNmQ1OVErT04ya3do?=
 =?utf-8?B?WkVzaGwvY0Q0OERFV3BJNVl5MW9RNnBOaXdhOURXYWpDcFdTYjNPa2s4WE1C?=
 =?utf-8?B?N3FpTVg5TDV5bG5pOFZRcjNvbkVtQUVEbzZmOHRVSHoyMWFDUi93TXlpdEFv?=
 =?utf-8?B?RDJhN0tTZ21tNVZnSWhlSHduWDM1Y3Q4VmloOFdFVWhFL1lDR0NsQ1ZRdmxu?=
 =?utf-8?B?SUsrQ2ErSnZSM1R1WlVJcjBuUCtHYU8wek9LSk53TjdtOWdObXFHZzhWMEFM?=
 =?utf-8?B?MGo5aVEzV040a2Z1UWpZWFR1OUpnM29sRURESHBvSXB4aTA3dXQxWWlhSFI4?=
 =?utf-8?Q?/SZiIk31z7jb+98Ygq0l2sg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b53966d-f4bd-4157-bac1-08daeefc1c5e
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8465.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 09:06:20.5547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ldn5zjHJM7C9/FAERhUAMrDcmXmWjfBlaVEPHBndGn0pggP3uU11LfK/cl1aYTQT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8835
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/1/5 08:38, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it.  Therefore, remove the "select SRCU"
> Kconfig statements.
> 
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Chris Mason <clm@fb.com>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: David Sterba <dsterba@suse.com>
> Cc: <linux-btrfs@vger.kernel.org>

In fact, since commit c75e839414d3 ("btrfs: kill the subvol_srcu"), we 
can completely remove any SRCU related configs and even includes.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> index 183e5c4aed348..37b6bab90c835 100644
> --- a/fs/btrfs/Kconfig
> +++ b/fs/btrfs/Kconfig
> @@ -17,7 +17,6 @@ config BTRFS_FS
>   	select FS_IOMAP
>   	select RAID6_PQ
>   	select XOR_BLOCKS
> -	select SRCU
>   	depends on PAGE_SIZE_LESS_THAN_256KB
>   
>   	help