Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 09:58:02 +0000
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     <jic23@kernel.org>, <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] iio: light: max44009: Remove the unused variable
 max44009_of_match
Message-ID: <20230105095802.00002453@Huawei.com>
In-Reply-To: <20230105095038.112564-1-jiapeng.chong@linux.alibaba.com>
References: <20230105095038.112564-1-jiapeng.chong@linux.alibaba.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, 5 Jan 2023 17:50:38 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> Variable max44009_of_match is not effectively used, so delete it.
> 
> drivers/iio/light/max44009.c:545:34: warning: ‘max44009_of_match’ defined but not used.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3632
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thanks, but a better fix would be to set the of_device_id element of the driver structure
to point to this (you'll need to move the of_device_id table up a few lines)

Also, the MODULE_DEVICE_TABLE() macro is using this if you are building
modules - so I'm fairly sure this is a false positive warning anyway.
The resulting alias can be used as part of a module autoloading.

Jonathan


> ---
>  drivers/iio/light/max44009.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/iio/light/max44009.c b/drivers/iio/light/max44009.c
> index 3dadace09fe2..2f80a654ad6a 100644
> --- a/drivers/iio/light/max44009.c
> +++ b/drivers/iio/light/max44009.c
> @@ -542,12 +542,6 @@ static struct i2c_driver max44009_driver = {
>  };
>  module_i2c_driver(max44009_driver);
>  
> -static const struct of_device_id max44009_of_match[] = {
> -	{ .compatible = "maxim,max44009" },
> -	{ }
> -};
> -MODULE_DEVICE_TABLE(of, max44009_of_match);
> -
>  MODULE_AUTHOR("Robert Eshleman <bobbyeshleman@gmail.com>");
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("MAX44009 ambient light sensor driver");