Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed7a65bb-f521-e5a5-85eb-0f24b023421b@gmx.de>
Date:   Thu, 5 Jan 2023 11:31:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [GIT PULL] fbdev fixes for v6.2-rc3
Content-Language: en-US
To:     Daniel Vetter <daniel@ffwll.ch>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <Y7aGw/irynC61O85@ls3530>
 <CAKMK7uEnFBo_YfU8OTvMS8+YkoGS=vmpGQPMa9PKxGOB3pd7nA@mail.gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <CAKMK7uEnFBo_YfU8OTvMS8+YkoGS=vmpGQPMa9PKxGOB3pd7nA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:JKWTuPJdwUo=;76xy/qSTu3Q8WMlQ9AIUR0ckxBy
 1JvLVdlUcX2Tzq2k5NOvR6fKfIlbBlfTJ1vzpHAhpD6G2pC4MkBJfZw5HQj6jFLO8Wz60ctT3
 0E+SpPCC65G65hWl/k2roZ03uk7h+tfM8s0db8ynyrQ1F6vFR+SkQ0cK7wVgpSbMgsrDY5YpG
 yz4xiEH6s51mq7jpJw743aQNk2LBMShrYSk8LhyzOTNJFoattXtVV6DkiapnoS6hI/sCBf/VD
 0Q1Nz2MqoKvmZ6OeEkkPH1WUL2SsmsojHevh3F0tbfjQcgvNSF+i6QyAC98AYmf62of1fwvrd
 so8XE/tX6Ae6mm0xEoNvBW4UhbyF7vWloBEgzASFWA1ZzmaXNxfZSbxXw3nDoQd+Env+R9GdF
 nZHsuTmJjcWPkMqBXgfDAG2AZsl4hgn6h+wBEGQwXpnwN1pkKWlEFCHWuP6CkQ3pGtwQQbZDU
 /UMXw1ixmzkTxtpezMd3wfsBHXu3abfuVuKWPEUZnQ5VfCGQ4vEXDm5C2NPl4QWYJChOMCQaM
 2qcWTiSt5b0deo6MIVJ6M/l3gOjmh8DE7+4T/FmsqP0NKNK+CjkOxPY5NJb3I6xGKrUmhmnpL
 vjCS2erU0RoYmF+xvQqzWOaC3ELnDdB/FBqHQUE8WKBSda1HPZSWaT+RZ7DPCfRVJFEWqsKTz
 rcM7PTNgSv5jt+DidbgUF2KOOXDSzkQg0u419GMVR3VHXHM2qpNDHsHoTL19x2n+SbU5wxI9L
 fppl2XVAD3+sNTdF9bW51RyUmHdI6Y+ERh6kpIWg+etNEk5IZssvje0nVYFAE9jFhIJrnJXeA
 rxx0JxPLYyYBAwEt772EyMd6KTos7EfhgKjwTL2D+IbR+ZiIaAjKyPbgrbu2/U5TFZN1+uom9
 7M3TYZDyPXD2mkneLj+X0fl80uCERzaInhFfwcLuyv4QZs+FWGAHuxJUvArlaYFhgX0SVS2iu
 i3oLFPcBYE4vunUEjepTHhmOC/s=
Precedence: bulk

On 1/5/23 11:22, Daniel Vetter wrote:
> On Thu, 5 Jan 2023 at 09:14, Helge Deller <deller@gmx.de> wrote:
>>
>> Hi Linus,
>>
>> please pull the fbdev driver updates for 6.2-rc3, to receive
>> fixes for matroxfb, offb, omapfb and fbmem.
>>
>> Thanks,
>> Helge
>>
>> ----
>>
>> The following changes since commit 1b929c02afd37871d5afb9d498426f83432e=
71c2:
>>
>>    Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)
>>
>> are available in the Git repository at:
>>
>>    http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.gi=
t tags/fbdev-for-6.2-rc3
>>
>> for you to fetch changes up to 764043cccd7232a783753a612d628fc0cb7854be=
:
>>
>>    fbdev: omapfb: avoid stack overflow warning (2023-01-04 19:09:40 +01=
00)
>>
>> ----------------------------------------------------------------
>> fbdev updates for kernel 6.2-rc3:
>>
>> - Fix Matrox G200eW initialization failure
>> - Fix build failure of offb driver when built as module
>> - Optimize stack usage in omapfb
>> - Prevent use-after-free in fbmem
>>
>> ----------------------------------------------------------------
>> Arnd Bergmann (1):
>>        fbdev: omapfb: avoid stack overflow warning
>>
>> Hang Zhang (1):
>>        fbdev: fbmem: prevent potential use-after-free issues with conso=
le_lock()
>
> I looked at this, and even by fbdev locking standards this makes
> absolutely no sense to me. I think this should be dropped before we've
> reached some sort of conclusion on what is going on, or whether this
> is just pure static checker conjecture without fully understanding how
> this is supposed to work really.
> -Daniel

Sure.

I'll send a new pull request where this patch is dropped.

Thanks!
Helge


>
>> Paul Menzel (1):
>>        fbdev: matroxfb: G200eW: Increase max memory from 1 MB to 16 MB
>>
>> Randy Dunlap (1):
>>        fbdev: make offb driver tristate
>>
>> Xu Panda (2):
>>        fbdev: omapfb: use strscpy() to instead of strncpy()
>>        fbdev: atyfb: use strscpy() to instead of strncpy()
>>
>>   drivers/video/fbdev/Kconfig                |  4 ++--
>>   drivers/video/fbdev/aty/atyfb_base.c       |  3 +--
>>   drivers/video/fbdev/core/fbmem.c           |  2 ++
>>   drivers/video/fbdev/matrox/matroxfb_base.c |  4 ++--
>>   drivers/video/fbdev/omap/omapfb_main.c     |  5 ++---
>>   drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 28 ++++++++++++++++++---=
-------
>>   6 files changed, 27 insertions(+), 19 deletions(-)
>
>
>