Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com>
Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter
 for new rules
From:   Steen Hegelund <steen.hegelund@microchip.com>
To:     Dan Carpenter <error27@gmail.com>
CC:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <UNGLinuxDriver@microchip.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Casper Andersson <casper.casan@gmail.com>,
        "Russell King" <rmk+kernel@armlinux.org.uk>,
        Wan Jiabing <wanjiabing@vivo.com>,
        "Nathan Huckleberry" <nhuck@google.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        "Daniel Machon" <daniel.machon@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>
Date:   Thu, 5 Jan 2023 11:43:17 +0100
In-Reply-To: <Y7aT8xGOCfvC/U0a@kadam>
References: <20230105081335.1261636-1-steen.hegelund@microchip.com>
         <20230105081335.1261636-3-steen.hegelund@microchip.com>
         <Y7aT8xGOCfvC/U0a@kadam>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 
MIME-Version: 1.0
Precedence: bulk

Hi Dan,

On Thu, 2023-01-05 at 12:10 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Thu, Jan 05, 2023 at 09:13:29AM +0100, Steen Hegelund wrote:
> > When a rule counter is external to the VCAP such as the Sparx5 IS2 coun=
ters
> > are, then this counter must be reset when a new rule is created.
> >=20
> > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> > ---
> > =C2=A0drivers/net/ethernet/microchip/vcap/vcap_api.c=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 | 3 +++
> > =C2=A0drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c | 4 ++--
> > =C2=A02 files changed, 5 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c
> > b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> > index b9b6432f4094..67e0a3d9103a 100644
> > --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c
> > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c
> > @@ -1808,6 +1808,7 @@ int vcap_add_rule(struct vcap_rule *rule)
> > =C2=A0{
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vcap_rule_internal *ri =3D to_int=
rule(rule);
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vcap_rule_move move =3D {0};
> > +=C2=A0=C2=A0=C2=A0=C2=A0 struct vcap_counter ctr =3D {0};
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret;
> >=20
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D vcap_api_check(ri->vctrl);
> > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D vcap_write_rule(ri);
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (ret)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 pr_err("%s:%d: rule write error: %d\n", __func__, __LINE__,
> > ret);
> > +=C2=A0=C2=A0=C2=A0=C2=A0 /* Set the counter to zero */
> > +=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D vcap_write_counter(ri, &ctr);
> > =C2=A0out:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mutex_unlock(&ri->admin->lock);
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ret;
>=20
> I feel like you intended to send a v2 series but accidentally resent
> the v1 series.=C2=A0 Otherwise I guess I have the same question as before=
.

This series was first sent to net, but the response was that I should go in=
to
net-next instead, so it is really a first version in net-next.

What was your question?  I was not able to find it...

BR
Steen

>=20
> regards,
> dan carpenter
>=20