Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 13:01:18 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next 1/5] net/ethtool: add netlink interface for the
 PLCA RS
Message-ID: <Y7at/jgmELqA984u@unreal>
References: <cover.1672840325.git.piergiorgio.beruto@gmail.com>
 <76d0a77273e4b4e7c1d22a897c4af9109a8edc51.1672840325.git.piergiorgio.beruto@gmail.com>
 <Y7aQcgR4C9Lg/+yK@unreal>
 <Y7aquABWDDmPeRAV@gvm01>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y7aquABWDDmPeRAV@gvm01>
Precedence: bulk

On Thu, Jan 05, 2023 at 11:47:20AM +0100, Piergiorgio Beruto wrote:
> Thanks Leon for your review.
> Please, see my comments below.

<...>

> > > +	ret = ethnl_ops_begin(dev);
> > > +	if (ret < 0)
> > > +		goto out;
> > 
> > I see that many places in the code used this ret > 0 check, but it looks
> > like the right check is if (ret).
> Thanks. I've fixed those, although I copied this code from similar files
> (like cable test). Maybe we should check these out as well?

I don't think that it is worth to invest time in that. The code works
the same with if (ret<0) and if(!ret).

Thanks

> > 
> > Thanks
> 
> Thanks!
> Piergiorgio